Files
compute-runtime/unit_tests/api/cl_enqueue_map_image_tests.cpp
Dunajski, Bartosz 23c1c4fea6 clEnqueueMapImage origin and region usage fixes
- Return error on origin > 0 or region > 1 when its not allowed
- For 1Darray, array region and origin are stored on 2nd position.
  For 2Darray, its on 3rd postion
- Fix map offset for 1Darray image
- Fix CPU data transfer for 1Darray image

Change-Id: Id35ba5f54f117e7af318ca7e6e03c1fc942ce729
2018-03-08 08:54:48 +01:00

328 lines
11 KiB
C++

/*
* Copyright (c) 2017, Intel Corporation
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included
* in all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
* OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR
* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
* OTHER DEALINGS IN THE SOFTWARE.
*/
#include "cl_api_tests.h"
#include "runtime/command_queue/command_queue.h"
#include "runtime/context/context.h"
#include "runtime/helpers/surface_formats.h"
#include "unit_tests/fixtures/image_fixture.h"
using namespace OCLRT;
namespace ULT {
struct clEnqueueMapImageTests : public api_fixture,
public ::testing::Test {
void SetUp() override {
api_fixture::SetUp();
// clang-format off
imageFormat.image_channel_order = CL_RGBA;
imageFormat.image_channel_data_type = CL_UNORM_INT8;
imageDesc.image_type = CL_MEM_OBJECT_IMAGE2D;
imageDesc.image_width = 32;
imageDesc.image_height = 32;
imageDesc.image_depth = 1;
imageDesc.image_array_size = 1;
imageDesc.image_row_pitch = 0;
imageDesc.image_slice_pitch = 0;
imageDesc.num_mip_levels = 0;
imageDesc.num_samples = 0;
imageDesc.mem_object = nullptr;
// clang-format on
}
void TearDown() override {
api_fixture::TearDown();
}
cl_image_format imageFormat;
cl_image_desc imageDesc;
};
TEST_F(clEnqueueMapImageTests, returnsSuccess) {
auto image = clCreateImage(
pContext,
CL_MEM_READ_WRITE,
&imageFormat,
&imageDesc,
nullptr,
&retVal);
ASSERT_EQ(CL_SUCCESS, retVal);
EXPECT_NE(nullptr, image);
const size_t origin[3] = {0, 0, 0};
const size_t region[3] = {1, 1, 1};
size_t imageRowPitch = 0;
size_t imageSlicePitch = 0;
clEnqueueMapImage(
pCommandQueue,
image,
CL_TRUE,
CL_MAP_READ,
origin,
region,
&imageRowPitch,
&imageSlicePitch,
0,
nullptr,
nullptr,
&retVal);
EXPECT_EQ(CL_SUCCESS, retVal);
retVal = clReleaseMemObject(image);
EXPECT_EQ(CL_SUCCESS, retVal);
}
TEST_F(clEnqueueMapImageTests, givenAnyZeroRegionParamWhenMapImageCalledThenReturnError) {
auto image = clCreateImage(pContext, CL_MEM_READ_WRITE, &imageFormat, &imageDesc, nullptr, &retVal);
ASSERT_EQ(CL_SUCCESS, retVal);
EXPECT_NE(nullptr, image);
const size_t origin[3] = {0, 0, 0};
std::array<size_t, 3> region = {{0, 1, 1}};
auto ptr = clEnqueueMapImage(pCommandQueue, image, CL_TRUE, CL_MAP_READ, origin, &region[0], nullptr, nullptr, 0, nullptr, nullptr, &retVal);
EXPECT_EQ(CL_INVALID_VALUE, retVal);
EXPECT_EQ(nullptr, ptr);
region = {{1, 0, 1}};
ptr = clEnqueueMapImage(pCommandQueue, image, CL_TRUE, CL_MAP_READ, origin, &region[0], nullptr, nullptr, 0, nullptr, nullptr, &retVal);
EXPECT_EQ(CL_INVALID_VALUE, retVal);
EXPECT_EQ(nullptr, ptr);
region = {{1, 1, 0}};
ptr = clEnqueueMapImage(pCommandQueue, image, CL_TRUE, CL_MAP_READ, origin, &region[0], nullptr, nullptr, 0, nullptr, nullptr, &retVal);
EXPECT_EQ(CL_INVALID_VALUE, retVal);
EXPECT_EQ(nullptr, ptr);
region = {{0, 0, 0}};
ptr = clEnqueueMapImage(pCommandQueue, image, CL_TRUE, CL_MAP_READ, origin, &region[0], nullptr, nullptr, 0, nullptr, nullptr, &retVal);
EXPECT_EQ(CL_INVALID_VALUE, retVal);
EXPECT_EQ(nullptr, ptr);
retVal = clReleaseMemObject(image);
EXPECT_EQ(CL_SUCCESS, retVal);
}
TEST_F(clEnqueueMapImageTests, givenSecondOriginCoordinateAndNotAllowedImgTypeWhenMapCalledThenReturnError) {
size_t region[3] = {1, 1, 1};
size_t origin[3] = {0, 1, 0};
std::unique_ptr<Image> image(ImageHelper<Image1dDefaults>::create(pContext));
clEnqueueMapImage(pCommandQueue, image.get(), CL_TRUE, CL_MAP_READ, origin, region, 0, 0, 0, nullptr, nullptr, &retVal);
EXPECT_EQ(CL_INVALID_VALUE, retVal);
auto image1dBufferDesc = Image1dDefaults::imageDesc;
image1dBufferDesc.image_type = CL_MEM_OBJECT_IMAGE1D_BUFFER;
image.reset(ImageHelper<Image1dDefaults>::create(pContext, &image1dBufferDesc));
clEnqueueMapImage(pCommandQueue, image.get(), CL_TRUE, CL_MAP_READ, origin, region, 0, 0, 0, nullptr, nullptr, &retVal);
EXPECT_EQ(CL_INVALID_VALUE, retVal);
}
TEST_F(clEnqueueMapImageTests, givenThirdOriginCoordinateAndNotAllowedImgTypeWhenMapCalledThenReturnError) {
size_t region[3] = {1, 1, 1};
size_t origin[3] = {0, 0, 1};
std::unique_ptr<Image> image(ImageHelper<Image1dDefaults>::create(pContext));
clEnqueueMapImage(pCommandQueue, image.get(), CL_TRUE, CL_MAP_READ, origin, region, 0, 0, 0, nullptr, nullptr, &retVal);
EXPECT_EQ(CL_INVALID_VALUE, retVal);
image.reset(ImageHelper<Image2dDefaults>::create(pContext));
clEnqueueMapImage(pCommandQueue, image.get(), CL_TRUE, CL_MAP_READ, origin, region, 0, 0, 0, nullptr, nullptr, &retVal);
EXPECT_EQ(CL_INVALID_VALUE, retVal);
image.reset(ImageHelper<Image1dArrayDefaults>::create(pContext));
clEnqueueMapImage(pCommandQueue, image.get(), CL_TRUE, CL_MAP_READ, origin, region, 0, 0, 0, nullptr, nullptr, &retVal);
EXPECT_EQ(CL_INVALID_VALUE, retVal);
auto image1dBufferDesc = Image1dDefaults::imageDesc;
image1dBufferDesc.image_type = CL_MEM_OBJECT_IMAGE1D_BUFFER;
image.reset(ImageHelper<Image1dDefaults>::create(pContext, &image1dBufferDesc));
clEnqueueMapImage(pCommandQueue, image.get(), CL_TRUE, CL_MAP_READ, origin, region, 0, 0, 0, nullptr, nullptr, &retVal);
EXPECT_EQ(CL_INVALID_VALUE, retVal);
}
TEST_F(clEnqueueMapImageTests, givenSecondRegionCoordinateAndNotAllowedImgTypeWhenMapCalledThenReturnError) {
size_t region[3] = {1, 2, 1};
size_t origin[3] = {0, 0, 0};
std::unique_ptr<Image> image(ImageHelper<Image1dDefaults>::create(pContext));
clEnqueueMapImage(pCommandQueue, image.get(), CL_TRUE, CL_MAP_READ, origin, region, 0, 0, 0, nullptr, nullptr, &retVal);
EXPECT_EQ(CL_INVALID_VALUE, retVal);
auto image1dBufferDesc = Image1dDefaults::imageDesc;
image1dBufferDesc.image_type = CL_MEM_OBJECT_IMAGE1D_BUFFER;
image.reset(ImageHelper<Image1dDefaults>::create(pContext, &image1dBufferDesc));
clEnqueueMapImage(pCommandQueue, image.get(), CL_TRUE, CL_MAP_READ, origin, region, 0, 0, 0, nullptr, nullptr, &retVal);
EXPECT_EQ(CL_INVALID_VALUE, retVal);
}
TEST_F(clEnqueueMapImageTests, givenThirdRegionnCoordinateAndNotAllowedImgTypeWhenMapCalledThenReturnError) {
size_t region[3] = {1, 1, 2};
size_t origin[3] = {0, 0, 0};
std::unique_ptr<Image> image(ImageHelper<Image1dDefaults>::create(pContext));
clEnqueueMapImage(pCommandQueue, image.get(), CL_TRUE, CL_MAP_READ, origin, region, 0, 0, 0, nullptr, nullptr, &retVal);
EXPECT_EQ(CL_INVALID_VALUE, retVal);
image.reset(ImageHelper<Image2dDefaults>::create(pContext));
clEnqueueMapImage(pCommandQueue, image.get(), CL_TRUE, CL_MAP_READ, origin, region, 0, 0, 0, nullptr, nullptr, &retVal);
EXPECT_EQ(CL_INVALID_VALUE, retVal);
image.reset(ImageHelper<Image1dArrayDefaults>::create(pContext));
clEnqueueMapImage(pCommandQueue, image.get(), CL_TRUE, CL_MAP_READ, origin, region, 0, 0, 0, nullptr, nullptr, &retVal);
EXPECT_EQ(CL_INVALID_VALUE, retVal);
auto image1dBufferDesc = Image1dDefaults::imageDesc;
image1dBufferDesc.image_type = CL_MEM_OBJECT_IMAGE1D_BUFFER;
image.reset(ImageHelper<Image1dDefaults>::create(pContext, &image1dBufferDesc));
clEnqueueMapImage(pCommandQueue, image.get(), CL_TRUE, CL_MAP_READ, origin, region, 0, 0, 0, nullptr, nullptr, &retVal);
EXPECT_EQ(CL_INVALID_VALUE, retVal);
}
struct clEnqueueMapImageYUVTests : public api_fixture,
public ::testing::Test {
void SetUp() override {
api_fixture::SetUp();
// clang-format off
imageFormat.image_channel_order = CL_YUYV_INTEL;
imageFormat.image_channel_data_type = CL_UNORM_INT8;
imageDesc.image_type = CL_MEM_OBJECT_IMAGE2D;
imageDesc.image_width = 32;
imageDesc.image_height = 32;
imageDesc.image_depth = 1;
imageDesc.image_array_size = 1;
imageDesc.image_row_pitch = 0;
imageDesc.image_slice_pitch = 0;
imageDesc.num_mip_levels = 0;
imageDesc.num_samples = 0;
imageDesc.mem_object = nullptr;
// clang-format on
}
void TearDown() override {
api_fixture::TearDown();
}
cl_image_format imageFormat;
cl_image_desc imageDesc;
};
TEST_F(clEnqueueMapImageYUVTests, returnSuccess) {
auto image = clCreateImage(
pContext,
CL_MEM_READ_ONLY,
&imageFormat,
&imageDesc,
nullptr,
&retVal);
ASSERT_EQ(CL_SUCCESS, retVal);
EXPECT_NE(nullptr, image);
const size_t origin[] = {2, 2, 0};
const size_t region[] = {2, 2, 1};
clEnqueueMapImage(
pCommandQueue,
image,
CL_TRUE,
CL_MAP_READ,
origin,
region,
0,
0,
0,
nullptr,
nullptr,
&retVal);
EXPECT_EQ(CL_SUCCESS, retVal);
retVal = clReleaseMemObject(image);
EXPECT_EQ(CL_SUCCESS, retVal);
}
TEST_F(clEnqueueMapImageYUVTests, invalidOrigin) {
auto image = clCreateImage(
pContext,
CL_MEM_READ_ONLY,
&imageFormat,
&imageDesc,
nullptr,
&retVal);
ASSERT_EQ(CL_SUCCESS, retVal);
EXPECT_NE(nullptr, image);
const size_t origin[] = {1, 2, 0};
const size_t region[] = {2, 2, 0};
clEnqueueMapImage(
pCommandQueue,
image,
CL_TRUE,
CL_MAP_READ,
origin,
region,
0,
0,
0,
nullptr,
nullptr,
&retVal);
EXPECT_EQ(CL_INVALID_VALUE, retVal);
retVal = clReleaseMemObject(image);
EXPECT_EQ(CL_SUCCESS, retVal);
}
TEST_F(clEnqueueMapImageYUVTests, invalidRegion) {
auto image = clCreateImage(
pContext,
CL_MEM_READ_ONLY,
&imageFormat,
&imageDesc,
nullptr,
&retVal);
ASSERT_EQ(CL_SUCCESS, retVal);
EXPECT_NE(nullptr, image);
const size_t origin[] = {2, 2, 0};
const size_t region[] = {1, 2, 0};
clEnqueueMapImage(
pCommandQueue,
image,
CL_TRUE,
CL_MAP_READ,
origin,
region,
0,
0,
0,
nullptr,
nullptr,
&retVal);
EXPECT_EQ(CL_INVALID_VALUE, retVal);
retVal = clReleaseMemObject(image);
EXPECT_EQ(CL_SUCCESS, retVal);
}
} // namespace ULT