Files
llvm/mlir/unittests/Transforms/DialectConversion.cpp

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

137 lines
3.8 KiB
C++
Raw Normal View History

//===- DialectConversion.cpp - Dialect conversion unit tests --------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "mlir/Transforms/DialectConversion.h"
#include "gtest/gtest.h"
using namespace mlir;
static Operation *createOp(MLIRContext *context) {
context->allowUnregisteredDialects();
Introduce MLIR Op Properties This new features enabled to dedicate custom storage inline within operations. This storage can be used as an alternative to attributes to store data that is specific to an operation. Attribute can also be stored inside the properties storage if desired, but any kind of data can be present as well. This offers a way to store and mutate data without uniquing in the Context like Attribute. See the OpPropertiesTest.cpp for an example where a struct with a std::vector<> is attached to an operation and mutated in-place: struct TestProperties { int a = -1; float b = -1.; std::vector<int64_t> array = {-33}; }; More complex scheme (including reference-counting) are also possible. The only constraint to enable storing a C++ object as "properties" on an operation is to implement three functions: - convert from the candidate object to an Attribute - convert from the Attribute to the candidate object - hash the object Optional the parsing and printing can also be customized with 2 extra functions. A new options is introduced to ODS to allow dialects to specify: let usePropertiesForAttributes = 1; When set to true, the inherent attributes for all the ops in this dialect will be using properties instead of being stored alongside discardable attributes. The TestDialect showcases this feature. Another change is that we introduce new APIs on the Operation class to access separately the inherent attributes from the discardable ones. We envision deprecating and removing the `getAttr()`, `getAttrsDictionary()`, and other similar method which don't make the distinction explicit, leading to an entirely separate namespace for discardable attributes. Recommit d572cd1b067f after fixing python bindings build. Differential Revision: https://reviews.llvm.org/D141742
2023-02-26 10:46:01 -05:00
return Operation::create(
UnknownLoc::get(context), OperationName("foo.bar", context), std::nullopt,
std::nullopt, std::nullopt, /*properties=*/nullptr, std::nullopt, 0);
}
namespace {
struct DummyOp {
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(DummyOp)
static StringRef getOperationName() { return "foo.bar"; }
};
TEST(DialectConversionTest, DynamicallyLegalOpCallbackOrder) {
MLIRContext context;
ConversionTarget target(context);
int index = 0;
int callbackCalled1 = 0;
target.addDynamicallyLegalOp<DummyOp>([&](Operation *) {
callbackCalled1 = ++index;
return true;
});
int callbackCalled2 = 0;
target.addDynamicallyLegalOp<DummyOp>(
[&](Operation *) -> std::optional<bool> {
callbackCalled2 = ++index;
return std::nullopt;
});
auto *op = createOp(&context);
EXPECT_TRUE(target.isLegal(op));
EXPECT_EQ(2, callbackCalled1);
EXPECT_EQ(1, callbackCalled2);
EXPECT_FALSE(target.isIllegal(op));
EXPECT_EQ(4, callbackCalled1);
EXPECT_EQ(3, callbackCalled2);
op->destroy();
}
TEST(DialectConversionTest, DynamicallyLegalOpCallbackSkip) {
MLIRContext context;
ConversionTarget target(context);
int index = 0;
int callbackCalled = 0;
target.addDynamicallyLegalOp<DummyOp>(
[&](Operation *) -> std::optional<bool> {
callbackCalled = ++index;
return std::nullopt;
});
auto *op = createOp(&context);
EXPECT_FALSE(target.isLegal(op));
EXPECT_EQ(1, callbackCalled);
EXPECT_FALSE(target.isIllegal(op));
EXPECT_EQ(2, callbackCalled);
op->destroy();
}
TEST(DialectConversionTest, DynamicallyLegalUnknownOpCallbackOrder) {
MLIRContext context;
ConversionTarget target(context);
int index = 0;
int callbackCalled1 = 0;
target.markUnknownOpDynamicallyLegal([&](Operation *) {
callbackCalled1 = ++index;
return true;
});
int callbackCalled2 = 0;
target.markUnknownOpDynamicallyLegal([&](Operation *) -> std::optional<bool> {
callbackCalled2 = ++index;
return std::nullopt;
});
auto *op = createOp(&context);
EXPECT_TRUE(target.isLegal(op));
EXPECT_EQ(2, callbackCalled1);
EXPECT_EQ(1, callbackCalled2);
EXPECT_FALSE(target.isIllegal(op));
EXPECT_EQ(4, callbackCalled1);
EXPECT_EQ(3, callbackCalled2);
op->destroy();
}
TEST(DialectConversionTest, DynamicallyLegalReturnNone) {
MLIRContext context;
ConversionTarget target(context);
target.addDynamicallyLegalOp<DummyOp>(
[&](Operation *) -> std::optional<bool> { return std::nullopt; });
auto *op = createOp(&context);
EXPECT_FALSE(target.isLegal(op));
EXPECT_FALSE(target.isIllegal(op));
EXPECT_TRUE(succeeded(applyPartialConversion(op, target, {})));
EXPECT_TRUE(failed(applyFullConversion(op, target, {})));
op->destroy();
}
TEST(DialectConversionTest, DynamicallyLegalUnknownReturnNone) {
MLIRContext context;
ConversionTarget target(context);
target.markUnknownOpDynamicallyLegal(
[&](Operation *) -> std::optional<bool> { return std::nullopt; });
auto *op = createOp(&context);
EXPECT_FALSE(target.isLegal(op));
EXPECT_FALSE(target.isIllegal(op));
EXPECT_TRUE(succeeded(applyPartialConversion(op, target, {})));
EXPECT_TRUE(failed(applyFullConversion(op, target, {})));
op->destroy();
}
} // namespace