Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
//===-- SymbolFilePDB.cpp ---------------------------------------*- C++ -*-===//
|
|
|
|
|
//
|
|
|
|
|
// The LLVM Compiler Infrastructure
|
|
|
|
|
//
|
|
|
|
|
// This file is distributed under the University of Illinois Open Source
|
|
|
|
|
// License. See LICENSE.TXT for details.
|
|
|
|
|
//
|
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
|
|
|
|
|
|
#include "SymbolFilePDB.h"
|
|
|
|
|
|
2016-04-15 00:21:26 +00:00
|
|
|
#include "clang/Lex/Lexer.h"
|
|
|
|
|
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
#include "lldb/Core/Module.h"
|
|
|
|
|
#include "lldb/Core/PluginManager.h"
|
2016-04-15 00:21:26 +00:00
|
|
|
#include "lldb/Symbol/ClangASTContext.h"
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
#include "lldb/Symbol/CompileUnit.h"
|
|
|
|
|
#include "lldb/Symbol/LineTable.h"
|
|
|
|
|
#include "lldb/Symbol/ObjectFile.h"
|
|
|
|
|
#include "lldb/Symbol/SymbolContext.h"
|
2018-01-13 06:58:18 +00:00
|
|
|
#include "lldb/Symbol/SymbolVendor.h"
|
2018-01-23 20:35:19 +00:00
|
|
|
#include "lldb/Symbol/TypeList.h"
|
2018-03-22 19:26:33 +00:00
|
|
|
#include "lldb/Symbol/TypeMap.h"
|
2018-05-23 01:52:42 +00:00
|
|
|
#include "lldb/Symbol/Variable.h"
|
2017-12-22 05:26:50 +00:00
|
|
|
#include "lldb/Utility/RegularExpression.h"
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
|
2016-05-09 11:07:43 +00:00
|
|
|
#include "llvm/DebugInfo/PDB/GenericError.h"
|
2017-12-22 00:04:36 +00:00
|
|
|
#include "llvm/DebugInfo/PDB/IPDBDataStream.h"
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
#include "llvm/DebugInfo/PDB/IPDBEnumChildren.h"
|
|
|
|
|
#include "llvm/DebugInfo/PDB/IPDBLineNumber.h"
|
2018-03-22 19:26:33 +00:00
|
|
|
#include "llvm/DebugInfo/PDB/IPDBSectionContrib.h"
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
#include "llvm/DebugInfo/PDB/IPDBSourceFile.h"
|
2017-12-22 00:04:36 +00:00
|
|
|
#include "llvm/DebugInfo/PDB/IPDBTable.h"
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
#include "llvm/DebugInfo/PDB/PDBSymbol.h"
|
2018-02-09 05:31:28 +00:00
|
|
|
#include "llvm/DebugInfo/PDB/PDBSymbolBlock.h"
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
#include "llvm/DebugInfo/PDB/PDBSymbolCompiland.h"
|
|
|
|
|
#include "llvm/DebugInfo/PDB/PDBSymbolCompilandDetails.h"
|
2017-12-22 00:04:36 +00:00
|
|
|
#include "llvm/DebugInfo/PDB/PDBSymbolData.h"
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
#include "llvm/DebugInfo/PDB/PDBSymbolExe.h"
|
|
|
|
|
#include "llvm/DebugInfo/PDB/PDBSymbolFunc.h"
|
|
|
|
|
#include "llvm/DebugInfo/PDB/PDBSymbolFuncDebugEnd.h"
|
|
|
|
|
#include "llvm/DebugInfo/PDB/PDBSymbolFuncDebugStart.h"
|
2018-02-09 05:31:28 +00:00
|
|
|
#include "llvm/DebugInfo/PDB/PDBSymbolPublicSymbol.h"
|
2016-04-15 00:21:26 +00:00
|
|
|
#include "llvm/DebugInfo/PDB/PDBSymbolTypeEnum.h"
|
|
|
|
|
#include "llvm/DebugInfo/PDB/PDBSymbolTypeTypedef.h"
|
|
|
|
|
#include "llvm/DebugInfo/PDB/PDBSymbolTypeUDT.h"
|
|
|
|
|
|
[PDB] Parse UDT symbols and pointers to members (combined patch)
Summary:
In this patch I've tried to combine the best ideas from D49368 and D49410,
so it implements following:
- Completion of UDTs from a PDB with a filling of a layout info;
- Pointers to members;
- Fixes the bug relating to a virtual base offset reading from `vbtable`.
The offset was treated as an unsigned, but it can be a negative sometimes.
- Support of MSInheritance attribute
Reviewers: asmith, zturner, rnk, labath, clayborg, lldb-commits
Reviewed By: zturner
Subscribers: aleksandr.urakov, stella.stamenova, JDevlieghere, lldb-commits
Differential Revision: https://reviews.llvm.org/D49980
llvm-svn: 339649
2018-08-14 07:57:44 +00:00
|
|
|
#include "Plugins/Language/CPlusPlus/CPlusPlusLanguage.h" // For IsCPPMangledName
|
2018-10-12 19:47:13 +00:00
|
|
|
#include "Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.h"
|
2016-04-15 00:21:26 +00:00
|
|
|
#include "Plugins/SymbolFile/PDB/PDBASTParser.h"
|
2018-07-13 10:29:27 +00:00
|
|
|
#include "Plugins/SymbolFile/PDB/PDBLocationToDWARFExpression.h"
|
2016-04-15 00:21:26 +00:00
|
|
|
|
|
|
|
|
#include <regex>
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
|
2018-01-13 06:58:18 +00:00
|
|
|
using namespace lldb;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
using namespace lldb_private;
|
2016-05-04 20:33:53 +00:00
|
|
|
using namespace llvm::pdb;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
namespace {
|
|
|
|
|
lldb::LanguageType TranslateLanguage(PDB_Lang lang) {
|
|
|
|
|
switch (lang) {
|
|
|
|
|
case PDB_Lang::Cpp:
|
|
|
|
|
return lldb::LanguageType::eLanguageTypeC_plus_plus;
|
|
|
|
|
case PDB_Lang::C:
|
|
|
|
|
return lldb::LanguageType::eLanguageTypeC;
|
|
|
|
|
default:
|
|
|
|
|
return lldb::LanguageType::eLanguageTypeUnknown;
|
|
|
|
|
}
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
bool ShouldAddLine(uint32_t requested_line, uint32_t actual_line,
|
|
|
|
|
uint32_t addr_length) {
|
|
|
|
|
return ((requested_line == 0 || actual_line == requested_line) &&
|
|
|
|
|
addr_length > 0);
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
2018-03-22 03:44:51 +00:00
|
|
|
} // namespace
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
|
2018-10-12 19:47:13 +00:00
|
|
|
static bool ShouldUseNativeReader() {
|
|
|
|
|
#if !defined(_WIN32)
|
|
|
|
|
return true;
|
|
|
|
|
#endif
|
|
|
|
|
llvm::StringRef use_native = ::getenv("LLDB_USE_NATIVE_PDB_READER");
|
|
|
|
|
return use_native.equals_lower("on") || use_native.equals_lower("yes") ||
|
|
|
|
|
use_native.equals_lower("1") || use_native.equals_lower("true");
|
|
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
void SymbolFilePDB::Initialize() {
|
2018-10-12 19:47:13 +00:00
|
|
|
if (ShouldUseNativeReader()) {
|
|
|
|
|
npdb::SymbolFileNativePDB::Initialize();
|
|
|
|
|
} else {
|
|
|
|
|
PluginManager::RegisterPlugin(GetPluginNameStatic(),
|
|
|
|
|
GetPluginDescriptionStatic(), CreateInstance,
|
|
|
|
|
DebuggerInitialize);
|
|
|
|
|
}
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
void SymbolFilePDB::Terminate() {
|
2018-10-12 19:47:13 +00:00
|
|
|
if (ShouldUseNativeReader()) {
|
|
|
|
|
npdb::SymbolFileNativePDB::Terminate();
|
|
|
|
|
} else {
|
|
|
|
|
PluginManager::UnregisterPlugin(CreateInstance);
|
|
|
|
|
}
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
void SymbolFilePDB::DebuggerInitialize(lldb_private::Debugger &debugger) {}
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
lldb_private::ConstString SymbolFilePDB::GetPluginNameStatic() {
|
|
|
|
|
static ConstString g_name("pdb");
|
|
|
|
|
return g_name;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
const char *SymbolFilePDB::GetPluginDescriptionStatic() {
|
|
|
|
|
return "Microsoft PDB debug symbol file reader.";
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
lldb_private::SymbolFile *
|
|
|
|
|
SymbolFilePDB::CreateInstance(lldb_private::ObjectFile *obj_file) {
|
|
|
|
|
return new SymbolFilePDB(obj_file);
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
SymbolFilePDB::SymbolFilePDB(lldb_private::ObjectFile *object_file)
|
2018-01-13 06:58:18 +00:00
|
|
|
: SymbolFile(object_file), m_session_up(), m_global_scope_up(),
|
|
|
|
|
m_cached_compile_unit_count(0), m_tu_decl_ctx_up() {}
|
2016-09-06 20:57:50 +00:00
|
|
|
|
|
|
|
|
SymbolFilePDB::~SymbolFilePDB() {}
|
|
|
|
|
|
|
|
|
|
uint32_t SymbolFilePDB::CalculateAbilities() {
|
2017-12-22 00:04:36 +00:00
|
|
|
uint32_t abilities = 0;
|
|
|
|
|
if (!m_obj_file)
|
|
|
|
|
return 0;
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
if (!m_session_up) {
|
|
|
|
|
// Lazily load and match the PDB file, but only do this once.
|
|
|
|
|
std::string exePath = m_obj_file->GetFileSpec().GetPath();
|
|
|
|
|
auto error = loadDataForEXE(PDB_ReaderType::DIA, llvm::StringRef(exePath),
|
|
|
|
|
m_session_up);
|
|
|
|
|
if (error) {
|
|
|
|
|
llvm::consumeError(std::move(error));
|
2017-12-22 00:04:36 +00:00
|
|
|
auto module_sp = m_obj_file->GetModule();
|
|
|
|
|
if (!module_sp)
|
|
|
|
|
return 0;
|
|
|
|
|
// See if any symbol file is specified through `--symfile` option.
|
|
|
|
|
FileSpec symfile = module_sp->GetSymbolFileFileSpec();
|
|
|
|
|
if (!symfile)
|
|
|
|
|
return 0;
|
|
|
|
|
error = loadDataForPDB(PDB_ReaderType::DIA,
|
2018-03-22 03:44:51 +00:00
|
|
|
llvm::StringRef(symfile.GetPath()), m_session_up);
|
2017-12-22 00:04:36 +00:00
|
|
|
if (error) {
|
|
|
|
|
llvm::consumeError(std::move(error));
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2018-03-22 19:21:34 +00:00
|
|
|
if (!m_session_up)
|
2017-12-22 00:04:36 +00:00
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
auto enum_tables_up = m_session_up->getEnumTables();
|
|
|
|
|
if (!enum_tables_up)
|
|
|
|
|
return 0;
|
|
|
|
|
while (auto table_up = enum_tables_up->getNext()) {
|
|
|
|
|
if (table_up->getItemCount() == 0)
|
|
|
|
|
continue;
|
|
|
|
|
auto type = table_up->getTableType();
|
|
|
|
|
switch (type) {
|
|
|
|
|
case PDB_TableType::Symbols:
|
|
|
|
|
// This table represents a store of symbols with types listed in
|
|
|
|
|
// PDBSym_Type
|
2018-03-22 03:44:51 +00:00
|
|
|
abilities |= (CompileUnits | Functions | Blocks | GlobalVariables |
|
|
|
|
|
LocalVariables | VariableTypes);
|
2017-12-22 00:04:36 +00:00
|
|
|
break;
|
|
|
|
|
case PDB_TableType::LineNumbers:
|
|
|
|
|
abilities |= LineTables;
|
|
|
|
|
break;
|
2018-03-22 03:44:51 +00:00
|
|
|
default:
|
|
|
|
|
break;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
2016-09-06 20:57:50 +00:00
|
|
|
}
|
2017-12-22 00:04:36 +00:00
|
|
|
return abilities;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
void SymbolFilePDB::InitializeObject() {
|
|
|
|
|
lldb::addr_t obj_load_address = m_obj_file->GetFileOffset();
|
2018-03-22 03:44:51 +00:00
|
|
|
lldbassert(obj_load_address && obj_load_address != LLDB_INVALID_ADDRESS);
|
2016-09-06 20:57:50 +00:00
|
|
|
m_session_up->setLoadAddress(obj_load_address);
|
2018-01-13 06:58:18 +00:00
|
|
|
if (!m_global_scope_up)
|
|
|
|
|
m_global_scope_up = m_session_up->getGlobalScope();
|
|
|
|
|
lldbassert(m_global_scope_up.get());
|
2016-04-15 00:21:26 +00:00
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
TypeSystem *type_system =
|
|
|
|
|
GetTypeSystemForLanguage(lldb::eLanguageTypeC_plus_plus);
|
|
|
|
|
ClangASTContext *clang_type_system =
|
|
|
|
|
llvm::dyn_cast_or_null<ClangASTContext>(type_system);
|
2018-01-13 06:58:18 +00:00
|
|
|
lldbassert(clang_type_system);
|
2016-09-06 20:57:50 +00:00
|
|
|
m_tu_decl_ctx_up = llvm::make_unique<CompilerDeclContext>(
|
|
|
|
|
type_system, clang_type_system->GetTranslationUnitDecl());
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
uint32_t SymbolFilePDB::GetNumCompileUnits() {
|
|
|
|
|
if (m_cached_compile_unit_count == 0) {
|
2018-01-13 06:58:18 +00:00
|
|
|
auto compilands = m_global_scope_up->findAllChildren<PDBSymbolCompiland>();
|
|
|
|
|
if (!compilands)
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
// The linker could link *.dll (compiland language = LINK), or import
|
2018-04-30 16:49:04 +00:00
|
|
|
// *.dll. For example, a compiland with name `Import:KERNEL32.dll` could be
|
|
|
|
|
// found as a child of the global scope (PDB executable). Usually, such
|
|
|
|
|
// compilands contain `thunk` symbols in which we are not interested for
|
|
|
|
|
// now. However we still count them in the compiland list. If we perform
|
|
|
|
|
// any compiland related activity, like finding symbols through
|
|
|
|
|
// llvm::pdb::IPDBSession methods, such compilands will all be searched
|
|
|
|
|
// automatically no matter whether we include them or not.
|
2016-09-06 20:57:50 +00:00
|
|
|
m_cached_compile_unit_count = compilands->getChildCount();
|
|
|
|
|
|
|
|
|
|
// The linker can inject an additional "dummy" compilation unit into the
|
2017-01-27 21:42:28 +00:00
|
|
|
// PDB. Ignore this special compile unit for our purposes, if it is there.
|
|
|
|
|
// It is always the last one.
|
2018-01-13 06:58:18 +00:00
|
|
|
auto last_compiland_up =
|
|
|
|
|
compilands->getChildAtIndex(m_cached_compile_unit_count - 1);
|
|
|
|
|
lldbassert(last_compiland_up.get());
|
|
|
|
|
std::string name = last_compiland_up->getName();
|
2016-09-06 20:57:50 +00:00
|
|
|
if (name == "* Linker *")
|
|
|
|
|
--m_cached_compile_unit_count;
|
|
|
|
|
}
|
|
|
|
|
return m_cached_compile_unit_count;
|
|
|
|
|
}
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
|
2018-01-13 06:58:18 +00:00
|
|
|
void SymbolFilePDB::GetCompileUnitIndex(
|
2018-03-22 03:44:51 +00:00
|
|
|
const llvm::pdb::PDBSymbolCompiland &pdb_compiland, uint32_t &index) {
|
2018-01-13 06:58:18 +00:00
|
|
|
auto results_up = m_global_scope_up->findAllChildren<PDBSymbolCompiland>();
|
|
|
|
|
if (!results_up)
|
|
|
|
|
return;
|
2018-03-19 21:14:19 +00:00
|
|
|
auto uid = pdb_compiland.getSymIndexId();
|
2018-01-22 06:56:09 +00:00
|
|
|
for (uint32_t cu_idx = 0; cu_idx < GetNumCompileUnits(); ++cu_idx) {
|
2018-01-13 06:58:18 +00:00
|
|
|
auto compiland_up = results_up->getChildAtIndex(cu_idx);
|
|
|
|
|
if (!compiland_up)
|
|
|
|
|
continue;
|
|
|
|
|
if (compiland_up->getSymIndexId() == uid) {
|
|
|
|
|
index = cu_idx;
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
index = UINT32_MAX;
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
std::unique_ptr<llvm::pdb::PDBSymbolCompiland>
|
|
|
|
|
SymbolFilePDB::GetPDBCompilandByUID(uint32_t uid) {
|
|
|
|
|
return m_session_up->getConcreteSymbolById<PDBSymbolCompiland>(uid);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
lldb::CompUnitSP SymbolFilePDB::ParseCompileUnitAtIndex(uint32_t index) {
|
|
|
|
|
if (index >= GetNumCompileUnits())
|
|
|
|
|
return CompUnitSP();
|
2016-09-06 20:57:50 +00:00
|
|
|
|
2018-01-13 06:58:18 +00:00
|
|
|
// Assuming we always retrieve same compilands listed in same order through
|
|
|
|
|
// `PDBSymbolExe::findAllChildren` method, otherwise using `index` to get a
|
|
|
|
|
// compile unit makes no sense.
|
|
|
|
|
auto results = m_global_scope_up->findAllChildren<PDBSymbolCompiland>();
|
|
|
|
|
if (!results)
|
|
|
|
|
return CompUnitSP();
|
|
|
|
|
auto compiland_up = results->getChildAtIndex(index);
|
|
|
|
|
if (!compiland_up)
|
|
|
|
|
return CompUnitSP();
|
|
|
|
|
return ParseCompileUnitForUID(compiland_up->getSymIndexId(), index);
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
lldb::LanguageType
|
2016-09-06 20:57:50 +00:00
|
|
|
SymbolFilePDB::ParseCompileUnitLanguage(const lldb_private::SymbolContext &sc) {
|
|
|
|
|
// What fields should I expect to be filled out on the SymbolContext? Is it
|
|
|
|
|
// safe to assume that `sc.comp_unit` is valid?
|
|
|
|
|
if (!sc.comp_unit)
|
|
|
|
|
return lldb::eLanguageTypeUnknown;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
|
2018-01-13 06:58:18 +00:00
|
|
|
auto compiland_up = GetPDBCompilandByUID(sc.comp_unit->GetID());
|
|
|
|
|
if (!compiland_up)
|
2016-09-06 20:57:50 +00:00
|
|
|
return lldb::eLanguageTypeUnknown;
|
2018-01-13 06:58:18 +00:00
|
|
|
auto details = compiland_up->findOneChild<PDBSymbolCompilandDetails>();
|
2016-09-06 20:57:50 +00:00
|
|
|
if (!details)
|
|
|
|
|
return lldb::eLanguageTypeUnknown;
|
|
|
|
|
return TranslateLanguage(details->getLanguage());
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2018-03-22 03:44:51 +00:00
|
|
|
lldb_private::Function *SymbolFilePDB::ParseCompileUnitFunctionForPDBFunc(
|
|
|
|
|
const PDBSymbolFunc &pdb_func, const lldb_private::SymbolContext &sc) {
|
2018-02-09 05:31:28 +00:00
|
|
|
lldbassert(sc.comp_unit && sc.module_sp.get());
|
|
|
|
|
|
2018-03-19 21:14:19 +00:00
|
|
|
auto file_vm_addr = pdb_func.getVirtualAddress();
|
2018-03-22 19:26:33 +00:00
|
|
|
if (file_vm_addr == LLDB_INVALID_ADDRESS || file_vm_addr == 0)
|
2018-02-09 05:31:28 +00:00
|
|
|
return nullptr;
|
|
|
|
|
|
2018-03-19 21:14:19 +00:00
|
|
|
auto func_length = pdb_func.getLength();
|
2018-03-22 03:44:51 +00:00
|
|
|
AddressRange func_range =
|
|
|
|
|
AddressRange(file_vm_addr, func_length, sc.module_sp->GetSectionList());
|
2018-02-09 05:31:28 +00:00
|
|
|
if (!func_range.GetBaseAddress().IsValid())
|
|
|
|
|
return nullptr;
|
|
|
|
|
|
2018-03-22 03:44:51 +00:00
|
|
|
lldb_private::Type *func_type = ResolveTypeUID(pdb_func.getSymIndexId());
|
2018-02-09 05:31:28 +00:00
|
|
|
if (!func_type)
|
|
|
|
|
return nullptr;
|
|
|
|
|
|
2018-03-19 21:14:19 +00:00
|
|
|
user_id_t func_type_uid = pdb_func.getSignatureId();
|
2018-03-07 03:16:50 +00:00
|
|
|
|
2018-02-09 05:31:28 +00:00
|
|
|
Mangled mangled = GetMangledForPDBFunc(pdb_func);
|
|
|
|
|
|
2018-03-22 03:44:51 +00:00
|
|
|
FunctionSP func_sp =
|
|
|
|
|
std::make_shared<Function>(sc.comp_unit, pdb_func.getSymIndexId(),
|
|
|
|
|
func_type_uid, mangled, func_type, func_range);
|
2018-02-09 05:31:28 +00:00
|
|
|
|
|
|
|
|
sc.comp_unit->AddFunction(func_sp);
|
|
|
|
|
return func_sp.get();
|
|
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
size_t SymbolFilePDB::ParseCompileUnitFunctions(
|
|
|
|
|
const lldb_private::SymbolContext &sc) {
|
2018-02-09 05:31:28 +00:00
|
|
|
lldbassert(sc.comp_unit);
|
|
|
|
|
size_t func_added = 0;
|
|
|
|
|
auto compiland_up = GetPDBCompilandByUID(sc.comp_unit->GetID());
|
|
|
|
|
if (!compiland_up)
|
|
|
|
|
return 0;
|
|
|
|
|
auto results_up = compiland_up->findAllChildren<PDBSymbolFunc>();
|
|
|
|
|
if (!results_up)
|
|
|
|
|
return 0;
|
|
|
|
|
while (auto pdb_func_up = results_up->getNext()) {
|
|
|
|
|
auto func_sp =
|
|
|
|
|
sc.comp_unit->FindFunctionByUID(pdb_func_up->getSymIndexId());
|
|
|
|
|
if (!func_sp) {
|
2018-03-19 21:14:19 +00:00
|
|
|
if (ParseCompileUnitFunctionForPDBFunc(*pdb_func_up, sc))
|
2018-02-09 05:31:28 +00:00
|
|
|
++func_added;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return func_added;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
bool SymbolFilePDB::ParseCompileUnitLineTable(
|
|
|
|
|
const lldb_private::SymbolContext &sc) {
|
2018-01-13 06:58:18 +00:00
|
|
|
lldbassert(sc.comp_unit);
|
|
|
|
|
if (sc.comp_unit->GetLineTable())
|
|
|
|
|
return true;
|
2016-09-06 20:57:50 +00:00
|
|
|
return ParseCompileUnitLineTable(sc, 0);
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
bool SymbolFilePDB::ParseCompileUnitDebugMacros(
|
|
|
|
|
const lldb_private::SymbolContext &sc) {
|
|
|
|
|
// PDB doesn't contain information about macros
|
|
|
|
|
return false;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
bool SymbolFilePDB::ParseCompileUnitSupportFiles(
|
|
|
|
|
const lldb_private::SymbolContext &sc,
|
|
|
|
|
lldb_private::FileSpecList &support_files) {
|
2018-01-13 06:58:18 +00:00
|
|
|
lldbassert(sc.comp_unit);
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
// In theory this is unnecessary work for us, because all of this information
|
2017-01-27 21:42:28 +00:00
|
|
|
// is easily (and quickly) accessible from DebugInfoPDB, so caching it a
|
|
|
|
|
// second time seems like a waste. Unfortunately, there's no good way around
|
|
|
|
|
// this short of a moderate refactor since SymbolVendor depends on being able
|
|
|
|
|
// to cache this list.
|
2018-01-13 06:58:18 +00:00
|
|
|
auto compiland_up = GetPDBCompilandByUID(sc.comp_unit->GetID());
|
|
|
|
|
if (!compiland_up)
|
2016-09-06 20:57:50 +00:00
|
|
|
return false;
|
2018-01-13 06:58:18 +00:00
|
|
|
auto files = m_session_up->getSourceFilesForCompiland(*compiland_up);
|
2016-09-06 20:57:50 +00:00
|
|
|
if (!files || files->getChildCount() == 0)
|
|
|
|
|
return false;
|
|
|
|
|
|
|
|
|
|
while (auto file = files->getNext()) {
|
2018-11-01 21:05:36 +00:00
|
|
|
FileSpec spec(file->getFileName(), FileSpec::Style::windows);
|
2018-01-13 06:58:18 +00:00
|
|
|
support_files.AppendIfUnique(spec);
|
2016-09-06 20:57:50 +00:00
|
|
|
}
|
2018-06-28 10:03:42 +00:00
|
|
|
|
|
|
|
|
// LLDB uses the DWARF-like file numeration (one based),
|
|
|
|
|
// the zeroth file is the compile unit itself
|
|
|
|
|
support_files.Insert(0, *sc.comp_unit);
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
return true;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
bool SymbolFilePDB::ParseImportedModules(
|
|
|
|
|
const lldb_private::SymbolContext &sc,
|
|
|
|
|
std::vector<lldb_private::ConstString> &imported_modules) {
|
|
|
|
|
// PDB does not yet support module debug info
|
|
|
|
|
return false;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2018-03-22 03:44:51 +00:00
|
|
|
static size_t ParseFunctionBlocksForPDBSymbol(
|
|
|
|
|
const lldb_private::SymbolContext &sc, uint64_t func_file_vm_addr,
|
|
|
|
|
const llvm::pdb::PDBSymbol *pdb_symbol, lldb_private::Block *parent_block,
|
|
|
|
|
bool is_top_parent) {
|
2018-02-09 05:31:28 +00:00
|
|
|
assert(pdb_symbol && parent_block);
|
|
|
|
|
|
|
|
|
|
size_t num_added = 0;
|
|
|
|
|
switch (pdb_symbol->getSymTag()) {
|
|
|
|
|
case PDB_SymType::Block:
|
|
|
|
|
case PDB_SymType::Function: {
|
|
|
|
|
Block *block = nullptr;
|
|
|
|
|
auto &raw_sym = pdb_symbol->getRawSymbol();
|
|
|
|
|
if (auto *pdb_func = llvm::dyn_cast<PDBSymbolFunc>(pdb_symbol)) {
|
|
|
|
|
if (pdb_func->hasNoInlineAttribute())
|
|
|
|
|
break;
|
|
|
|
|
if (is_top_parent)
|
|
|
|
|
block = parent_block;
|
|
|
|
|
else
|
|
|
|
|
break;
|
|
|
|
|
} else if (llvm::dyn_cast<PDBSymbolBlock>(pdb_symbol)) {
|
|
|
|
|
auto uid = pdb_symbol->getSymIndexId();
|
|
|
|
|
if (parent_block->FindBlockByID(uid))
|
|
|
|
|
break;
|
|
|
|
|
if (raw_sym.getVirtualAddress() < func_file_vm_addr)
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
auto block_sp = std::make_shared<Block>(pdb_symbol->getSymIndexId());
|
|
|
|
|
parent_block->AddChild(block_sp);
|
|
|
|
|
block = block_sp.get();
|
|
|
|
|
} else
|
|
|
|
|
llvm_unreachable("Unexpected PDB symbol!");
|
|
|
|
|
|
2018-03-22 03:44:51 +00:00
|
|
|
block->AddRange(Block::Range(
|
|
|
|
|
raw_sym.getVirtualAddress() - func_file_vm_addr, raw_sym.getLength()));
|
2018-02-09 05:31:28 +00:00
|
|
|
block->FinalizeRanges();
|
|
|
|
|
++num_added;
|
|
|
|
|
|
|
|
|
|
auto results_up = pdb_symbol->findAllChildren();
|
|
|
|
|
if (!results_up)
|
|
|
|
|
break;
|
|
|
|
|
while (auto symbol_up = results_up->getNext()) {
|
2018-03-22 03:44:51 +00:00
|
|
|
num_added += ParseFunctionBlocksForPDBSymbol(
|
|
|
|
|
sc, func_file_vm_addr, symbol_up.get(), block, false);
|
2018-02-09 05:31:28 +00:00
|
|
|
}
|
|
|
|
|
} break;
|
2018-03-22 03:44:51 +00:00
|
|
|
default:
|
|
|
|
|
break;
|
2018-02-09 05:31:28 +00:00
|
|
|
}
|
|
|
|
|
return num_added;
|
|
|
|
|
}
|
|
|
|
|
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
size_t
|
2016-09-06 20:57:50 +00:00
|
|
|
SymbolFilePDB::ParseFunctionBlocks(const lldb_private::SymbolContext &sc) {
|
2018-02-09 05:31:28 +00:00
|
|
|
lldbassert(sc.comp_unit && sc.function);
|
|
|
|
|
size_t num_added = 0;
|
|
|
|
|
auto uid = sc.function->GetID();
|
|
|
|
|
auto pdb_func_up = m_session_up->getConcreteSymbolById<PDBSymbolFunc>(uid);
|
|
|
|
|
if (!pdb_func_up)
|
|
|
|
|
return 0;
|
|
|
|
|
Block &parent_block = sc.function->GetBlock(false);
|
|
|
|
|
num_added =
|
|
|
|
|
ParseFunctionBlocksForPDBSymbol(sc, pdb_func_up->getVirtualAddress(),
|
|
|
|
|
pdb_func_up.get(), &parent_block, true);
|
|
|
|
|
return num_added;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
size_t SymbolFilePDB::ParseTypes(const lldb_private::SymbolContext &sc) {
|
2018-01-23 20:35:19 +00:00
|
|
|
lldbassert(sc.module_sp.get());
|
2018-03-14 04:05:27 +00:00
|
|
|
if (!sc.comp_unit)
|
2018-01-23 20:35:19 +00:00
|
|
|
return 0;
|
|
|
|
|
|
2018-03-14 04:05:27 +00:00
|
|
|
size_t num_added = 0;
|
|
|
|
|
auto compiland = GetPDBCompilandByUID(sc.comp_unit->GetID());
|
|
|
|
|
if (!compiland)
|
|
|
|
|
return 0;
|
2018-01-23 20:35:19 +00:00
|
|
|
|
2018-03-14 04:05:27 +00:00
|
|
|
auto ParseTypesByTagFn = [&num_added, this](const PDBSymbol &raw_sym) {
|
|
|
|
|
std::unique_ptr<IPDBEnumSymbols> results;
|
2018-03-22 03:44:51 +00:00
|
|
|
PDB_SymType tags_to_search[] = {PDB_SymType::Enum, PDB_SymType::Typedef,
|
|
|
|
|
PDB_SymType::UDT};
|
2018-03-14 04:05:27 +00:00
|
|
|
for (auto tag : tags_to_search) {
|
|
|
|
|
results = raw_sym.findAllChildren(tag);
|
|
|
|
|
if (!results || results->getChildCount() == 0)
|
|
|
|
|
continue;
|
|
|
|
|
while (auto symbol = results->getNext()) {
|
|
|
|
|
switch (symbol->getSymTag()) {
|
|
|
|
|
case PDB_SymType::Enum:
|
|
|
|
|
case PDB_SymType::UDT:
|
|
|
|
|
case PDB_SymType::Typedef:
|
|
|
|
|
break;
|
|
|
|
|
default:
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// This should cause the type to get cached and stored in the `m_types`
|
|
|
|
|
// lookup.
|
[PDB] Parse UDT symbols and pointers to members (combined patch)
Summary:
In this patch I've tried to combine the best ideas from D49368 and D49410,
so it implements following:
- Completion of UDTs from a PDB with a filling of a layout info;
- Pointers to members;
- Fixes the bug relating to a virtual base offset reading from `vbtable`.
The offset was treated as an unsigned, but it can be a negative sometimes.
- Support of MSInheritance attribute
Reviewers: asmith, zturner, rnk, labath, clayborg, lldb-commits
Reviewed By: zturner
Subscribers: aleksandr.urakov, stella.stamenova, JDevlieghere, lldb-commits
Differential Revision: https://reviews.llvm.org/D49980
llvm-svn: 339649
2018-08-14 07:57:44 +00:00
|
|
|
if (auto type = ResolveTypeUID(symbol->getSymIndexId())) {
|
|
|
|
|
// Resolve the type completely to avoid a completion
|
|
|
|
|
// (and so a list change, which causes an iterators invalidation)
|
|
|
|
|
// during a TypeList dumping
|
|
|
|
|
type->GetFullCompilerType();
|
|
|
|
|
++num_added;
|
|
|
|
|
}
|
2018-03-14 04:05:27 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
};
|
2018-01-23 20:35:19 +00:00
|
|
|
|
2018-03-14 04:05:27 +00:00
|
|
|
if (sc.function) {
|
2018-03-22 03:44:51 +00:00
|
|
|
auto pdb_func = m_session_up->getConcreteSymbolById<PDBSymbolFunc>(
|
|
|
|
|
sc.function->GetID());
|
2018-03-14 04:05:27 +00:00
|
|
|
if (!pdb_func)
|
|
|
|
|
return 0;
|
|
|
|
|
ParseTypesByTagFn(*pdb_func);
|
|
|
|
|
} else {
|
|
|
|
|
ParseTypesByTagFn(*compiland);
|
|
|
|
|
|
|
|
|
|
// Also parse global types particularly coming from this compiland.
|
2018-04-30 16:49:04 +00:00
|
|
|
// Unfortunately, PDB has no compiland information for each global type. We
|
|
|
|
|
// have to parse them all. But ensure we only do this once.
|
2018-03-14 04:05:27 +00:00
|
|
|
static bool parse_all_global_types = false;
|
|
|
|
|
if (!parse_all_global_types) {
|
|
|
|
|
ParseTypesByTagFn(*m_global_scope_up);
|
|
|
|
|
parse_all_global_types = true;
|
|
|
|
|
}
|
2018-01-23 20:35:19 +00:00
|
|
|
}
|
|
|
|
|
return num_added;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
size_t
|
|
|
|
|
SymbolFilePDB::ParseVariablesForContext(const lldb_private::SymbolContext &sc) {
|
2018-05-23 01:52:42 +00:00
|
|
|
if (!sc.comp_unit)
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
size_t num_added = 0;
|
|
|
|
|
if (sc.function) {
|
|
|
|
|
auto pdb_func = m_session_up->getConcreteSymbolById<PDBSymbolFunc>(
|
|
|
|
|
sc.function->GetID());
|
|
|
|
|
if (!pdb_func)
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
num_added += ParseVariables(sc, *pdb_func);
|
|
|
|
|
sc.function->GetBlock(false).SetDidParseVariables(true, true);
|
|
|
|
|
} else if (sc.comp_unit) {
|
|
|
|
|
auto compiland = GetPDBCompilandByUID(sc.comp_unit->GetID());
|
|
|
|
|
if (!compiland)
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
if (sc.comp_unit->GetVariableList(false))
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
auto results = m_global_scope_up->findAllChildren<PDBSymbolData>();
|
|
|
|
|
if (results && results->getChildCount()) {
|
|
|
|
|
while (auto result = results->getNext()) {
|
[PDB] Improve performance of the PDB DIA plugin
Summary:
This patch improves performance of `SymbolFilePDB` on huge executables
in two ways:
- cache names of public symbols by address. When creating variables we are
trying to get a mangled name for each one, and in `GetMangledForPDBData`
we are enumerating all public symbols, which takes O(n) for each variable.
With the cache we can retrieve a mangled name in O(log(n));
- cache section contributions. When parsing variables for context we are
enumerating all variables and check if the current one is belonging
to the current compiland. So we are retrieving a compiland ID
for the variable. But in `PDBSymbolData::getCompilandId` for almost every
variable we are enumerating all section contributions to check if the variable
is belonging to it, and get a compiland ID from the section contribution
if so. It takes O(n) for each variable, but with caching it takes about
O(log(n)). I've placed the cache in `SymbolFilePDB` and have created
`GetCompilandId` there. It actually duplicates `PDBSymbolData::getCompilandId`
except for the cache part. Another option is to support caching
in `PDBSymbolData::getCompilandId` and to place cache in `DIASession`, but it
seems that the last one doesn't imply such functionality, because
it's a lightweight wrapper over DIA and whole its state is only a COM pointer
to the DIA session. Moreover, `PDBSymbolData::getCompilandId` is used only
inside of `SymbolFilePDB`, so I think that it's not a bad place to do such
things. With this patch `PDBSymbolData::getCompilandId` is not used at all.
This bottlenecks were found with profiling. I've discovered these on a simple
demo project of Unreal Engine (x86 executable ~72M, PDB ~82M).
This patch doesn't change external behavior of the plugin, so I think that
there's no need for additional testing (already existing tests should warn us
about regress, if any).
Reviewers: zturner, asmith, labath
Reviewed By: asmith
Subscribers: Hui, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D53375
llvm-svn: 345013
2018-10-23 08:29:17 +00:00
|
|
|
auto cu_id = GetCompilandId(*result);
|
2018-05-23 01:52:42 +00:00
|
|
|
// FIXME: We are not able to determine variable's compile unit.
|
|
|
|
|
if (cu_id == 0)
|
|
|
|
|
continue;
|
|
|
|
|
|
|
|
|
|
if (cu_id == sc.comp_unit->GetID())
|
|
|
|
|
num_added += ParseVariables(sc, *result);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// FIXME: A `file static` or `global constant` variable appears both in
|
|
|
|
|
// compiland's children and global scope's children with unexpectedly
|
|
|
|
|
// different symbol's Id making it ambiguous.
|
|
|
|
|
|
|
|
|
|
// FIXME: 'local constant', for example, const char var[] = "abc", declared
|
|
|
|
|
// in a function scope, can't be found in PDB.
|
|
|
|
|
|
|
|
|
|
// Parse variables in this compiland.
|
|
|
|
|
num_added += ParseVariables(sc, *compiland);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return num_added;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
lldb_private::Type *SymbolFilePDB::ResolveTypeUID(lldb::user_id_t type_uid) {
|
|
|
|
|
auto find_result = m_types.find(type_uid);
|
|
|
|
|
if (find_result != m_types.end())
|
|
|
|
|
return find_result->second.get();
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
TypeSystem *type_system =
|
|
|
|
|
GetTypeSystemForLanguage(lldb::eLanguageTypeC_plus_plus);
|
|
|
|
|
ClangASTContext *clang_type_system =
|
|
|
|
|
llvm::dyn_cast_or_null<ClangASTContext>(type_system);
|
|
|
|
|
if (!clang_type_system)
|
|
|
|
|
return nullptr;
|
[PDB] Restore AST from PDB symbols
Summary:
This patch adds an implementation of retrieving of declarations and declaration
contexts based on PDB symbols.
PDB has different type symbols for const-qualified types, and this
implementation ensures that only one declaration was created for both const
and non-const types, but creates different compiler types for them.
The implementation also processes the case when there are two symbols
corresponding to a variable. It's possible e.g. for class static variables,
they has one global symbol and one symbol belonging to a class.
PDB has no info about namespaces, so this implementation parses the full symbol
name and tries to figure out if the symbol belongs to namespace or not,
and then creates nested namespaces if necessary.
Reviewers: asmith, zturner, labath
Reviewed By: asmith
Subscribers: aleksandr.urakov, teemperor, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D51162
llvm-svn: 341782
2018-09-10 08:08:43 +00:00
|
|
|
PDBASTParser *pdb = clang_type_system->GetPDBParser();
|
2016-09-06 20:57:50 +00:00
|
|
|
if (!pdb)
|
|
|
|
|
return nullptr;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
auto pdb_type = m_session_up->getSymbolById(type_uid);
|
|
|
|
|
if (pdb_type == nullptr)
|
|
|
|
|
return nullptr;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
lldb::TypeSP result = pdb->CreateLLDBTypeFromPDBType(*pdb_type);
|
2018-03-22 19:21:34 +00:00
|
|
|
if (result) {
|
2017-12-22 05:26:50 +00:00
|
|
|
m_types.insert(std::make_pair(type_uid, result));
|
2018-01-23 20:35:19 +00:00
|
|
|
auto type_list = GetTypeList();
|
2018-03-07 03:16:50 +00:00
|
|
|
if (type_list)
|
|
|
|
|
type_list->Insert(result);
|
2018-01-23 20:35:19 +00:00
|
|
|
}
|
2016-09-06 20:57:50 +00:00
|
|
|
return result.get();
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
bool SymbolFilePDB::CompleteType(lldb_private::CompilerType &compiler_type) {
|
[PDB] Parse UDT symbols and pointers to members (combined patch)
Summary:
In this patch I've tried to combine the best ideas from D49368 and D49410,
so it implements following:
- Completion of UDTs from a PDB with a filling of a layout info;
- Pointers to members;
- Fixes the bug relating to a virtual base offset reading from `vbtable`.
The offset was treated as an unsigned, but it can be a negative sometimes.
- Support of MSInheritance attribute
Reviewers: asmith, zturner, rnk, labath, clayborg, lldb-commits
Reviewed By: zturner
Subscribers: aleksandr.urakov, stella.stamenova, JDevlieghere, lldb-commits
Differential Revision: https://reviews.llvm.org/D49980
llvm-svn: 339649
2018-08-14 07:57:44 +00:00
|
|
|
std::lock_guard<std::recursive_mutex> guard(
|
|
|
|
|
GetObjectFile()->GetModule()->GetMutex());
|
|
|
|
|
|
|
|
|
|
ClangASTContext *clang_ast_ctx = llvm::dyn_cast_or_null<ClangASTContext>(
|
|
|
|
|
GetTypeSystemForLanguage(lldb::eLanguageTypeC_plus_plus));
|
|
|
|
|
if (!clang_ast_ctx)
|
|
|
|
|
return false;
|
|
|
|
|
|
[PDB] Restore AST from PDB symbols
Summary:
This patch adds an implementation of retrieving of declarations and declaration
contexts based on PDB symbols.
PDB has different type symbols for const-qualified types, and this
implementation ensures that only one declaration was created for both const
and non-const types, but creates different compiler types for them.
The implementation also processes the case when there are two symbols
corresponding to a variable. It's possible e.g. for class static variables,
they has one global symbol and one symbol belonging to a class.
PDB has no info about namespaces, so this implementation parses the full symbol
name and tries to figure out if the symbol belongs to namespace or not,
and then creates nested namespaces if necessary.
Reviewers: asmith, zturner, labath
Reviewed By: asmith
Subscribers: aleksandr.urakov, teemperor, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D51162
llvm-svn: 341782
2018-09-10 08:08:43 +00:00
|
|
|
PDBASTParser *pdb = clang_ast_ctx->GetPDBParser();
|
[PDB] Parse UDT symbols and pointers to members (combined patch)
Summary:
In this patch I've tried to combine the best ideas from D49368 and D49410,
so it implements following:
- Completion of UDTs from a PDB with a filling of a layout info;
- Pointers to members;
- Fixes the bug relating to a virtual base offset reading from `vbtable`.
The offset was treated as an unsigned, but it can be a negative sometimes.
- Support of MSInheritance attribute
Reviewers: asmith, zturner, rnk, labath, clayborg, lldb-commits
Reviewed By: zturner
Subscribers: aleksandr.urakov, stella.stamenova, JDevlieghere, lldb-commits
Differential Revision: https://reviews.llvm.org/D49980
llvm-svn: 339649
2018-08-14 07:57:44 +00:00
|
|
|
if (!pdb)
|
|
|
|
|
return false;
|
|
|
|
|
|
|
|
|
|
return pdb->CompleteTypeFromPDB(compiler_type);
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
lldb_private::CompilerDecl SymbolFilePDB::GetDeclForUID(lldb::user_id_t uid) {
|
[PDB] Restore AST from PDB symbols
Summary:
This patch adds an implementation of retrieving of declarations and declaration
contexts based on PDB symbols.
PDB has different type symbols for const-qualified types, and this
implementation ensures that only one declaration was created for both const
and non-const types, but creates different compiler types for them.
The implementation also processes the case when there are two symbols
corresponding to a variable. It's possible e.g. for class static variables,
they has one global symbol and one symbol belonging to a class.
PDB has no info about namespaces, so this implementation parses the full symbol
name and tries to figure out if the symbol belongs to namespace or not,
and then creates nested namespaces if necessary.
Reviewers: asmith, zturner, labath
Reviewed By: asmith
Subscribers: aleksandr.urakov, teemperor, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D51162
llvm-svn: 341782
2018-09-10 08:08:43 +00:00
|
|
|
ClangASTContext *clang_ast_ctx = llvm::dyn_cast_or_null<ClangASTContext>(
|
|
|
|
|
GetTypeSystemForLanguage(lldb::eLanguageTypeC_plus_plus));
|
|
|
|
|
if (!clang_ast_ctx)
|
|
|
|
|
return CompilerDecl();
|
|
|
|
|
|
|
|
|
|
PDBASTParser *pdb = clang_ast_ctx->GetPDBParser();
|
|
|
|
|
if (!pdb)
|
|
|
|
|
return CompilerDecl();
|
|
|
|
|
|
|
|
|
|
auto symbol = m_session_up->getSymbolById(uid);
|
|
|
|
|
if (!symbol)
|
|
|
|
|
return CompilerDecl();
|
|
|
|
|
|
|
|
|
|
auto decl = pdb->GetDeclForSymbol(*symbol);
|
|
|
|
|
if (!decl)
|
|
|
|
|
return CompilerDecl();
|
|
|
|
|
|
|
|
|
|
return CompilerDecl(clang_ast_ctx, decl);
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
lldb_private::CompilerDeclContext
|
|
|
|
|
SymbolFilePDB::GetDeclContextForUID(lldb::user_id_t uid) {
|
[PDB] Restore AST from PDB symbols
Summary:
This patch adds an implementation of retrieving of declarations and declaration
contexts based on PDB symbols.
PDB has different type symbols for const-qualified types, and this
implementation ensures that only one declaration was created for both const
and non-const types, but creates different compiler types for them.
The implementation also processes the case when there are two symbols
corresponding to a variable. It's possible e.g. for class static variables,
they has one global symbol and one symbol belonging to a class.
PDB has no info about namespaces, so this implementation parses the full symbol
name and tries to figure out if the symbol belongs to namespace or not,
and then creates nested namespaces if necessary.
Reviewers: asmith, zturner, labath
Reviewed By: asmith
Subscribers: aleksandr.urakov, teemperor, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D51162
llvm-svn: 341782
2018-09-10 08:08:43 +00:00
|
|
|
ClangASTContext *clang_ast_ctx = llvm::dyn_cast_or_null<ClangASTContext>(
|
|
|
|
|
GetTypeSystemForLanguage(lldb::eLanguageTypeC_plus_plus));
|
|
|
|
|
if (!clang_ast_ctx)
|
|
|
|
|
return CompilerDeclContext();
|
|
|
|
|
|
|
|
|
|
PDBASTParser *pdb = clang_ast_ctx->GetPDBParser();
|
|
|
|
|
if (!pdb)
|
|
|
|
|
return CompilerDeclContext();
|
|
|
|
|
|
|
|
|
|
auto symbol = m_session_up->getSymbolById(uid);
|
|
|
|
|
if (!symbol)
|
|
|
|
|
return CompilerDeclContext();
|
|
|
|
|
|
|
|
|
|
auto decl_context = pdb->GetDeclContextForSymbol(*symbol);
|
|
|
|
|
if (!decl_context)
|
|
|
|
|
return GetDeclContextContainingUID(uid);
|
|
|
|
|
|
|
|
|
|
return CompilerDeclContext(clang_ast_ctx, decl_context);
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
lldb_private::CompilerDeclContext
|
|
|
|
|
SymbolFilePDB::GetDeclContextContainingUID(lldb::user_id_t uid) {
|
[PDB] Restore AST from PDB symbols
Summary:
This patch adds an implementation of retrieving of declarations and declaration
contexts based on PDB symbols.
PDB has different type symbols for const-qualified types, and this
implementation ensures that only one declaration was created for both const
and non-const types, but creates different compiler types for them.
The implementation also processes the case when there are two symbols
corresponding to a variable. It's possible e.g. for class static variables,
they has one global symbol and one symbol belonging to a class.
PDB has no info about namespaces, so this implementation parses the full symbol
name and tries to figure out if the symbol belongs to namespace or not,
and then creates nested namespaces if necessary.
Reviewers: asmith, zturner, labath
Reviewed By: asmith
Subscribers: aleksandr.urakov, teemperor, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D51162
llvm-svn: 341782
2018-09-10 08:08:43 +00:00
|
|
|
ClangASTContext *clang_ast_ctx = llvm::dyn_cast_or_null<ClangASTContext>(
|
|
|
|
|
GetTypeSystemForLanguage(lldb::eLanguageTypeC_plus_plus));
|
|
|
|
|
if (!clang_ast_ctx)
|
|
|
|
|
return CompilerDeclContext();
|
|
|
|
|
|
|
|
|
|
PDBASTParser *pdb = clang_ast_ctx->GetPDBParser();
|
|
|
|
|
if (!pdb)
|
|
|
|
|
return CompilerDeclContext();
|
|
|
|
|
|
|
|
|
|
auto symbol = m_session_up->getSymbolById(uid);
|
|
|
|
|
if (!symbol)
|
|
|
|
|
return CompilerDeclContext();
|
|
|
|
|
|
|
|
|
|
auto decl_context = pdb->GetDeclContextContainingSymbol(*symbol);
|
|
|
|
|
assert(decl_context);
|
|
|
|
|
|
|
|
|
|
return CompilerDeclContext(clang_ast_ctx, decl_context);
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
void SymbolFilePDB::ParseDeclsForContext(
|
[PDB] Restore AST from PDB symbols
Summary:
This patch adds an implementation of retrieving of declarations and declaration
contexts based on PDB symbols.
PDB has different type symbols for const-qualified types, and this
implementation ensures that only one declaration was created for both const
and non-const types, but creates different compiler types for them.
The implementation also processes the case when there are two symbols
corresponding to a variable. It's possible e.g. for class static variables,
they has one global symbol and one symbol belonging to a class.
PDB has no info about namespaces, so this implementation parses the full symbol
name and tries to figure out if the symbol belongs to namespace or not,
and then creates nested namespaces if necessary.
Reviewers: asmith, zturner, labath
Reviewed By: asmith
Subscribers: aleksandr.urakov, teemperor, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D51162
llvm-svn: 341782
2018-09-10 08:08:43 +00:00
|
|
|
lldb_private::CompilerDeclContext decl_ctx) {
|
|
|
|
|
ClangASTContext *clang_ast_ctx = llvm::dyn_cast_or_null<ClangASTContext>(
|
|
|
|
|
GetTypeSystemForLanguage(lldb::eLanguageTypeC_plus_plus));
|
|
|
|
|
if (!clang_ast_ctx)
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
PDBASTParser *pdb = clang_ast_ctx->GetPDBParser();
|
|
|
|
|
if (!pdb)
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
pdb->ParseDeclsForDeclContext(
|
|
|
|
|
static_cast<clang::DeclContext *>(decl_ctx.GetOpaqueDeclContext()));
|
|
|
|
|
}
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
|
|
|
|
|
uint32_t
|
2016-09-06 20:57:50 +00:00
|
|
|
SymbolFilePDB::ResolveSymbolContext(const lldb_private::Address &so_addr,
|
2018-10-25 20:45:19 +00:00
|
|
|
SymbolContextItem resolve_scope,
|
2016-09-06 20:57:50 +00:00
|
|
|
lldb_private::SymbolContext &sc) {
|
2018-02-09 05:31:28 +00:00
|
|
|
uint32_t resolved_flags = 0;
|
2018-02-09 11:37:01 +00:00
|
|
|
if (resolve_scope & eSymbolContextCompUnit ||
|
|
|
|
|
resolve_scope & eSymbolContextVariable ||
|
|
|
|
|
resolve_scope & eSymbolContextFunction ||
|
|
|
|
|
resolve_scope & eSymbolContextBlock ||
|
2018-02-09 05:31:28 +00:00
|
|
|
resolve_scope & eSymbolContextLineEntry) {
|
|
|
|
|
auto cu_sp = GetCompileUnitContainsAddress(so_addr);
|
|
|
|
|
if (!cu_sp) {
|
|
|
|
|
if (resolved_flags | eSymbolContextVariable) {
|
|
|
|
|
// TODO: Resolve variables
|
|
|
|
|
}
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
sc.comp_unit = cu_sp.get();
|
|
|
|
|
resolved_flags |= eSymbolContextCompUnit;
|
|
|
|
|
lldbassert(sc.module_sp == cu_sp->GetModule());
|
2018-06-28 10:03:42 +00:00
|
|
|
}
|
2018-02-09 05:31:28 +00:00
|
|
|
|
2018-08-29 07:26:11 +00:00
|
|
|
if (resolve_scope & eSymbolContextFunction ||
|
|
|
|
|
resolve_scope & eSymbolContextBlock) {
|
2018-06-28 10:03:42 +00:00
|
|
|
addr_t file_vm_addr = so_addr.GetFileAddress();
|
|
|
|
|
auto symbol_up =
|
|
|
|
|
m_session_up->findSymbolByAddress(file_vm_addr, PDB_SymType::Function);
|
|
|
|
|
if (symbol_up) {
|
|
|
|
|
auto *pdb_func = llvm::dyn_cast<PDBSymbolFunc>(symbol_up.get());
|
|
|
|
|
assert(pdb_func);
|
|
|
|
|
auto func_uid = pdb_func->getSymIndexId();
|
|
|
|
|
sc.function = sc.comp_unit->FindFunctionByUID(func_uid).get();
|
|
|
|
|
if (sc.function == nullptr)
|
|
|
|
|
sc.function = ParseCompileUnitFunctionForPDBFunc(*pdb_func, sc);
|
|
|
|
|
if (sc.function) {
|
|
|
|
|
resolved_flags |= eSymbolContextFunction;
|
|
|
|
|
if (resolve_scope & eSymbolContextBlock) {
|
2018-08-29 07:26:11 +00:00
|
|
|
auto block_symbol = m_session_up->findSymbolByAddress(
|
|
|
|
|
file_vm_addr, PDB_SymType::Block);
|
|
|
|
|
auto block_id = block_symbol ? block_symbol->getSymIndexId()
|
|
|
|
|
: sc.function->GetID();
|
|
|
|
|
sc.block = sc.function->GetBlock(true).FindBlockByID(block_id);
|
2018-06-28 10:03:42 +00:00
|
|
|
if (sc.block)
|
|
|
|
|
resolved_flags |= eSymbolContextBlock;
|
2018-02-09 05:31:28 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2018-06-28 10:03:42 +00:00
|
|
|
}
|
2018-02-09 05:31:28 +00:00
|
|
|
|
2018-06-28 10:03:42 +00:00
|
|
|
if (resolve_scope & eSymbolContextLineEntry) {
|
|
|
|
|
if (auto *line_table = sc.comp_unit->GetLineTable()) {
|
|
|
|
|
Address addr(so_addr);
|
|
|
|
|
if (line_table->FindLineEntryByAddress(addr, sc.line_entry))
|
|
|
|
|
resolved_flags |= eSymbolContextLineEntry;
|
2018-02-09 05:31:28 +00:00
|
|
|
}
|
|
|
|
|
}
|
2018-06-28 10:03:42 +00:00
|
|
|
|
2018-02-09 05:31:28 +00:00
|
|
|
return resolved_flags;
|
2016-09-06 20:57:50 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
uint32_t SymbolFilePDB::ResolveSymbolContext(
|
|
|
|
|
const lldb_private::FileSpec &file_spec, uint32_t line, bool check_inlines,
|
2018-10-25 20:45:19 +00:00
|
|
|
SymbolContextItem resolve_scope, lldb_private::SymbolContextList &sc_list) {
|
2018-01-13 06:58:18 +00:00
|
|
|
const size_t old_size = sc_list.GetSize();
|
2016-09-06 20:57:50 +00:00
|
|
|
if (resolve_scope & lldb::eSymbolContextCompUnit) {
|
|
|
|
|
// Locate all compilation units with line numbers referencing the specified
|
2017-01-27 21:42:28 +00:00
|
|
|
// file. For example, if `file_spec` is <vector>, then this should return
|
|
|
|
|
// all source files and header files that reference <vector>, either
|
|
|
|
|
// directly or indirectly.
|
2016-09-06 20:57:50 +00:00
|
|
|
auto compilands = m_session_up->findCompilandsForSourceFile(
|
|
|
|
|
file_spec.GetPath(), PDB_NameSearchFlags::NS_CaseInsensitive);
|
|
|
|
|
|
2018-01-13 06:58:18 +00:00
|
|
|
if (!compilands)
|
|
|
|
|
return 0;
|
|
|
|
|
|
2017-01-27 21:42:28 +00:00
|
|
|
// For each one, either find its previously parsed data or parse it afresh
|
|
|
|
|
// and add it to the symbol context list.
|
2016-09-06 20:57:50 +00:00
|
|
|
while (auto compiland = compilands->getNext()) {
|
2018-04-30 16:49:04 +00:00
|
|
|
// If we're not checking inlines, then don't add line information for
|
|
|
|
|
// this file unless the FileSpec matches. For inline functions, we don't
|
|
|
|
|
// have to match the FileSpec since they could be defined in headers
|
|
|
|
|
// other than file specified in FileSpec.
|
2016-09-06 20:57:50 +00:00
|
|
|
if (!check_inlines) {
|
2018-03-20 00:18:22 +00:00
|
|
|
std::string source_file = compiland->getSourceFileFullPath();
|
2018-01-13 06:58:18 +00:00
|
|
|
if (source_file.empty())
|
|
|
|
|
continue;
|
2018-11-01 21:05:36 +00:00
|
|
|
FileSpec this_spec(source_file, FileSpec::Style::windows);
|
2018-01-13 06:58:18 +00:00
|
|
|
bool need_full_match = !file_spec.GetDirectory().IsEmpty();
|
|
|
|
|
if (FileSpec::Compare(file_spec, this_spec, need_full_match) != 0)
|
2016-09-06 20:57:50 +00:00
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
SymbolContext sc;
|
2018-01-13 06:58:18 +00:00
|
|
|
auto cu = ParseCompileUnitForUID(compiland->getSymIndexId());
|
2018-03-22 19:21:34 +00:00
|
|
|
if (!cu)
|
2018-01-13 06:58:18 +00:00
|
|
|
continue;
|
2016-09-06 20:57:50 +00:00
|
|
|
sc.comp_unit = cu.get();
|
|
|
|
|
sc.module_sp = cu->GetModule();
|
|
|
|
|
|
|
|
|
|
// If we were asked to resolve line entries, add all entries to the line
|
2017-01-27 21:42:28 +00:00
|
|
|
// table that match the requested line (or all lines if `line` == 0).
|
2018-02-09 05:31:28 +00:00
|
|
|
if (resolve_scope & (eSymbolContextFunction | eSymbolContextBlock |
|
|
|
|
|
eSymbolContextLineEntry)) {
|
|
|
|
|
bool has_line_table = ParseCompileUnitLineTable(sc, line);
|
|
|
|
|
|
|
|
|
|
if ((resolve_scope & eSymbolContextLineEntry) && !has_line_table) {
|
|
|
|
|
// The query asks for line entries, but we can't get them for the
|
2018-04-30 16:49:04 +00:00
|
|
|
// compile unit. This is not normal for `line` = 0. So just assert
|
|
|
|
|
// it.
|
2018-03-07 03:16:50 +00:00
|
|
|
assert(line && "Couldn't get all line entries!\n");
|
2018-02-09 05:31:28 +00:00
|
|
|
|
|
|
|
|
// Current compiland does not have the requested line. Search next.
|
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (resolve_scope & (eSymbolContextFunction | eSymbolContextBlock)) {
|
|
|
|
|
if (!has_line_table)
|
|
|
|
|
continue;
|
|
|
|
|
|
|
|
|
|
auto *line_table = sc.comp_unit->GetLineTable();
|
|
|
|
|
lldbassert(line_table);
|
|
|
|
|
|
|
|
|
|
uint32_t num_line_entries = line_table->GetSize();
|
|
|
|
|
// Skip the terminal line entry.
|
|
|
|
|
--num_line_entries;
|
|
|
|
|
|
2018-04-30 16:49:04 +00:00
|
|
|
// If `line `!= 0, see if we can resolve function for each line entry
|
|
|
|
|
// in the line table.
|
2018-02-09 05:31:28 +00:00
|
|
|
for (uint32_t line_idx = 0; line && line_idx < num_line_entries;
|
|
|
|
|
++line_idx) {
|
|
|
|
|
if (!line_table->GetLineEntryAtIndex(line_idx, sc.line_entry))
|
|
|
|
|
continue;
|
|
|
|
|
|
|
|
|
|
auto file_vm_addr =
|
|
|
|
|
sc.line_entry.range.GetBaseAddress().GetFileAddress();
|
2018-03-22 19:26:33 +00:00
|
|
|
if (file_vm_addr == LLDB_INVALID_ADDRESS || file_vm_addr == 0)
|
2018-02-09 05:31:28 +00:00
|
|
|
continue;
|
|
|
|
|
|
2018-03-22 03:44:51 +00:00
|
|
|
auto symbol_up = m_session_up->findSymbolByAddress(
|
|
|
|
|
file_vm_addr, PDB_SymType::Function);
|
2018-02-09 05:31:28 +00:00
|
|
|
if (symbol_up) {
|
|
|
|
|
auto func_uid = symbol_up->getSymIndexId();
|
|
|
|
|
sc.function = sc.comp_unit->FindFunctionByUID(func_uid).get();
|
|
|
|
|
if (sc.function == nullptr) {
|
|
|
|
|
auto pdb_func = llvm::dyn_cast<PDBSymbolFunc>(symbol_up.get());
|
|
|
|
|
assert(pdb_func);
|
2018-03-19 21:14:19 +00:00
|
|
|
sc.function = ParseCompileUnitFunctionForPDBFunc(*pdb_func, sc);
|
2018-02-09 05:31:28 +00:00
|
|
|
}
|
|
|
|
|
if (sc.function && (resolve_scope & eSymbolContextBlock)) {
|
|
|
|
|
Block &block = sc.function->GetBlock(true);
|
|
|
|
|
sc.block = block.FindBlockByID(sc.function->GetID());
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
sc_list.Append(sc);
|
|
|
|
|
}
|
|
|
|
|
} else if (has_line_table) {
|
|
|
|
|
// We can parse line table for the compile unit. But no query to
|
|
|
|
|
// resolve function or block. We append `sc` to the list anyway.
|
|
|
|
|
sc_list.Append(sc);
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
// No query for line entry, function or block. But we have a valid
|
|
|
|
|
// compile unit, append `sc` to the list.
|
|
|
|
|
sc_list.Append(sc);
|
|
|
|
|
}
|
2016-04-15 00:21:26 +00:00
|
|
|
}
|
2016-09-06 20:57:50 +00:00
|
|
|
}
|
2018-01-13 06:58:18 +00:00
|
|
|
return sc_list.GetSize() - old_size;
|
2016-04-15 00:21:26 +00:00
|
|
|
}
|
|
|
|
|
|
2018-05-23 01:52:42 +00:00
|
|
|
std::string SymbolFilePDB::GetMangledForPDBData(const PDBSymbolData &pdb_data) {
|
[PDB] Improve performance of the PDB DIA plugin
Summary:
This patch improves performance of `SymbolFilePDB` on huge executables
in two ways:
- cache names of public symbols by address. When creating variables we are
trying to get a mangled name for each one, and in `GetMangledForPDBData`
we are enumerating all public symbols, which takes O(n) for each variable.
With the cache we can retrieve a mangled name in O(log(n));
- cache section contributions. When parsing variables for context we are
enumerating all variables and check if the current one is belonging
to the current compiland. So we are retrieving a compiland ID
for the variable. But in `PDBSymbolData::getCompilandId` for almost every
variable we are enumerating all section contributions to check if the variable
is belonging to it, and get a compiland ID from the section contribution
if so. It takes O(n) for each variable, but with caching it takes about
O(log(n)). I've placed the cache in `SymbolFilePDB` and have created
`GetCompilandId` there. It actually duplicates `PDBSymbolData::getCompilandId`
except for the cache part. Another option is to support caching
in `PDBSymbolData::getCompilandId` and to place cache in `DIASession`, but it
seems that the last one doesn't imply such functionality, because
it's a lightweight wrapper over DIA and whole its state is only a COM pointer
to the DIA session. Moreover, `PDBSymbolData::getCompilandId` is used only
inside of `SymbolFilePDB`, so I think that it's not a bad place to do such
things. With this patch `PDBSymbolData::getCompilandId` is not used at all.
This bottlenecks were found with profiling. I've discovered these on a simple
demo project of Unreal Engine (x86 executable ~72M, PDB ~82M).
This patch doesn't change external behavior of the plugin, so I think that
there's no need for additional testing (already existing tests should warn us
about regress, if any).
Reviewers: zturner, asmith, labath
Reviewed By: asmith
Subscribers: Hui, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D53375
llvm-svn: 345013
2018-10-23 08:29:17 +00:00
|
|
|
// Cache public names at first
|
|
|
|
|
if (m_public_names.empty())
|
|
|
|
|
if (auto result_up =
|
|
|
|
|
m_global_scope_up->findAllChildren(PDB_SymType::PublicSymbol))
|
|
|
|
|
while (auto symbol_up = result_up->getNext())
|
|
|
|
|
if (auto addr = symbol_up->getRawSymbol().getVirtualAddress())
|
|
|
|
|
m_public_names[addr] = symbol_up->getRawSymbol().getName();
|
|
|
|
|
|
|
|
|
|
// Look up the name in the cache
|
|
|
|
|
return m_public_names.lookup(pdb_data.getVirtualAddress());
|
2018-05-23 01:52:42 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
VariableSP SymbolFilePDB::ParseVariableForPDBData(
|
|
|
|
|
const lldb_private::SymbolContext &sc,
|
|
|
|
|
const llvm::pdb::PDBSymbolData &pdb_data) {
|
|
|
|
|
VariableSP var_sp;
|
|
|
|
|
uint32_t var_uid = pdb_data.getSymIndexId();
|
|
|
|
|
auto result = m_variables.find(var_uid);
|
|
|
|
|
if (result != m_variables.end())
|
|
|
|
|
return result->second;
|
|
|
|
|
|
|
|
|
|
ValueType scope = eValueTypeInvalid;
|
|
|
|
|
bool is_static_member = false;
|
|
|
|
|
bool is_external = false;
|
|
|
|
|
bool is_artificial = false;
|
|
|
|
|
|
|
|
|
|
switch (pdb_data.getDataKind()) {
|
|
|
|
|
case PDB_DataKind::Global:
|
|
|
|
|
scope = eValueTypeVariableGlobal;
|
|
|
|
|
is_external = true;
|
|
|
|
|
break;
|
|
|
|
|
case PDB_DataKind::Local:
|
|
|
|
|
scope = eValueTypeVariableLocal;
|
|
|
|
|
break;
|
|
|
|
|
case PDB_DataKind::FileStatic:
|
|
|
|
|
scope = eValueTypeVariableStatic;
|
|
|
|
|
break;
|
|
|
|
|
case PDB_DataKind::StaticMember:
|
|
|
|
|
is_static_member = true;
|
|
|
|
|
scope = eValueTypeVariableStatic;
|
|
|
|
|
break;
|
|
|
|
|
case PDB_DataKind::Member:
|
|
|
|
|
scope = eValueTypeVariableStatic;
|
|
|
|
|
break;
|
|
|
|
|
case PDB_DataKind::Param:
|
|
|
|
|
scope = eValueTypeVariableArgument;
|
|
|
|
|
break;
|
|
|
|
|
case PDB_DataKind::Constant:
|
|
|
|
|
scope = eValueTypeConstResult;
|
|
|
|
|
break;
|
|
|
|
|
default:
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
switch (pdb_data.getLocationType()) {
|
|
|
|
|
case PDB_LocType::TLS:
|
|
|
|
|
scope = eValueTypeVariableThreadLocal;
|
|
|
|
|
break;
|
|
|
|
|
case PDB_LocType::RegRel: {
|
|
|
|
|
// It is a `this` pointer.
|
|
|
|
|
if (pdb_data.getDataKind() == PDB_DataKind::ObjectPtr) {
|
|
|
|
|
scope = eValueTypeVariableArgument;
|
|
|
|
|
is_artificial = true;
|
|
|
|
|
}
|
|
|
|
|
} break;
|
|
|
|
|
default:
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
Declaration decl;
|
|
|
|
|
if (!is_artificial && !pdb_data.isCompilerGenerated()) {
|
|
|
|
|
if (auto lines = pdb_data.getLineNumbers()) {
|
|
|
|
|
if (auto first_line = lines->getNext()) {
|
|
|
|
|
uint32_t src_file_id = first_line->getSourceFileId();
|
|
|
|
|
auto src_file = m_session_up->getSourceFileById(src_file_id);
|
|
|
|
|
if (src_file) {
|
2018-11-01 21:05:36 +00:00
|
|
|
FileSpec spec(src_file->getFileName());
|
2018-05-23 01:52:42 +00:00
|
|
|
decl.SetFile(spec);
|
|
|
|
|
decl.SetColumn(first_line->getColumnNumber());
|
|
|
|
|
decl.SetLine(first_line->getLineNumber());
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
Variable::RangeList ranges;
|
|
|
|
|
SymbolContextScope *context_scope = sc.comp_unit;
|
|
|
|
|
if (scope == eValueTypeVariableLocal) {
|
|
|
|
|
if (sc.function) {
|
|
|
|
|
context_scope = sc.function->GetBlock(true).FindBlockByID(
|
[PDB] Restore AST from PDB symbols
Summary:
This patch adds an implementation of retrieving of declarations and declaration
contexts based on PDB symbols.
PDB has different type symbols for const-qualified types, and this
implementation ensures that only one declaration was created for both const
and non-const types, but creates different compiler types for them.
The implementation also processes the case when there are two symbols
corresponding to a variable. It's possible e.g. for class static variables,
they has one global symbol and one symbol belonging to a class.
PDB has no info about namespaces, so this implementation parses the full symbol
name and tries to figure out if the symbol belongs to namespace or not,
and then creates nested namespaces if necessary.
Reviewers: asmith, zturner, labath
Reviewed By: asmith
Subscribers: aleksandr.urakov, teemperor, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D51162
llvm-svn: 341782
2018-09-10 08:08:43 +00:00
|
|
|
pdb_data.getLexicalParentId());
|
2018-05-23 01:52:42 +00:00
|
|
|
if (context_scope == nullptr)
|
|
|
|
|
context_scope = sc.function;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
SymbolFileTypeSP type_sp =
|
|
|
|
|
std::make_shared<SymbolFileType>(*this, pdb_data.getTypeId());
|
|
|
|
|
|
|
|
|
|
auto var_name = pdb_data.getName();
|
|
|
|
|
auto mangled = GetMangledForPDBData(pdb_data);
|
|
|
|
|
auto mangled_cstr = mangled.empty() ? nullptr : mangled.c_str();
|
|
|
|
|
|
2018-07-13 10:29:27 +00:00
|
|
|
bool is_constant;
|
|
|
|
|
DWARFExpression location = ConvertPDBLocationToDWARFExpression(
|
|
|
|
|
GetObjectFile()->GetModule(), pdb_data, is_constant);
|
2018-05-23 01:52:42 +00:00
|
|
|
|
|
|
|
|
var_sp = std::make_shared<Variable>(
|
|
|
|
|
var_uid, var_name.c_str(), mangled_cstr, type_sp, scope, context_scope,
|
|
|
|
|
ranges, &decl, location, is_external, is_artificial, is_static_member);
|
2018-07-13 10:29:27 +00:00
|
|
|
var_sp->SetLocationIsConstantValueData(is_constant);
|
2018-05-23 01:52:42 +00:00
|
|
|
|
|
|
|
|
m_variables.insert(std::make_pair(var_uid, var_sp));
|
|
|
|
|
return var_sp;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
size_t
|
|
|
|
|
SymbolFilePDB::ParseVariables(const lldb_private::SymbolContext &sc,
|
|
|
|
|
const llvm::pdb::PDBSymbol &pdb_symbol,
|
|
|
|
|
lldb_private::VariableList *variable_list) {
|
|
|
|
|
size_t num_added = 0;
|
|
|
|
|
|
|
|
|
|
if (auto pdb_data = llvm::dyn_cast<PDBSymbolData>(&pdb_symbol)) {
|
|
|
|
|
VariableListSP local_variable_list_sp;
|
|
|
|
|
|
|
|
|
|
auto result = m_variables.find(pdb_data->getSymIndexId());
|
|
|
|
|
if (result != m_variables.end()) {
|
|
|
|
|
if (variable_list)
|
|
|
|
|
variable_list->AddVariableIfUnique(result->second);
|
|
|
|
|
} else {
|
|
|
|
|
// Prepare right VariableList for this variable.
|
|
|
|
|
if (auto lexical_parent = pdb_data->getLexicalParent()) {
|
|
|
|
|
switch (lexical_parent->getSymTag()) {
|
|
|
|
|
case PDB_SymType::Exe:
|
|
|
|
|
assert(sc.comp_unit);
|
|
|
|
|
LLVM_FALLTHROUGH;
|
|
|
|
|
case PDB_SymType::Compiland: {
|
|
|
|
|
if (sc.comp_unit) {
|
|
|
|
|
local_variable_list_sp = sc.comp_unit->GetVariableList(false);
|
|
|
|
|
if (!local_variable_list_sp) {
|
|
|
|
|
local_variable_list_sp = std::make_shared<VariableList>();
|
|
|
|
|
sc.comp_unit->SetVariableList(local_variable_list_sp);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
} break;
|
|
|
|
|
case PDB_SymType::Block:
|
|
|
|
|
case PDB_SymType::Function: {
|
|
|
|
|
if (sc.function) {
|
|
|
|
|
Block *block = sc.function->GetBlock(true).FindBlockByID(
|
|
|
|
|
lexical_parent->getSymIndexId());
|
|
|
|
|
if (block) {
|
|
|
|
|
local_variable_list_sp = block->GetBlockVariableList(false);
|
|
|
|
|
if (!local_variable_list_sp) {
|
|
|
|
|
local_variable_list_sp = std::make_shared<VariableList>();
|
|
|
|
|
block->SetVariableList(local_variable_list_sp);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
} break;
|
|
|
|
|
default:
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (local_variable_list_sp) {
|
|
|
|
|
if (auto var_sp = ParseVariableForPDBData(sc, *pdb_data)) {
|
|
|
|
|
local_variable_list_sp->AddVariableIfUnique(var_sp);
|
|
|
|
|
if (variable_list)
|
|
|
|
|
variable_list->AddVariableIfUnique(var_sp);
|
|
|
|
|
++num_added;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (auto results = pdb_symbol.findAllChildren()) {
|
|
|
|
|
while (auto result = results->getNext())
|
|
|
|
|
num_added += ParseVariables(sc, *result, variable_list);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return num_added;
|
|
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
uint32_t SymbolFilePDB::FindGlobalVariables(
|
|
|
|
|
const lldb_private::ConstString &name,
|
2018-05-31 09:46:26 +00:00
|
|
|
const lldb_private::CompilerDeclContext *parent_decl_ctx,
|
2016-09-06 20:57:50 +00:00
|
|
|
uint32_t max_matches, lldb_private::VariableList &variables) {
|
[PDB] Restore AST from PDB symbols
Summary:
This patch adds an implementation of retrieving of declarations and declaration
contexts based on PDB symbols.
PDB has different type symbols for const-qualified types, and this
implementation ensures that only one declaration was created for both const
and non-const types, but creates different compiler types for them.
The implementation also processes the case when there are two symbols
corresponding to a variable. It's possible e.g. for class static variables,
they has one global symbol and one symbol belonging to a class.
PDB has no info about namespaces, so this implementation parses the full symbol
name and tries to figure out if the symbol belongs to namespace or not,
and then creates nested namespaces if necessary.
Reviewers: asmith, zturner, labath
Reviewed By: asmith
Subscribers: aleksandr.urakov, teemperor, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D51162
llvm-svn: 341782
2018-09-10 08:08:43 +00:00
|
|
|
if (!parent_decl_ctx)
|
|
|
|
|
parent_decl_ctx = m_tu_decl_ctx_up.get();
|
2018-05-23 01:52:42 +00:00
|
|
|
if (!DeclContextMatchesThisSymbolFile(parent_decl_ctx))
|
|
|
|
|
return 0;
|
|
|
|
|
if (name.IsEmpty())
|
|
|
|
|
return 0;
|
|
|
|
|
|
[PDB] Restore AST from PDB symbols
Summary:
This patch adds an implementation of retrieving of declarations and declaration
contexts based on PDB symbols.
PDB has different type symbols for const-qualified types, and this
implementation ensures that only one declaration was created for both const
and non-const types, but creates different compiler types for them.
The implementation also processes the case when there are two symbols
corresponding to a variable. It's possible e.g. for class static variables,
they has one global symbol and one symbol belonging to a class.
PDB has no info about namespaces, so this implementation parses the full symbol
name and tries to figure out if the symbol belongs to namespace or not,
and then creates nested namespaces if necessary.
Reviewers: asmith, zturner, labath
Reviewed By: asmith
Subscribers: aleksandr.urakov, teemperor, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D51162
llvm-svn: 341782
2018-09-10 08:08:43 +00:00
|
|
|
auto results = m_global_scope_up->findAllChildren<PDBSymbolData>();
|
2018-05-23 01:52:42 +00:00
|
|
|
if (!results)
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
uint32_t matches = 0;
|
|
|
|
|
size_t old_size = variables.GetSize();
|
|
|
|
|
while (auto result = results->getNext()) {
|
|
|
|
|
auto pdb_data = llvm::dyn_cast<PDBSymbolData>(result.get());
|
|
|
|
|
if (max_matches > 0 && matches >= max_matches)
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
SymbolContext sc;
|
|
|
|
|
sc.module_sp = m_obj_file->GetModule();
|
|
|
|
|
lldbassert(sc.module_sp.get());
|
|
|
|
|
|
[PDB] Restore AST from PDB symbols
Summary:
This patch adds an implementation of retrieving of declarations and declaration
contexts based on PDB symbols.
PDB has different type symbols for const-qualified types, and this
implementation ensures that only one declaration was created for both const
and non-const types, but creates different compiler types for them.
The implementation also processes the case when there are two symbols
corresponding to a variable. It's possible e.g. for class static variables,
they has one global symbol and one symbol belonging to a class.
PDB has no info about namespaces, so this implementation parses the full symbol
name and tries to figure out if the symbol belongs to namespace or not,
and then creates nested namespaces if necessary.
Reviewers: asmith, zturner, labath
Reviewed By: asmith
Subscribers: aleksandr.urakov, teemperor, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D51162
llvm-svn: 341782
2018-09-10 08:08:43 +00:00
|
|
|
if (!name.GetStringRef().equals(
|
|
|
|
|
PDBASTParser::PDBNameDropScope(pdb_data->getName())))
|
|
|
|
|
continue;
|
|
|
|
|
|
[PDB] Improve performance of the PDB DIA plugin
Summary:
This patch improves performance of `SymbolFilePDB` on huge executables
in two ways:
- cache names of public symbols by address. When creating variables we are
trying to get a mangled name for each one, and in `GetMangledForPDBData`
we are enumerating all public symbols, which takes O(n) for each variable.
With the cache we can retrieve a mangled name in O(log(n));
- cache section contributions. When parsing variables for context we are
enumerating all variables and check if the current one is belonging
to the current compiland. So we are retrieving a compiland ID
for the variable. But in `PDBSymbolData::getCompilandId` for almost every
variable we are enumerating all section contributions to check if the variable
is belonging to it, and get a compiland ID from the section contribution
if so. It takes O(n) for each variable, but with caching it takes about
O(log(n)). I've placed the cache in `SymbolFilePDB` and have created
`GetCompilandId` there. It actually duplicates `PDBSymbolData::getCompilandId`
except for the cache part. Another option is to support caching
in `PDBSymbolData::getCompilandId` and to place cache in `DIASession`, but it
seems that the last one doesn't imply such functionality, because
it's a lightweight wrapper over DIA and whole its state is only a COM pointer
to the DIA session. Moreover, `PDBSymbolData::getCompilandId` is used only
inside of `SymbolFilePDB`, so I think that it's not a bad place to do such
things. With this patch `PDBSymbolData::getCompilandId` is not used at all.
This bottlenecks were found with profiling. I've discovered these on a simple
demo project of Unreal Engine (x86 executable ~72M, PDB ~82M).
This patch doesn't change external behavior of the plugin, so I think that
there's no need for additional testing (already existing tests should warn us
about regress, if any).
Reviewers: zturner, asmith, labath
Reviewed By: asmith
Subscribers: Hui, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D53375
llvm-svn: 345013
2018-10-23 08:29:17 +00:00
|
|
|
sc.comp_unit = ParseCompileUnitForUID(GetCompilandId(*pdb_data)).get();
|
|
|
|
|
// FIXME: We are not able to determine the compile unit.
|
|
|
|
|
if (sc.comp_unit == nullptr)
|
|
|
|
|
continue;
|
|
|
|
|
|
[PDB] Restore AST from PDB symbols
Summary:
This patch adds an implementation of retrieving of declarations and declaration
contexts based on PDB symbols.
PDB has different type symbols for const-qualified types, and this
implementation ensures that only one declaration was created for both const
and non-const types, but creates different compiler types for them.
The implementation also processes the case when there are two symbols
corresponding to a variable. It's possible e.g. for class static variables,
they has one global symbol and one symbol belonging to a class.
PDB has no info about namespaces, so this implementation parses the full symbol
name and tries to figure out if the symbol belongs to namespace or not,
and then creates nested namespaces if necessary.
Reviewers: asmith, zturner, labath
Reviewed By: asmith
Subscribers: aleksandr.urakov, teemperor, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D51162
llvm-svn: 341782
2018-09-10 08:08:43 +00:00
|
|
|
auto actual_parent_decl_ctx =
|
|
|
|
|
GetDeclContextContainingUID(result->getSymIndexId());
|
|
|
|
|
if (actual_parent_decl_ctx != *parent_decl_ctx)
|
|
|
|
|
continue;
|
|
|
|
|
|
2018-05-23 01:52:42 +00:00
|
|
|
ParseVariables(sc, *pdb_data, &variables);
|
|
|
|
|
matches = variables.GetSize() - old_size;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return matches;
|
2016-09-06 20:57:50 +00:00
|
|
|
}
|
2016-04-15 00:21:26 +00:00
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
uint32_t
|
|
|
|
|
SymbolFilePDB::FindGlobalVariables(const lldb_private::RegularExpression ®ex,
|
2018-05-31 09:46:26 +00:00
|
|
|
uint32_t max_matches,
|
2016-09-06 20:57:50 +00:00
|
|
|
lldb_private::VariableList &variables) {
|
2018-05-23 01:52:42 +00:00
|
|
|
if (!regex.IsValid())
|
|
|
|
|
return 0;
|
|
|
|
|
auto results = m_global_scope_up->findAllChildren<PDBSymbolData>();
|
|
|
|
|
if (!results)
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
uint32_t matches = 0;
|
|
|
|
|
size_t old_size = variables.GetSize();
|
|
|
|
|
while (auto pdb_data = results->getNext()) {
|
|
|
|
|
if (max_matches > 0 && matches >= max_matches)
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
auto var_name = pdb_data->getName();
|
|
|
|
|
if (var_name.empty())
|
|
|
|
|
continue;
|
|
|
|
|
if (!regex.Execute(var_name))
|
|
|
|
|
continue;
|
|
|
|
|
SymbolContext sc;
|
|
|
|
|
sc.module_sp = m_obj_file->GetModule();
|
|
|
|
|
lldbassert(sc.module_sp.get());
|
|
|
|
|
|
[PDB] Improve performance of the PDB DIA plugin
Summary:
This patch improves performance of `SymbolFilePDB` on huge executables
in two ways:
- cache names of public symbols by address. When creating variables we are
trying to get a mangled name for each one, and in `GetMangledForPDBData`
we are enumerating all public symbols, which takes O(n) for each variable.
With the cache we can retrieve a mangled name in O(log(n));
- cache section contributions. When parsing variables for context we are
enumerating all variables and check if the current one is belonging
to the current compiland. So we are retrieving a compiland ID
for the variable. But in `PDBSymbolData::getCompilandId` for almost every
variable we are enumerating all section contributions to check if the variable
is belonging to it, and get a compiland ID from the section contribution
if so. It takes O(n) for each variable, but with caching it takes about
O(log(n)). I've placed the cache in `SymbolFilePDB` and have created
`GetCompilandId` there. It actually duplicates `PDBSymbolData::getCompilandId`
except for the cache part. Another option is to support caching
in `PDBSymbolData::getCompilandId` and to place cache in `DIASession`, but it
seems that the last one doesn't imply such functionality, because
it's a lightweight wrapper over DIA and whole its state is only a COM pointer
to the DIA session. Moreover, `PDBSymbolData::getCompilandId` is used only
inside of `SymbolFilePDB`, so I think that it's not a bad place to do such
things. With this patch `PDBSymbolData::getCompilandId` is not used at all.
This bottlenecks were found with profiling. I've discovered these on a simple
demo project of Unreal Engine (x86 executable ~72M, PDB ~82M).
This patch doesn't change external behavior of the plugin, so I think that
there's no need for additional testing (already existing tests should warn us
about regress, if any).
Reviewers: zturner, asmith, labath
Reviewed By: asmith
Subscribers: Hui, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D53375
llvm-svn: 345013
2018-10-23 08:29:17 +00:00
|
|
|
sc.comp_unit = ParseCompileUnitForUID(GetCompilandId(*pdb_data)).get();
|
2018-05-23 01:52:42 +00:00
|
|
|
// FIXME: We are not able to determine the compile unit.
|
|
|
|
|
if (sc.comp_unit == nullptr)
|
|
|
|
|
continue;
|
|
|
|
|
|
|
|
|
|
ParseVariables(sc, *pdb_data, &variables);
|
|
|
|
|
matches = variables.GetSize() - old_size;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return matches;
|
2016-09-06 20:57:50 +00:00
|
|
|
}
|
2016-04-15 00:21:26 +00:00
|
|
|
|
2018-03-19 21:14:19 +00:00
|
|
|
bool SymbolFilePDB::ResolveFunction(const llvm::pdb::PDBSymbolFunc &pdb_func,
|
2018-02-09 05:31:28 +00:00
|
|
|
bool include_inlines,
|
|
|
|
|
lldb_private::SymbolContextList &sc_list) {
|
|
|
|
|
lldb_private::SymbolContext sc;
|
2018-03-20 00:34:18 +00:00
|
|
|
sc.comp_unit = ParseCompileUnitForUID(pdb_func.getCompilandId()).get();
|
2018-02-09 05:31:28 +00:00
|
|
|
if (!sc.comp_unit)
|
|
|
|
|
return false;
|
|
|
|
|
sc.module_sp = sc.comp_unit->GetModule();
|
2018-03-20 00:34:18 +00:00
|
|
|
sc.function = ParseCompileUnitFunctionForPDBFunc(pdb_func, sc);
|
2018-02-09 05:31:28 +00:00
|
|
|
if (!sc.function)
|
|
|
|
|
return false;
|
|
|
|
|
|
|
|
|
|
sc_list.Append(sc);
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool SymbolFilePDB::ResolveFunction(uint32_t uid, bool include_inlines,
|
|
|
|
|
lldb_private::SymbolContextList &sc_list) {
|
2018-03-22 03:44:51 +00:00
|
|
|
auto pdb_func_up = m_session_up->getConcreteSymbolById<PDBSymbolFunc>(uid);
|
2018-02-09 05:31:28 +00:00
|
|
|
if (!pdb_func_up && !(include_inlines && pdb_func_up->hasInlineAttribute()))
|
|
|
|
|
return false;
|
2018-03-19 21:14:19 +00:00
|
|
|
return ResolveFunction(*pdb_func_up, include_inlines, sc_list);
|
2018-02-09 05:31:28 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void SymbolFilePDB::CacheFunctionNames() {
|
|
|
|
|
if (!m_func_full_names.IsEmpty())
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
|
|
std::map<uint64_t, uint32_t> addr_ids;
|
|
|
|
|
|
|
|
|
|
if (auto results_up = m_global_scope_up->findAllChildren<PDBSymbolFunc>()) {
|
|
|
|
|
while (auto pdb_func_up = results_up->getNext()) {
|
2018-03-07 03:16:50 +00:00
|
|
|
if (pdb_func_up->isCompilerGenerated())
|
|
|
|
|
continue;
|
|
|
|
|
|
2018-02-09 05:31:28 +00:00
|
|
|
auto name = pdb_func_up->getName();
|
|
|
|
|
auto demangled_name = pdb_func_up->getUndecoratedName();
|
|
|
|
|
if (name.empty() && demangled_name.empty())
|
|
|
|
|
continue;
|
|
|
|
|
|
2018-03-07 03:16:50 +00:00
|
|
|
auto uid = pdb_func_up->getSymIndexId();
|
2018-02-09 05:31:28 +00:00
|
|
|
if (!demangled_name.empty() && pdb_func_up->getVirtualAddress())
|
|
|
|
|
addr_ids.insert(std::make_pair(pdb_func_up->getVirtualAddress(), uid));
|
|
|
|
|
|
|
|
|
|
if (auto parent = pdb_func_up->getClassParent()) {
|
|
|
|
|
|
|
|
|
|
// PDB have symbols for class/struct methods or static methods in Enum
|
|
|
|
|
// Class. We won't bother to check if the parent is UDT or Enum here.
|
|
|
|
|
m_func_method_names.Append(ConstString(name), uid);
|
|
|
|
|
|
|
|
|
|
ConstString cstr_name(name);
|
|
|
|
|
|
2018-04-30 16:49:04 +00:00
|
|
|
// To search a method name, like NS::Class:MemberFunc, LLDB searches
|
|
|
|
|
// its base name, i.e. MemberFunc by default. Since PDBSymbolFunc does
|
|
|
|
|
// not have inforamtion of this, we extract base names and cache them
|
|
|
|
|
// by our own effort.
|
2018-02-09 05:31:28 +00:00
|
|
|
llvm::StringRef basename;
|
|
|
|
|
CPlusPlusLanguage::MethodName cpp_method(cstr_name);
|
|
|
|
|
if (cpp_method.IsValid()) {
|
|
|
|
|
llvm::StringRef context;
|
|
|
|
|
basename = cpp_method.GetBasename();
|
|
|
|
|
if (basename.empty())
|
|
|
|
|
CPlusPlusLanguage::ExtractContextAndIdentifier(name.c_str(),
|
|
|
|
|
context, basename);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (!basename.empty())
|
|
|
|
|
m_func_base_names.Append(ConstString(basename), uid);
|
|
|
|
|
else {
|
|
|
|
|
m_func_base_names.Append(ConstString(name), uid);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (!demangled_name.empty())
|
|
|
|
|
m_func_full_names.Append(ConstString(demangled_name), uid);
|
|
|
|
|
|
|
|
|
|
} else {
|
|
|
|
|
// Handle not-method symbols.
|
|
|
|
|
|
|
|
|
|
// The function name might contain namespace, or its lexical scope. It
|
|
|
|
|
// is not safe to get its base name by applying same scheme as we deal
|
|
|
|
|
// with the method names.
|
|
|
|
|
// FIXME: Remove namespace if function is static in a scope.
|
|
|
|
|
m_func_base_names.Append(ConstString(name), uid);
|
|
|
|
|
|
|
|
|
|
if (name == "main") {
|
|
|
|
|
m_func_full_names.Append(ConstString(name), uid);
|
|
|
|
|
|
|
|
|
|
if (!demangled_name.empty() && name != demangled_name) {
|
|
|
|
|
m_func_full_names.Append(ConstString(demangled_name), uid);
|
|
|
|
|
m_func_base_names.Append(ConstString(demangled_name), uid);
|
|
|
|
|
}
|
|
|
|
|
} else if (!demangled_name.empty()) {
|
|
|
|
|
m_func_full_names.Append(ConstString(demangled_name), uid);
|
|
|
|
|
} else {
|
|
|
|
|
m_func_full_names.Append(ConstString(name), uid);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (auto results_up =
|
2018-03-22 03:44:51 +00:00
|
|
|
m_global_scope_up->findAllChildren<PDBSymbolPublicSymbol>()) {
|
2018-02-09 05:31:28 +00:00
|
|
|
while (auto pub_sym_up = results_up->getNext()) {
|
|
|
|
|
if (!pub_sym_up->isFunction())
|
|
|
|
|
continue;
|
|
|
|
|
auto name = pub_sym_up->getName();
|
|
|
|
|
if (name.empty())
|
|
|
|
|
continue;
|
|
|
|
|
|
|
|
|
|
if (CPlusPlusLanguage::IsCPPMangledName(name.c_str())) {
|
|
|
|
|
auto vm_addr = pub_sym_up->getVirtualAddress();
|
|
|
|
|
|
|
|
|
|
// PDB public symbol has mangled name for its associated function.
|
|
|
|
|
if (vm_addr && addr_ids.find(vm_addr) != addr_ids.end()) {
|
|
|
|
|
// Cache mangled name.
|
|
|
|
|
m_func_full_names.Append(ConstString(name), addr_ids[vm_addr]);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
// Sort them before value searching is working properly
|
|
|
|
|
m_func_full_names.Sort();
|
|
|
|
|
m_func_full_names.SizeToFit();
|
|
|
|
|
m_func_method_names.Sort();
|
|
|
|
|
m_func_method_names.SizeToFit();
|
|
|
|
|
m_func_base_names.Sort();
|
|
|
|
|
m_func_base_names.SizeToFit();
|
|
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
uint32_t SymbolFilePDB::FindFunctions(
|
|
|
|
|
const lldb_private::ConstString &name,
|
|
|
|
|
const lldb_private::CompilerDeclContext *parent_decl_ctx,
|
2018-10-25 20:45:40 +00:00
|
|
|
FunctionNameType name_type_mask, bool include_inlines, bool append,
|
2016-09-06 20:57:50 +00:00
|
|
|
lldb_private::SymbolContextList &sc_list) {
|
2018-02-09 05:31:28 +00:00
|
|
|
if (!append)
|
|
|
|
|
sc_list.Clear();
|
|
|
|
|
lldbassert((name_type_mask & eFunctionNameTypeAuto) == 0);
|
|
|
|
|
|
|
|
|
|
if (name_type_mask == eFunctionNameTypeNone)
|
|
|
|
|
return 0;
|
|
|
|
|
if (!DeclContextMatchesThisSymbolFile(parent_decl_ctx))
|
|
|
|
|
return 0;
|
|
|
|
|
if (name.IsEmpty())
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
auto old_size = sc_list.GetSize();
|
2018-02-09 11:37:01 +00:00
|
|
|
if (name_type_mask & eFunctionNameTypeFull ||
|
|
|
|
|
name_type_mask & eFunctionNameTypeBase ||
|
2018-02-09 05:31:28 +00:00
|
|
|
name_type_mask & eFunctionNameTypeMethod) {
|
|
|
|
|
CacheFunctionNames();
|
|
|
|
|
|
|
|
|
|
std::set<uint32_t> resolved_ids;
|
2018-03-22 03:44:51 +00:00
|
|
|
auto ResolveFn = [include_inlines, &name, &sc_list, &resolved_ids,
|
|
|
|
|
this](UniqueCStringMap<uint32_t> &Names) {
|
2018-02-09 05:31:28 +00:00
|
|
|
std::vector<uint32_t> ids;
|
|
|
|
|
if (Names.GetValues(name, ids)) {
|
|
|
|
|
for (auto id : ids) {
|
|
|
|
|
if (resolved_ids.find(id) == resolved_ids.end()) {
|
|
|
|
|
if (ResolveFunction(id, include_inlines, sc_list))
|
|
|
|
|
resolved_ids.insert(id);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
if (name_type_mask & eFunctionNameTypeFull) {
|
|
|
|
|
ResolveFn(m_func_full_names);
|
|
|
|
|
}
|
|
|
|
|
if (name_type_mask & eFunctionNameTypeBase) {
|
|
|
|
|
ResolveFn(m_func_base_names);
|
|
|
|
|
}
|
|
|
|
|
if (name_type_mask & eFunctionNameTypeMethod) {
|
|
|
|
|
ResolveFn(m_func_method_names);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
return sc_list.GetSize() - old_size;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
uint32_t
|
|
|
|
|
SymbolFilePDB::FindFunctions(const lldb_private::RegularExpression ®ex,
|
|
|
|
|
bool include_inlines, bool append,
|
|
|
|
|
lldb_private::SymbolContextList &sc_list) {
|
2018-02-09 05:31:28 +00:00
|
|
|
if (!append)
|
|
|
|
|
sc_list.Clear();
|
|
|
|
|
if (!regex.IsValid())
|
|
|
|
|
return 0;
|
|
|
|
|
|
|
|
|
|
auto old_size = sc_list.GetSize();
|
|
|
|
|
CacheFunctionNames();
|
|
|
|
|
|
|
|
|
|
std::set<uint32_t> resolved_ids;
|
2018-03-22 03:44:51 +00:00
|
|
|
auto ResolveFn = [®ex, include_inlines, &sc_list, &resolved_ids,
|
|
|
|
|
this](UniqueCStringMap<uint32_t> &Names) {
|
2018-02-09 05:31:28 +00:00
|
|
|
std::vector<uint32_t> ids;
|
|
|
|
|
if (Names.GetValues(regex, ids)) {
|
|
|
|
|
for (auto id : ids) {
|
|
|
|
|
if (resolved_ids.find(id) == resolved_ids.end())
|
|
|
|
|
if (ResolveFunction(id, include_inlines, sc_list))
|
|
|
|
|
resolved_ids.insert(id);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
};
|
|
|
|
|
ResolveFn(m_func_full_names);
|
|
|
|
|
ResolveFn(m_func_base_names);
|
|
|
|
|
|
|
|
|
|
return sc_list.GetSize() - old_size;
|
2016-09-06 20:57:50 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void SymbolFilePDB::GetMangledNamesForFunction(
|
|
|
|
|
const std::string &scope_qualified_name,
|
|
|
|
|
std::vector<lldb_private::ConstString> &mangled_names) {}
|
|
|
|
|
|
|
|
|
|
uint32_t SymbolFilePDB::FindTypes(
|
|
|
|
|
const lldb_private::SymbolContext &sc,
|
|
|
|
|
const lldb_private::ConstString &name,
|
|
|
|
|
const lldb_private::CompilerDeclContext *parent_decl_ctx, bool append,
|
|
|
|
|
uint32_t max_matches,
|
|
|
|
|
llvm::DenseSet<lldb_private::SymbolFile *> &searched_symbol_files,
|
|
|
|
|
lldb_private::TypeMap &types) {
|
|
|
|
|
if (!append)
|
|
|
|
|
types.Clear();
|
|
|
|
|
if (!name)
|
2016-04-15 00:21:26 +00:00
|
|
|
return 0;
|
2018-02-09 05:31:28 +00:00
|
|
|
if (!DeclContextMatchesThisSymbolFile(parent_decl_ctx))
|
|
|
|
|
return 0;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
searched_symbol_files.clear();
|
|
|
|
|
searched_symbol_files.insert(this);
|
|
|
|
|
|
|
|
|
|
std::string name_str = name.AsCString();
|
|
|
|
|
|
2017-12-22 05:26:50 +00:00
|
|
|
// There is an assumption 'name' is not a regex
|
[PDB] Restore AST from PDB symbols
Summary:
This patch adds an implementation of retrieving of declarations and declaration
contexts based on PDB symbols.
PDB has different type symbols for const-qualified types, and this
implementation ensures that only one declaration was created for both const
and non-const types, but creates different compiler types for them.
The implementation also processes the case when there are two symbols
corresponding to a variable. It's possible e.g. for class static variables,
they has one global symbol and one symbol belonging to a class.
PDB has no info about namespaces, so this implementation parses the full symbol
name and tries to figure out if the symbol belongs to namespace or not,
and then creates nested namespaces if necessary.
Reviewers: asmith, zturner, labath
Reviewed By: asmith
Subscribers: aleksandr.urakov, teemperor, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D51162
llvm-svn: 341782
2018-09-10 08:08:43 +00:00
|
|
|
FindTypesByName(name_str, parent_decl_ctx, max_matches, types);
|
2018-03-22 03:44:51 +00:00
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
return types.GetSize();
|
|
|
|
|
}
|
|
|
|
|
|
2018-03-22 03:44:51 +00:00
|
|
|
void SymbolFilePDB::FindTypesByRegex(
|
|
|
|
|
const lldb_private::RegularExpression ®ex, uint32_t max_matches,
|
|
|
|
|
lldb_private::TypeMap &types) {
|
2016-09-06 20:57:50 +00:00
|
|
|
// When searching by regex, we need to go out of our way to limit the search
|
2017-01-27 21:42:28 +00:00
|
|
|
// space as much as possible since this searches EVERYTHING in the PDB,
|
|
|
|
|
// manually doing regex comparisons. PDB library isn't optimized for regex
|
|
|
|
|
// searches or searches across multiple symbol types at the same time, so the
|
2016-09-06 20:57:50 +00:00
|
|
|
// best we can do is to search enums, then typedefs, then classes one by one,
|
2017-01-27 21:42:28 +00:00
|
|
|
// and do a regex comparison against each of them.
|
2016-09-06 20:57:50 +00:00
|
|
|
PDB_SymType tags_to_search[] = {PDB_SymType::Enum, PDB_SymType::Typedef,
|
|
|
|
|
PDB_SymType::UDT};
|
|
|
|
|
std::unique_ptr<IPDBEnumSymbols> results;
|
|
|
|
|
|
|
|
|
|
uint32_t matches = 0;
|
|
|
|
|
|
|
|
|
|
for (auto tag : tags_to_search) {
|
2018-01-13 06:58:18 +00:00
|
|
|
results = m_global_scope_up->findAllChildren(tag);
|
|
|
|
|
if (!results)
|
|
|
|
|
continue;
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
while (auto result = results->getNext()) {
|
|
|
|
|
if (max_matches > 0 && matches >= max_matches)
|
|
|
|
|
break;
|
|
|
|
|
|
|
|
|
|
std::string type_name;
|
|
|
|
|
if (auto enum_type = llvm::dyn_cast<PDBSymbolTypeEnum>(result.get()))
|
|
|
|
|
type_name = enum_type->getName();
|
|
|
|
|
else if (auto typedef_type =
|
2018-03-22 03:44:51 +00:00
|
|
|
llvm::dyn_cast<PDBSymbolTypeTypedef>(result.get()))
|
2016-09-06 20:57:50 +00:00
|
|
|
type_name = typedef_type->getName();
|
|
|
|
|
else if (auto class_type = llvm::dyn_cast<PDBSymbolTypeUDT>(result.get()))
|
|
|
|
|
type_name = class_type->getName();
|
|
|
|
|
else {
|
2017-01-27 21:42:28 +00:00
|
|
|
// We're looking only for types that have names. Skip symbols, as well
|
|
|
|
|
// as unnamed types such as arrays, pointers, etc.
|
2016-09-06 20:57:50 +00:00
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2017-12-22 05:26:50 +00:00
|
|
|
if (!regex.Execute(type_name))
|
2016-09-06 20:57:50 +00:00
|
|
|
continue;
|
|
|
|
|
|
|
|
|
|
// This should cause the type to get cached and stored in the `m_types`
|
|
|
|
|
// lookup.
|
|
|
|
|
if (!ResolveTypeUID(result->getSymIndexId()))
|
|
|
|
|
continue;
|
|
|
|
|
|
|
|
|
|
auto iter = m_types.find(result->getSymIndexId());
|
|
|
|
|
if (iter == m_types.end())
|
|
|
|
|
continue;
|
|
|
|
|
types.Insert(iter->second);
|
|
|
|
|
++matches;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
[PDB] Restore AST from PDB symbols
Summary:
This patch adds an implementation of retrieving of declarations and declaration
contexts based on PDB symbols.
PDB has different type symbols for const-qualified types, and this
implementation ensures that only one declaration was created for both const
and non-const types, but creates different compiler types for them.
The implementation also processes the case when there are two symbols
corresponding to a variable. It's possible e.g. for class static variables,
they has one global symbol and one symbol belonging to a class.
PDB has no info about namespaces, so this implementation parses the full symbol
name and tries to figure out if the symbol belongs to namespace or not,
and then creates nested namespaces if necessary.
Reviewers: asmith, zturner, labath
Reviewed By: asmith
Subscribers: aleksandr.urakov, teemperor, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D51162
llvm-svn: 341782
2018-09-10 08:08:43 +00:00
|
|
|
void SymbolFilePDB::FindTypesByName(
|
|
|
|
|
const std::string &name,
|
|
|
|
|
const lldb_private::CompilerDeclContext *parent_decl_ctx,
|
|
|
|
|
uint32_t max_matches, lldb_private::TypeMap &types) {
|
|
|
|
|
if (!parent_decl_ctx)
|
|
|
|
|
parent_decl_ctx = m_tu_decl_ctx_up.get();
|
2016-09-06 20:57:50 +00:00
|
|
|
std::unique_ptr<IPDBEnumSymbols> results;
|
2018-03-07 03:16:50 +00:00
|
|
|
if (name.empty())
|
|
|
|
|
return;
|
[PDB] Restore AST from PDB symbols
Summary:
This patch adds an implementation of retrieving of declarations and declaration
contexts based on PDB symbols.
PDB has different type symbols for const-qualified types, and this
implementation ensures that only one declaration was created for both const
and non-const types, but creates different compiler types for them.
The implementation also processes the case when there are two symbols
corresponding to a variable. It's possible e.g. for class static variables,
they has one global symbol and one symbol belonging to a class.
PDB has no info about namespaces, so this implementation parses the full symbol
name and tries to figure out if the symbol belongs to namespace or not,
and then creates nested namespaces if necessary.
Reviewers: asmith, zturner, labath
Reviewed By: asmith
Subscribers: aleksandr.urakov, teemperor, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D51162
llvm-svn: 341782
2018-09-10 08:08:43 +00:00
|
|
|
results = m_global_scope_up->findAllChildren(PDB_SymType::None);
|
2018-01-13 06:58:18 +00:00
|
|
|
if (!results)
|
|
|
|
|
return;
|
2016-09-06 20:57:50 +00:00
|
|
|
|
|
|
|
|
uint32_t matches = 0;
|
|
|
|
|
|
|
|
|
|
while (auto result = results->getNext()) {
|
|
|
|
|
if (max_matches > 0 && matches >= max_matches)
|
|
|
|
|
break;
|
[PDB] Restore AST from PDB symbols
Summary:
This patch adds an implementation of retrieving of declarations and declaration
contexts based on PDB symbols.
PDB has different type symbols for const-qualified types, and this
implementation ensures that only one declaration was created for both const
and non-const types, but creates different compiler types for them.
The implementation also processes the case when there are two symbols
corresponding to a variable. It's possible e.g. for class static variables,
they has one global symbol and one symbol belonging to a class.
PDB has no info about namespaces, so this implementation parses the full symbol
name and tries to figure out if the symbol belongs to namespace or not,
and then creates nested namespaces if necessary.
Reviewers: asmith, zturner, labath
Reviewed By: asmith
Subscribers: aleksandr.urakov, teemperor, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D51162
llvm-svn: 341782
2018-09-10 08:08:43 +00:00
|
|
|
|
|
|
|
|
if (PDBASTParser::PDBNameDropScope(result->getRawSymbol().getName()) !=
|
|
|
|
|
name)
|
|
|
|
|
continue;
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
switch (result->getSymTag()) {
|
|
|
|
|
case PDB_SymType::Enum:
|
|
|
|
|
case PDB_SymType::UDT:
|
|
|
|
|
case PDB_SymType::Typedef:
|
|
|
|
|
break;
|
|
|
|
|
default:
|
2018-04-30 16:49:04 +00:00
|
|
|
// We're looking only for types that have names. Skip symbols, as well
|
|
|
|
|
// as unnamed types such as arrays, pointers, etc.
|
2016-09-06 20:57:50 +00:00
|
|
|
continue;
|
|
|
|
|
}
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
// This should cause the type to get cached and stored in the `m_types`
|
|
|
|
|
// lookup.
|
|
|
|
|
if (!ResolveTypeUID(result->getSymIndexId()))
|
|
|
|
|
continue;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
|
[PDB] Restore AST from PDB symbols
Summary:
This patch adds an implementation of retrieving of declarations and declaration
contexts based on PDB symbols.
PDB has different type symbols for const-qualified types, and this
implementation ensures that only one declaration was created for both const
and non-const types, but creates different compiler types for them.
The implementation also processes the case when there are two symbols
corresponding to a variable. It's possible e.g. for class static variables,
they has one global symbol and one symbol belonging to a class.
PDB has no info about namespaces, so this implementation parses the full symbol
name and tries to figure out if the symbol belongs to namespace or not,
and then creates nested namespaces if necessary.
Reviewers: asmith, zturner, labath
Reviewed By: asmith
Subscribers: aleksandr.urakov, teemperor, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D51162
llvm-svn: 341782
2018-09-10 08:08:43 +00:00
|
|
|
auto actual_parent_decl_ctx =
|
|
|
|
|
GetDeclContextContainingUID(result->getSymIndexId());
|
|
|
|
|
if (actual_parent_decl_ctx != *parent_decl_ctx)
|
|
|
|
|
continue;
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
auto iter = m_types.find(result->getSymIndexId());
|
|
|
|
|
if (iter == m_types.end())
|
|
|
|
|
continue;
|
|
|
|
|
types.Insert(iter->second);
|
|
|
|
|
++matches;
|
|
|
|
|
}
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
size_t SymbolFilePDB::FindTypes(
|
|
|
|
|
const std::vector<lldb_private::CompilerContext> &contexts, bool append,
|
|
|
|
|
lldb_private::TypeMap &types) {
|
|
|
|
|
return 0;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2018-01-23 20:35:19 +00:00
|
|
|
lldb_private::TypeList *SymbolFilePDB::GetTypeList() {
|
|
|
|
|
return m_obj_file->GetModule()->GetTypeList();
|
|
|
|
|
}
|
2016-09-06 20:57:50 +00:00
|
|
|
|
2018-03-22 03:44:51 +00:00
|
|
|
void SymbolFilePDB::GetTypesForPDBSymbol(const llvm::pdb::PDBSymbol &pdb_symbol,
|
|
|
|
|
uint32_t type_mask,
|
|
|
|
|
TypeCollection &type_collection) {
|
2018-02-09 05:31:28 +00:00
|
|
|
bool can_parse = false;
|
2018-03-19 21:14:19 +00:00
|
|
|
switch (pdb_symbol.getSymTag()) {
|
2018-02-09 05:31:28 +00:00
|
|
|
case PDB_SymType::ArrayType:
|
|
|
|
|
can_parse = ((type_mask & eTypeClassArray) != 0);
|
|
|
|
|
break;
|
|
|
|
|
case PDB_SymType::BuiltinType:
|
|
|
|
|
can_parse = ((type_mask & eTypeClassBuiltin) != 0);
|
|
|
|
|
break;
|
|
|
|
|
case PDB_SymType::Enum:
|
|
|
|
|
can_parse = ((type_mask & eTypeClassEnumeration) != 0);
|
|
|
|
|
break;
|
|
|
|
|
case PDB_SymType::Function:
|
|
|
|
|
case PDB_SymType::FunctionSig:
|
|
|
|
|
can_parse = ((type_mask & eTypeClassFunction) != 0);
|
|
|
|
|
break;
|
|
|
|
|
case PDB_SymType::PointerType:
|
|
|
|
|
can_parse = ((type_mask & (eTypeClassPointer | eTypeClassBlockPointer |
|
|
|
|
|
eTypeClassMemberPointer)) != 0);
|
|
|
|
|
break;
|
|
|
|
|
case PDB_SymType::Typedef:
|
|
|
|
|
can_parse = ((type_mask & eTypeClassTypedef) != 0);
|
|
|
|
|
break;
|
|
|
|
|
case PDB_SymType::UDT: {
|
2018-03-19 21:14:19 +00:00
|
|
|
auto *udt = llvm::dyn_cast<PDBSymbolTypeUDT>(&pdb_symbol);
|
2018-02-09 05:31:28 +00:00
|
|
|
assert(udt);
|
|
|
|
|
can_parse = (udt->getUdtKind() != PDB_UdtType::Interface &&
|
2018-03-22 03:44:51 +00:00
|
|
|
((type_mask & (eTypeClassClass | eTypeClassStruct |
|
|
|
|
|
eTypeClassUnion)) != 0));
|
2018-02-09 05:31:28 +00:00
|
|
|
} break;
|
2018-03-22 03:44:51 +00:00
|
|
|
default:
|
|
|
|
|
break;
|
2018-02-09 05:31:28 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (can_parse) {
|
2018-03-19 21:14:19 +00:00
|
|
|
if (auto *type = ResolveTypeUID(pdb_symbol.getSymIndexId())) {
|
2018-02-09 05:31:28 +00:00
|
|
|
auto result =
|
|
|
|
|
std::find(type_collection.begin(), type_collection.end(), type);
|
|
|
|
|
if (result == type_collection.end())
|
|
|
|
|
type_collection.push_back(type);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2018-03-19 21:14:19 +00:00
|
|
|
auto results_up = pdb_symbol.findAllChildren();
|
2018-02-09 05:31:28 +00:00
|
|
|
while (auto symbol_up = results_up->getNext())
|
2018-03-19 21:14:19 +00:00
|
|
|
GetTypesForPDBSymbol(*symbol_up, type_mask, type_collection);
|
2018-02-09 05:31:28 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
size_t SymbolFilePDB::GetTypes(lldb_private::SymbolContextScope *sc_scope,
|
2018-10-25 20:45:40 +00:00
|
|
|
TypeClass type_mask,
|
2016-09-06 20:57:50 +00:00
|
|
|
lldb_private::TypeList &type_list) {
|
2018-02-09 05:31:28 +00:00
|
|
|
TypeCollection type_collection;
|
|
|
|
|
uint32_t old_size = type_list.GetSize();
|
2018-03-22 03:44:51 +00:00
|
|
|
CompileUnit *cu =
|
|
|
|
|
sc_scope ? sc_scope->CalculateSymbolContextCompileUnit() : nullptr;
|
2018-02-09 05:31:28 +00:00
|
|
|
if (cu) {
|
|
|
|
|
auto compiland_up = GetPDBCompilandByUID(cu->GetID());
|
2018-03-19 21:14:19 +00:00
|
|
|
if (!compiland_up)
|
|
|
|
|
return 0;
|
|
|
|
|
GetTypesForPDBSymbol(*compiland_up, type_mask, type_collection);
|
2018-02-09 05:31:28 +00:00
|
|
|
} else {
|
|
|
|
|
for (uint32_t cu_idx = 0; cu_idx < GetNumCompileUnits(); ++cu_idx) {
|
|
|
|
|
auto cu_sp = ParseCompileUnitAtIndex(cu_idx);
|
2018-03-22 19:21:34 +00:00
|
|
|
if (cu_sp) {
|
2018-03-19 21:14:19 +00:00
|
|
|
if (auto compiland_up = GetPDBCompilandByUID(cu_sp->GetID()))
|
|
|
|
|
GetTypesForPDBSymbol(*compiland_up, type_mask, type_collection);
|
2018-02-09 05:31:28 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
for (auto type : type_collection) {
|
|
|
|
|
type->GetForwardCompilerType();
|
|
|
|
|
type_list.Insert(type->shared_from_this());
|
|
|
|
|
}
|
|
|
|
|
return type_list.GetSize() - old_size;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
lldb_private::TypeSystem *
|
|
|
|
|
SymbolFilePDB::GetTypeSystemForLanguage(lldb::LanguageType language) {
|
|
|
|
|
auto type_system =
|
|
|
|
|
m_obj_file->GetModule()->GetTypeSystemForLanguage(language);
|
|
|
|
|
if (type_system)
|
|
|
|
|
type_system->SetSymbolFile(this);
|
|
|
|
|
return type_system;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
lldb_private::CompilerDeclContext SymbolFilePDB::FindNamespace(
|
|
|
|
|
const lldb_private::SymbolContext &sc,
|
|
|
|
|
const lldb_private::ConstString &name,
|
|
|
|
|
const lldb_private::CompilerDeclContext *parent_decl_ctx) {
|
[PDB] Restore AST from PDB symbols
Summary:
This patch adds an implementation of retrieving of declarations and declaration
contexts based on PDB symbols.
PDB has different type symbols for const-qualified types, and this
implementation ensures that only one declaration was created for both const
and non-const types, but creates different compiler types for them.
The implementation also processes the case when there are two symbols
corresponding to a variable. It's possible e.g. for class static variables,
they has one global symbol and one symbol belonging to a class.
PDB has no info about namespaces, so this implementation parses the full symbol
name and tries to figure out if the symbol belongs to namespace or not,
and then creates nested namespaces if necessary.
Reviewers: asmith, zturner, labath
Reviewed By: asmith
Subscribers: aleksandr.urakov, teemperor, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D51162
llvm-svn: 341782
2018-09-10 08:08:43 +00:00
|
|
|
auto type_system = GetTypeSystemForLanguage(lldb::eLanguageTypeC_plus_plus);
|
|
|
|
|
auto clang_type_system = llvm::dyn_cast_or_null<ClangASTContext>(type_system);
|
|
|
|
|
if (!clang_type_system)
|
|
|
|
|
return CompilerDeclContext();
|
|
|
|
|
|
|
|
|
|
PDBASTParser *pdb = clang_type_system->GetPDBParser();
|
|
|
|
|
if (!pdb)
|
|
|
|
|
return CompilerDeclContext();
|
|
|
|
|
|
|
|
|
|
clang::DeclContext *decl_context = nullptr;
|
|
|
|
|
if (parent_decl_ctx)
|
|
|
|
|
decl_context = static_cast<clang::DeclContext *>(
|
|
|
|
|
parent_decl_ctx->GetOpaqueDeclContext());
|
|
|
|
|
|
|
|
|
|
auto namespace_decl =
|
|
|
|
|
pdb->FindNamespaceDecl(decl_context, name.GetStringRef());
|
|
|
|
|
if (!namespace_decl)
|
|
|
|
|
return CompilerDeclContext();
|
|
|
|
|
|
|
|
|
|
return CompilerDeclContext(type_system,
|
|
|
|
|
static_cast<clang::DeclContext *>(namespace_decl));
|
2016-09-06 20:57:50 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
lldb_private::ConstString SymbolFilePDB::GetPluginName() {
|
|
|
|
|
static ConstString g_name("pdb");
|
|
|
|
|
return g_name;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
uint32_t SymbolFilePDB::GetPluginVersion() { return 1; }
|
|
|
|
|
|
|
|
|
|
IPDBSession &SymbolFilePDB::GetPDBSession() { return *m_session_up; }
|
|
|
|
|
|
|
|
|
|
const IPDBSession &SymbolFilePDB::GetPDBSession() const {
|
|
|
|
|
return *m_session_up;
|
|
|
|
|
}
|
|
|
|
|
|
2018-03-22 03:44:51 +00:00
|
|
|
lldb::CompUnitSP SymbolFilePDB::ParseCompileUnitForUID(uint32_t id,
|
|
|
|
|
uint32_t index) {
|
2016-09-06 20:57:50 +00:00
|
|
|
auto found_cu = m_comp_units.find(id);
|
|
|
|
|
if (found_cu != m_comp_units.end())
|
|
|
|
|
return found_cu->second;
|
|
|
|
|
|
2018-01-13 06:58:18 +00:00
|
|
|
auto compiland_up = GetPDBCompilandByUID(id);
|
|
|
|
|
if (!compiland_up)
|
|
|
|
|
return CompUnitSP();
|
2016-09-06 20:57:50 +00:00
|
|
|
|
|
|
|
|
lldb::LanguageType lang;
|
2018-01-13 06:58:18 +00:00
|
|
|
auto details = compiland_up->findOneChild<PDBSymbolCompilandDetails>();
|
2016-09-06 20:57:50 +00:00
|
|
|
if (!details)
|
|
|
|
|
lang = lldb::eLanguageTypeC_plus_plus;
|
|
|
|
|
else
|
|
|
|
|
lang = TranslateLanguage(details->getLanguage());
|
|
|
|
|
|
2018-03-07 03:16:50 +00:00
|
|
|
if (lang == lldb::LanguageType::eLanguageTypeUnknown)
|
|
|
|
|
return CompUnitSP();
|
|
|
|
|
|
2018-03-20 00:18:22 +00:00
|
|
|
std::string path = compiland_up->getSourceFileFullPath();
|
2018-03-07 03:16:50 +00:00
|
|
|
if (path.empty())
|
|
|
|
|
return CompUnitSP();
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
// Don't support optimized code for now, DebugInfoPDB does not return this
|
|
|
|
|
// information.
|
|
|
|
|
LazyBool optimized = eLazyBoolNo;
|
2018-03-22 03:44:51 +00:00
|
|
|
auto cu_sp = std::make_shared<CompileUnit>(m_obj_file->GetModule(), nullptr,
|
|
|
|
|
path.c_str(), id, lang, optimized);
|
2018-01-13 06:58:18 +00:00
|
|
|
|
|
|
|
|
if (!cu_sp)
|
|
|
|
|
return CompUnitSP();
|
|
|
|
|
|
|
|
|
|
m_comp_units.insert(std::make_pair(id, cu_sp));
|
|
|
|
|
if (index == UINT32_MAX)
|
2018-03-19 21:14:19 +00:00
|
|
|
GetCompileUnitIndex(*compiland_up, index);
|
2018-01-13 06:58:18 +00:00
|
|
|
lldbassert(index != UINT32_MAX);
|
2018-03-22 03:44:51 +00:00
|
|
|
m_obj_file->GetModule()->GetSymbolVendor()->SetCompileUnitAtIndex(index,
|
|
|
|
|
cu_sp);
|
2018-01-13 06:58:18 +00:00
|
|
|
return cu_sp;
|
2016-09-06 20:57:50 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool SymbolFilePDB::ParseCompileUnitLineTable(
|
|
|
|
|
const lldb_private::SymbolContext &sc, uint32_t match_line) {
|
2018-01-13 06:58:18 +00:00
|
|
|
lldbassert(sc.comp_unit);
|
|
|
|
|
|
|
|
|
|
auto compiland_up = GetPDBCompilandByUID(sc.comp_unit->GetID());
|
|
|
|
|
if (!compiland_up)
|
|
|
|
|
return false;
|
2016-09-06 20:57:50 +00:00
|
|
|
|
|
|
|
|
// LineEntry needs the *index* of the file into the list of support files
|
2017-01-27 21:42:28 +00:00
|
|
|
// returned by ParseCompileUnitSupportFiles. But the underlying SDK gives us
|
2018-04-30 16:49:04 +00:00
|
|
|
// a globally unique idenfitifier in the namespace of the PDB. So, we have
|
|
|
|
|
// to do a mapping so that we can hand out indices.
|
2016-09-06 20:57:50 +00:00
|
|
|
llvm::DenseMap<uint32_t, uint32_t> index_map;
|
2018-01-13 06:58:18 +00:00
|
|
|
BuildSupportFileIdToSupportFileIndexMap(*compiland_up, index_map);
|
2016-09-06 20:57:50 +00:00
|
|
|
auto line_table = llvm::make_unique<LineTable>(sc.comp_unit);
|
|
|
|
|
|
2018-01-13 06:58:18 +00:00
|
|
|
// Find contributions to `compiland` from all source and header files.
|
2016-09-06 20:57:50 +00:00
|
|
|
std::string path = sc.comp_unit->GetPath();
|
2018-01-13 06:58:18 +00:00
|
|
|
auto files = m_session_up->getSourceFilesForCompiland(*compiland_up);
|
|
|
|
|
if (!files)
|
|
|
|
|
return false;
|
2016-09-06 20:57:50 +00:00
|
|
|
|
2018-04-30 16:49:04 +00:00
|
|
|
// For each source and header file, create a LineSequence for contributions
|
|
|
|
|
// to the compiland from that file, and add the sequence.
|
2016-09-06 20:57:50 +00:00
|
|
|
while (auto file = files->getNext()) {
|
|
|
|
|
std::unique_ptr<LineSequence> sequence(
|
|
|
|
|
line_table->CreateLineSequenceContainer());
|
2018-01-13 06:58:18 +00:00
|
|
|
auto lines = m_session_up->findLineNumbers(*compiland_up, *file);
|
|
|
|
|
if (!lines)
|
|
|
|
|
continue;
|
2016-09-06 20:57:50 +00:00
|
|
|
int entry_count = lines->getChildCount();
|
|
|
|
|
|
|
|
|
|
uint64_t prev_addr;
|
|
|
|
|
uint32_t prev_length;
|
|
|
|
|
uint32_t prev_line;
|
|
|
|
|
uint32_t prev_source_idx;
|
|
|
|
|
|
|
|
|
|
for (int i = 0; i < entry_count; ++i) {
|
|
|
|
|
auto line = lines->getChildAtIndex(i);
|
|
|
|
|
|
|
|
|
|
uint64_t lno = line->getLineNumber();
|
|
|
|
|
uint64_t addr = line->getVirtualAddress();
|
|
|
|
|
uint32_t length = line->getLength();
|
|
|
|
|
uint32_t source_id = line->getSourceFileId();
|
|
|
|
|
uint32_t col = line->getColumnNumber();
|
|
|
|
|
uint32_t source_idx = index_map[source_id];
|
|
|
|
|
|
2018-04-30 16:49:04 +00:00
|
|
|
// There was a gap between the current entry and the previous entry if
|
|
|
|
|
// the addresses don't perfectly line up.
|
2016-09-06 20:57:50 +00:00
|
|
|
bool is_gap = (i > 0) && (prev_addr + prev_length < addr);
|
|
|
|
|
|
|
|
|
|
// Before inserting the current entry, insert a terminal entry at the end
|
2017-01-27 21:42:28 +00:00
|
|
|
// of the previous entry's address range if the current entry resulted in
|
|
|
|
|
// a gap from the previous entry.
|
2016-09-06 20:57:50 +00:00
|
|
|
if (is_gap && ShouldAddLine(match_line, prev_line, prev_length)) {
|
|
|
|
|
line_table->AppendLineEntryToSequence(
|
|
|
|
|
sequence.get(), prev_addr + prev_length, prev_line, 0,
|
|
|
|
|
prev_source_idx, false, false, false, false, true);
|
2018-06-08 02:45:25 +00:00
|
|
|
|
|
|
|
|
line_table->InsertSequence(sequence.release());
|
|
|
|
|
sequence.reset(line_table->CreateLineSequenceContainer());
|
2016-09-06 20:57:50 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (ShouldAddLine(match_line, lno, length)) {
|
|
|
|
|
bool is_statement = line->isStatement();
|
|
|
|
|
bool is_prologue = false;
|
|
|
|
|
bool is_epilogue = false;
|
|
|
|
|
auto func =
|
|
|
|
|
m_session_up->findSymbolByAddress(addr, PDB_SymType::Function);
|
|
|
|
|
if (func) {
|
|
|
|
|
auto prologue = func->findOneChild<PDBSymbolFuncDebugStart>();
|
2018-01-13 06:58:18 +00:00
|
|
|
if (prologue)
|
|
|
|
|
is_prologue = (addr == prologue->getVirtualAddress());
|
2016-09-06 20:57:50 +00:00
|
|
|
|
|
|
|
|
auto epilogue = func->findOneChild<PDBSymbolFuncDebugEnd>();
|
2018-01-13 06:58:18 +00:00
|
|
|
if (epilogue)
|
|
|
|
|
is_epilogue = (addr == epilogue->getVirtualAddress());
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
2016-03-10 00:06:26 +00:00
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
line_table->AppendLineEntryToSequence(sequence.get(), addr, lno, col,
|
|
|
|
|
source_idx, is_statement, false,
|
|
|
|
|
is_prologue, is_epilogue, false);
|
|
|
|
|
}
|
2016-03-10 00:06:26 +00:00
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
prev_addr = addr;
|
|
|
|
|
prev_length = length;
|
|
|
|
|
prev_line = lno;
|
|
|
|
|
prev_source_idx = source_idx;
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
|
|
|
|
|
2016-09-06 20:57:50 +00:00
|
|
|
if (entry_count > 0 && ShouldAddLine(match_line, prev_line, prev_length)) {
|
|
|
|
|
// The end is always a terminal entry, so insert it regardless.
|
|
|
|
|
line_table->AppendLineEntryToSequence(
|
|
|
|
|
sequence.get(), prev_addr + prev_length, prev_line, 0,
|
|
|
|
|
prev_source_idx, false, false, false, false, true);
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
2016-09-06 20:57:50 +00:00
|
|
|
|
|
|
|
|
line_table->InsertSequence(sequence.release());
|
|
|
|
|
}
|
|
|
|
|
|
2018-01-13 06:58:18 +00:00
|
|
|
if (line_table->GetSize()) {
|
|
|
|
|
sc.comp_unit->SetLineTable(line_table.release());
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
return false;
|
2016-09-06 20:57:50 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void SymbolFilePDB::BuildSupportFileIdToSupportFileIndexMap(
|
2018-01-13 06:58:18 +00:00
|
|
|
const PDBSymbolCompiland &compiland,
|
2016-09-06 20:57:50 +00:00
|
|
|
llvm::DenseMap<uint32_t, uint32_t> &index_map) const {
|
2018-04-30 16:49:04 +00:00
|
|
|
// This is a hack, but we need to convert the source id into an index into
|
|
|
|
|
// the support files array. We don't want to do path comparisons to avoid
|
2017-01-27 21:42:28 +00:00
|
|
|
// basename / full path issues that may or may not even be a problem, so we
|
|
|
|
|
// use the globally unique source file identifiers. Ideally we could use the
|
|
|
|
|
// global identifiers everywhere, but LineEntry currently assumes indices.
|
2018-01-13 06:58:18 +00:00
|
|
|
auto source_files = m_session_up->getSourceFilesForCompiland(compiland);
|
|
|
|
|
if (!source_files)
|
|
|
|
|
return;
|
2018-06-28 10:03:42 +00:00
|
|
|
|
|
|
|
|
// LLDB uses the DWARF-like file numeration (one based)
|
|
|
|
|
int index = 1;
|
2016-09-06 20:57:50 +00:00
|
|
|
|
|
|
|
|
while (auto file = source_files->getNext()) {
|
|
|
|
|
uint32_t source_id = file->getUniqueId();
|
|
|
|
|
index_map[source_id] = index++;
|
|
|
|
|
}
|
Add support for reading line tables from PDB files.
PDB is Microsoft's debug information format, and although we
cannot yet generate it, we still must be able to consume it.
Reason for this is that debug information for system libraries
(e.g. kernel32, C Runtime Library, etc) only have debug info
in PDB format, so in order to be able to support debugging
of system code, we must support it.
Currently this code should compile on every platform, but on
non-Windows platforms the PDB plugin will return 0 capabilities,
meaning that for now PDB is only supported on Windows. This
may change in the future, but the API is designed in such a way
that this will require few (if any) changes on the LLDB side.
In the future we can just flip a switch and everything will
work.
This patch only adds support for line tables. It does not return
information about functions, types, global variables, or anything
else. This functionality will be added in a followup patch.
Differential Revision: http://reviews.llvm.org/D17363
Reviewed by: Greg Clayton
llvm-svn: 262528
2016-03-02 22:05:52 +00:00
|
|
|
}
|
2018-02-09 05:31:28 +00:00
|
|
|
|
|
|
|
|
lldb::CompUnitSP SymbolFilePDB::GetCompileUnitContainsAddress(
|
2018-03-22 19:26:33 +00:00
|
|
|
const lldb_private::Address &so_addr) {
|
2018-02-09 05:31:28 +00:00
|
|
|
lldb::addr_t file_vm_addr = so_addr.GetFileAddress();
|
2018-03-22 19:26:33 +00:00
|
|
|
if (file_vm_addr == LLDB_INVALID_ADDRESS || file_vm_addr == 0)
|
2018-02-09 05:31:28 +00:00
|
|
|
return nullptr;
|
|
|
|
|
|
2018-03-22 19:26:33 +00:00
|
|
|
// If it is a PDB function's vm addr, this is the first sure bet.
|
|
|
|
|
if (auto lines =
|
|
|
|
|
m_session_up->findLineNumbersByAddress(file_vm_addr, /*Length=*/1)) {
|
|
|
|
|
if (auto first_line = lines->getNext())
|
|
|
|
|
return ParseCompileUnitForUID(first_line->getCompilandId());
|
2018-02-09 05:31:28 +00:00
|
|
|
}
|
|
|
|
|
|
2018-03-22 19:26:33 +00:00
|
|
|
// Otherwise we resort to section contributions.
|
|
|
|
|
if (auto sec_contribs = m_session_up->getSectionContribs()) {
|
|
|
|
|
while (auto section = sec_contribs->getNext()) {
|
|
|
|
|
auto va = section->getVirtualAddress();
|
|
|
|
|
if (file_vm_addr >= va && file_vm_addr < va + section->getLength())
|
|
|
|
|
return ParseCompileUnitForUID(section->getCompilandId());
|
|
|
|
|
}
|
|
|
|
|
}
|
2018-02-09 05:31:28 +00:00
|
|
|
return nullptr;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
Mangled
|
2018-03-19 21:14:19 +00:00
|
|
|
SymbolFilePDB::GetMangledForPDBFunc(const llvm::pdb::PDBSymbolFunc &pdb_func) {
|
2018-02-09 05:31:28 +00:00
|
|
|
Mangled mangled;
|
2018-03-19 21:14:19 +00:00
|
|
|
auto func_name = pdb_func.getName();
|
|
|
|
|
auto func_undecorated_name = pdb_func.getUndecoratedName();
|
2018-02-09 05:31:28 +00:00
|
|
|
std::string func_decorated_name;
|
|
|
|
|
|
|
|
|
|
// Seek from public symbols for non-static function's decorated name if any.
|
|
|
|
|
// For static functions, they don't have undecorated names and aren't exposed
|
|
|
|
|
// in Public Symbols either.
|
|
|
|
|
if (!func_undecorated_name.empty()) {
|
2018-03-22 03:44:51 +00:00
|
|
|
auto result_up = m_global_scope_up->findChildren(
|
|
|
|
|
PDB_SymType::PublicSymbol, func_undecorated_name,
|
|
|
|
|
PDB_NameSearchFlags::NS_UndecoratedName);
|
2018-02-09 05:31:28 +00:00
|
|
|
if (result_up) {
|
|
|
|
|
while (auto symbol_up = result_up->getNext()) {
|
|
|
|
|
// For a public symbol, it is unique.
|
|
|
|
|
lldbassert(result_up->getChildCount() == 1);
|
|
|
|
|
if (auto *pdb_public_sym =
|
2018-03-22 03:44:51 +00:00
|
|
|
llvm::dyn_cast_or_null<PDBSymbolPublicSymbol>(
|
|
|
|
|
symbol_up.get())) {
|
2018-02-09 05:31:28 +00:00
|
|
|
if (pdb_public_sym->isFunction()) {
|
|
|
|
|
func_decorated_name = pdb_public_sym->getName();
|
2018-03-07 03:16:50 +00:00
|
|
|
break;
|
2018-02-09 05:31:28 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
if (!func_decorated_name.empty()) {
|
|
|
|
|
mangled.SetMangledName(ConstString(func_decorated_name));
|
|
|
|
|
|
|
|
|
|
// For MSVC, format of C funciton's decorated name depends on calling
|
|
|
|
|
// conventon. Unfortunately none of the format is recognized by current
|
|
|
|
|
// LLDB. For example, `_purecall` is a __cdecl C function. From PDB,
|
2018-04-30 16:49:04 +00:00
|
|
|
// `__purecall` is retrieved as both its decorated and undecorated name
|
|
|
|
|
// (using PDBSymbolFunc::getUndecoratedName method). However `__purecall`
|
|
|
|
|
// string is not treated as mangled in LLDB (neither `?` nor `_Z` prefix).
|
|
|
|
|
// Mangled::GetDemangledName method will fail internally and caches an
|
|
|
|
|
// empty string as its undecorated name. So we will face a contradition
|
|
|
|
|
// here for the same symbol:
|
2018-02-09 05:31:28 +00:00
|
|
|
// non-empty undecorated name from PDB
|
|
|
|
|
// empty undecorated name from LLDB
|
|
|
|
|
if (!func_undecorated_name.empty() &&
|
|
|
|
|
mangled.GetDemangledName(mangled.GuessLanguage()).IsEmpty())
|
|
|
|
|
mangled.SetDemangledName(ConstString(func_undecorated_name));
|
|
|
|
|
|
|
|
|
|
// LLDB uses several flags to control how a C++ decorated name is
|
2018-04-30 16:49:04 +00:00
|
|
|
// undecorated for MSVC. See `safeUndecorateName` in Class Mangled. So the
|
|
|
|
|
// yielded name could be different from what we retrieve from
|
2018-02-09 05:31:28 +00:00
|
|
|
// PDB source unless we also apply same flags in getting undecorated
|
|
|
|
|
// name through PDBSymbolFunc::getUndecoratedNameEx method.
|
|
|
|
|
if (!func_undecorated_name.empty() &&
|
|
|
|
|
mangled.GetDemangledName(mangled.GuessLanguage()) !=
|
|
|
|
|
ConstString(func_undecorated_name))
|
|
|
|
|
mangled.SetDemangledName(ConstString(func_undecorated_name));
|
|
|
|
|
} else if (!func_undecorated_name.empty()) {
|
|
|
|
|
mangled.SetDemangledName(ConstString(func_undecorated_name));
|
|
|
|
|
} else if (!func_name.empty())
|
|
|
|
|
mangled.SetValue(ConstString(func_name), false);
|
|
|
|
|
|
|
|
|
|
return mangled;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
bool SymbolFilePDB::DeclContextMatchesThisSymbolFile(
|
|
|
|
|
const lldb_private::CompilerDeclContext *decl_ctx) {
|
|
|
|
|
if (decl_ctx == nullptr || !decl_ctx->IsValid())
|
|
|
|
|
return true;
|
|
|
|
|
|
|
|
|
|
TypeSystem *decl_ctx_type_system = decl_ctx->GetTypeSystem();
|
|
|
|
|
if (!decl_ctx_type_system)
|
|
|
|
|
return false;
|
|
|
|
|
TypeSystem *type_system = GetTypeSystemForLanguage(
|
|
|
|
|
decl_ctx_type_system->GetMinimumLanguage(nullptr));
|
|
|
|
|
if (decl_ctx_type_system == type_system)
|
|
|
|
|
return true; // The type systems match, return true
|
|
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
[PDB] Improve performance of the PDB DIA plugin
Summary:
This patch improves performance of `SymbolFilePDB` on huge executables
in two ways:
- cache names of public symbols by address. When creating variables we are
trying to get a mangled name for each one, and in `GetMangledForPDBData`
we are enumerating all public symbols, which takes O(n) for each variable.
With the cache we can retrieve a mangled name in O(log(n));
- cache section contributions. When parsing variables for context we are
enumerating all variables and check if the current one is belonging
to the current compiland. So we are retrieving a compiland ID
for the variable. But in `PDBSymbolData::getCompilandId` for almost every
variable we are enumerating all section contributions to check if the variable
is belonging to it, and get a compiland ID from the section contribution
if so. It takes O(n) for each variable, but with caching it takes about
O(log(n)). I've placed the cache in `SymbolFilePDB` and have created
`GetCompilandId` there. It actually duplicates `PDBSymbolData::getCompilandId`
except for the cache part. Another option is to support caching
in `PDBSymbolData::getCompilandId` and to place cache in `DIASession`, but it
seems that the last one doesn't imply such functionality, because
it's a lightweight wrapper over DIA and whole its state is only a COM pointer
to the DIA session. Moreover, `PDBSymbolData::getCompilandId` is used only
inside of `SymbolFilePDB`, so I think that it's not a bad place to do such
things. With this patch `PDBSymbolData::getCompilandId` is not used at all.
This bottlenecks were found with profiling. I've discovered these on a simple
demo project of Unreal Engine (x86 executable ~72M, PDB ~82M).
This patch doesn't change external behavior of the plugin, so I think that
there's no need for additional testing (already existing tests should warn us
about regress, if any).
Reviewers: zturner, asmith, labath
Reviewed By: asmith
Subscribers: Hui, lldb-commits, stella.stamenova
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D53375
llvm-svn: 345013
2018-10-23 08:29:17 +00:00
|
|
|
|
|
|
|
|
uint32_t SymbolFilePDB::GetCompilandId(const llvm::pdb::PDBSymbolData &data) {
|
|
|
|
|
static const auto pred_upper = [](uint32_t lhs, SecContribInfo rhs) {
|
|
|
|
|
return lhs < rhs.Offset;
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
// Cache section contributions
|
|
|
|
|
if (m_sec_contribs.empty()) {
|
|
|
|
|
if (auto SecContribs = m_session_up->getSectionContribs()) {
|
|
|
|
|
while (auto SectionContrib = SecContribs->getNext()) {
|
|
|
|
|
auto comp_id = SectionContrib->getCompilandId();
|
|
|
|
|
if (!comp_id)
|
|
|
|
|
continue;
|
|
|
|
|
|
|
|
|
|
auto sec = SectionContrib->getAddressSection();
|
|
|
|
|
auto &sec_cs = m_sec_contribs[sec];
|
|
|
|
|
|
|
|
|
|
auto offset = SectionContrib->getAddressOffset();
|
|
|
|
|
auto it =
|
|
|
|
|
std::upper_bound(sec_cs.begin(), sec_cs.end(), offset, pred_upper);
|
|
|
|
|
|
|
|
|
|
auto size = SectionContrib->getLength();
|
|
|
|
|
sec_cs.insert(it, {offset, size, comp_id});
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Check by line number
|
|
|
|
|
if (auto Lines = data.getLineNumbers()) {
|
|
|
|
|
if (auto FirstLine = Lines->getNext())
|
|
|
|
|
return FirstLine->getCompilandId();
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Retrieve section + offset
|
|
|
|
|
uint32_t DataSection = data.getAddressSection();
|
|
|
|
|
uint32_t DataOffset = data.getAddressOffset();
|
|
|
|
|
if (DataSection == 0) {
|
|
|
|
|
if (auto RVA = data.getRelativeVirtualAddress())
|
|
|
|
|
m_session_up->addressForRVA(RVA, DataSection, DataOffset);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (DataSection) {
|
|
|
|
|
// Search by section contributions
|
|
|
|
|
auto &sec_cs = m_sec_contribs[DataSection];
|
|
|
|
|
auto it =
|
|
|
|
|
std::upper_bound(sec_cs.begin(), sec_cs.end(), DataOffset, pred_upper);
|
|
|
|
|
if (it != sec_cs.begin()) {
|
|
|
|
|
--it;
|
|
|
|
|
if (DataOffset < it->Offset + it->Size)
|
|
|
|
|
return it->CompilandId;
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
// Search in lexical tree
|
|
|
|
|
auto LexParentId = data.getLexicalParentId();
|
|
|
|
|
while (auto LexParent = m_session_up->getSymbolById(LexParentId)) {
|
|
|
|
|
if (LexParent->getSymTag() == PDB_SymType::Exe)
|
|
|
|
|
break;
|
|
|
|
|
if (LexParent->getSymTag() == PDB_SymType::Compiland)
|
|
|
|
|
return LexParentId;
|
|
|
|
|
LexParentId = LexParent->getRawSymbol().getLexicalParentId();
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
|
}
|