Revert "[lldb] Pin the shared cache when iterating over its images"

This reverts commit af969141fa because it
didn't have the intended performance benefit to offset the increase in
our (virtual) memory usage.
This commit is contained in:
Jonas Devlieghere
2022-04-14 15:05:07 -07:00
parent 142cbd500b
commit 03049c5125

View File

@@ -2712,7 +2712,7 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
if (process_shared_cache_uuid.IsValid() &&
process_shared_cache_uuid != UUID::fromOptionalData(&cache_uuid, 16))
return;
const bool pinned = dyld_shared_cache_pin_mapping(shared_cache);
dyld_shared_cache_for_each_image(shared_cache, ^(dyld_image_t image) {
uuid_t dsc_image_uuid;
if (found_image)
@@ -2769,8 +2769,6 @@ void ObjectFileMachO::ParseSymtab(Symtab &symtab) {
nlist_count = nlistCount;
});
});
if (pinned)
dyld_shared_cache_unpin_mapping(shared_cache);
});
if (nlist_buffer) {
DataExtractor dsc_local_symbols_data(nlist_buffer,