Make GetInstanceSettingsValue methods take an Error * rather than an Error &,

and have them return a bool to indicate success or not.

llvm-svn: 114361
This commit is contained in:
Caroline Tice
2010-09-20 21:37:42 +00:00
parent db5c09a8cd
commit 12cecd741d
10 changed files with 46 additions and 34 deletions

View File

@@ -1375,11 +1375,11 @@ DebuggerInstanceSettings::UpdateInstanceSettingsVariable (const ConstString &var
}
}
void
bool
DebuggerInstanceSettings::GetInstanceSettingsValue (const SettingEntry &entry,
const ConstString &var_name,
StringList &value,
Error &err)
Error *err)
{
if (var_name == PromptVarName())
{
@@ -1404,7 +1404,12 @@ DebuggerInstanceSettings::GetInstanceSettingsValue (const SettingEntry &entry,
value.AppendString ("false");
}
else
err.SetErrorStringWithFormat ("unrecognized variable name '%s'", var_name.AsCString());
{
if (err)
err->SetErrorStringWithFormat ("unrecognized variable name '%s'", var_name.AsCString());
return false;
}
return true;
}
void