From 196a4404116e59aa1940341bb87e7025a687b88d Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Thu, 18 Apr 2019 13:33:29 +0000 Subject: [PATCH] [wasm] Simplify. NFC llvm-svn: 358663 --- lld/wasm/SymbolTable.cpp | 2 +- lld/wasm/Writer.cpp | 4 ++-- lld/wasm/WriterUtils.cpp | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lld/wasm/SymbolTable.cpp b/lld/wasm/SymbolTable.cpp index bbce07486f28..209961632df0 100644 --- a/lld/wasm/SymbolTable.cpp +++ b/lld/wasm/SymbolTable.cpp @@ -491,7 +491,7 @@ bool SymbolTable::getFunctionVariant(Symbol* Sym, const WasmSignature *Sig, // Linear search through symbol variants. Should never be more than two // or three entries here. auto &Variants = SymVariants[CachedHashStringRef(Sym->getName())]; - if (Variants.size() == 0) + if (Variants.empty()) Variants.push_back(Sym); for (Symbol* V : Variants) { diff --git a/lld/wasm/Writer.cpp b/lld/wasm/Writer.cpp index 044b38319fb1..7309bab04148 100644 --- a/lld/wasm/Writer.cpp +++ b/lld/wasm/Writer.cpp @@ -718,12 +718,12 @@ void Writer::createProducersSection() { } void Writer::createTargetFeaturesSection() { - if (TargetFeatures.size() == 0) + if (TargetFeatures.empty()) return; SmallVector Emitted(TargetFeatures.begin(), TargetFeatures.end()); - std::sort(Emitted.begin(), Emitted.end()); + llvm::sort(Emitted); SyntheticSection *Section = createSyntheticSection(WASM_SEC_CUSTOM, "target_features"); auto &OS = Section->getStream(); diff --git a/lld/wasm/WriterUtils.cpp b/lld/wasm/WriterUtils.cpp index 599b42b2217c..198c1b988b02 100644 --- a/lld/wasm/WriterUtils.cpp +++ b/lld/wasm/WriterUtils.cpp @@ -196,7 +196,7 @@ std::string lld::toString(const WasmSignature &Sig) { S += toString(Type); } S += ") -> "; - if (Sig.Returns.size() == 0) + if (Sig.Returns.empty()) S += "void"; else S += toString(Sig.Returns[0]);