From 290fa41bf63cd2f06805224a435389e08098e76d Mon Sep 17 00:00:00 2001 From: Johnny Chen Date: Sat, 17 Dec 2011 02:07:52 +0000 Subject: [PATCH] Fixed code rot pointed out by Jim. SBThread::GetStopReasonDataCount/GetStopReasonDataAtIndex() need to handle eStopReasonWatchpoint. llvm-svn: 146812 --- lldb/include/lldb/API/SBThread.h | 2 +- lldb/scripts/Python/interface/SBThread.i | 2 +- lldb/source/API/SBThread.cpp | 6 ++---- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/lldb/include/lldb/API/SBThread.h b/lldb/include/lldb/API/SBThread.h index fb721fe7e1dd..3e5158de6b95 100644 --- a/lldb/include/lldb/API/SBThread.h +++ b/lldb/include/lldb/API/SBThread.h @@ -53,7 +53,7 @@ public: /// eStopReasonNone 0 /// eStopReasonTrace 0 /// eStopReasonBreakpoint N duple: {breakpoint id, location id} - /// eStopReasonWatchpoint N duple: {watchpoint id, location id} + /// eStopReasonWatchpoint 1 watchpoint id /// eStopReasonSignal 1 unix signal number /// eStopReasonException N exception data /// eStopReasonPlanComplete 0 diff --git a/lldb/scripts/Python/interface/SBThread.i b/lldb/scripts/Python/interface/SBThread.i index 413d16c1f3f5..943996b10ff0 100644 --- a/lldb/scripts/Python/interface/SBThread.i +++ b/lldb/scripts/Python/interface/SBThread.i @@ -70,7 +70,7 @@ public: /// eStopReasonNone 0 /// eStopReasonTrace 0 /// eStopReasonBreakpoint N duple: {breakpoint id, location id} - /// eStopReasonWatchpoint N duple: {watchpoint id, location id} + /// eStopReasonWatchpoint 1 watchpoint id /// eStopReasonSignal 1 unix signal number /// eStopReasonException N exception data /// eStopReasonPlanComplete 0 diff --git a/lldb/source/API/SBThread.cpp b/lldb/source/API/SBThread.cpp index 9ea28772978a..8ed211cdf4a5 100644 --- a/lldb/source/API/SBThread.cpp +++ b/lldb/source/API/SBThread.cpp @@ -141,8 +141,7 @@ SBThread::GetStopReasonDataCount () break; case eStopReasonWatchpoint: - assert (!"implement watchpoint support in SBThread::GetStopReasonDataCount ()"); - return 0; // We don't have watchpoint support yet... + return 1; case eStopReasonSignal: return 1; @@ -201,8 +200,7 @@ SBThread::GetStopReasonDataAtIndex (uint32_t idx) break; case eStopReasonWatchpoint: - assert (!"implement watchpoint support in SBThread::GetStopReasonDataCount ()"); - return 0; // We don't have watchpoint support yet... + return stop_info_sp->GetValue(); case eStopReasonSignal: return stop_info_sp->GetValue();