intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-26 12:26:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

[mlir][linalg][transform][python] Make divisor arg to Multitile optional

Browse Source 
The mix-in of the `MultiTileSizesOp` set the default value of its
`divisor` argument. This repeats information from the tablegen
defintion, is not necessary (since the generic code deals with `None`
and default values), and has the risk of running out of sync without
people noticing. This patch removes the setting of the value and forward
`None` to the generic constructor instead.

Reviewed By: ftynse

Differential Revision: https://reviews.llvm.org/D159416
This commit is contained in:
Ingo Müller
2023-09-04 08:07:53 +00:00
parent ea4a5127c4
commit 33278321e6
2 changed files with 28 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
mlir/python/mlir/dialects/_structured_transform_ops_ext.py
View File

@@ -462,7 +462,7 @@ class MatchOp:
class MultiTileSizesOp:
"""Specialization for MultitileSizesOp class."""
"""Specialization for MultiTileSizesOp class."""
def __init__(
self,
@@ -475,8 +475,6 @@ class MultiTileSizesOp:
loc=None,
ip=None,
):
if divisor is None:
divisor = 1
super().__init__(
result_type,
result_type,