intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-15 12:25:46 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove append parameter to FindGlobalVariables

Browse Source 
Summary:
As discussed in https://bugs.llvm.org/show_bug.cgi?id=37317,
FindGlobalVariables does not properly handle the case where
append=false.  As this doesn't seem to be used in the tree, this patch
removes the parameter entirely.

Reviewers: clayborg, jingham, labath

Reviewed By: clayborg

Subscribers: aprantl, lldb-commits, kubamracek, JDevlieghere

Differential Revision: https://reviews.llvm.org/D46885
Patch by Tom Tromey <ttromey@mozilla.com>.

llvm-svn: 333639
This commit is contained in:
Pavel Labath
2018-05-31 09:46:26 +00:00
parent af3226752b
commit 34cda14b09
24 changed files with 94 additions and 150 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
lldb/source/Core/Module.cpp
View File

@@ -599,21 +599,21 @@ uint32_t Module::ResolveSymbolContextsForFileSpec(const FileSpec &file_spec,
size_t Module::FindGlobalVariables(const ConstString &name,
const CompilerDeclContext *parent_decl_ctx,
bool append, size_t max_matches,
VariableList &variables) {
SymbolVendor *symbols = GetSymbolVendor();
if (symbols)
return symbols->FindGlobalVariables(name, parent_decl_ctx, append,
max_matches, variables);
return 0;
}
size_t Module::FindGlobalVariables(const RegularExpression &regex, bool append,
size_t max_matches,
VariableList &variables) {
SymbolVendor *symbols = GetSymbolVendor();
if (symbols)
return symbols->FindGlobalVariables(regex, append, max_matches, variables);
return symbols->FindGlobalVariables(name, parent_decl_ctx, max_matches,
variables);
return 0;
}
size_t Module::FindGlobalVariables(const RegularExpression &regex,
size_t max_matches,
VariableList &variables) {
SymbolVendor *symbols = GetSymbolVendor();
if (symbols)
return symbols->FindGlobalVariables(regex, max_matches, variables);
return 0;
}