intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-02-04 20:00:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Modernize UUID class

Browse Source 
Instead of a separate GetBytes + GetByteSize methods I introduce a
single GetBytes method returning an ArrayRef.

This is NFC cleanup now, but it should make handling arbitrarily-sized
UUIDs cleaner, should we choose to go that way. I also took the
opportunity to add some unit tests for this class.

llvm-svn: 335244
This commit is contained in:
Pavel Labath
2018-06-21 15:07:43 +00:00
parent 084d360f69
commit 470b286ee5
7 changed files with 57 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
lldb/source/Interpreter/OptionValueUUID.cpp
View File

@@ -86,17 +86,12 @@ size_t OptionValueUUID::AutoComplete(CommandInterpreter &interpreter,
if (module_sp) {
const UUID &module_uuid = module_sp->GetUUID();
if (module_uuid.IsValid()) {
bool add_uuid = false;
if (num_bytes_decoded == 0)
add_uuid = true;
else
add_uuid = ::memcmp(module_uuid.GetBytes(), uuid_bytes,
num_bytes_decoded) == 0;
if (add_uuid) {
std::string uuid_str;
uuid_str = module_uuid.GetAsString();
if (!uuid_str.empty())
matches.AppendString(uuid_str.c_str());
llvm::ArrayRef<uint8_t> decoded_bytes(uuid_bytes,
num_bytes_decoded);
llvm::ArrayRef<uint8_t> module_bytes = module_uuid.GetBytes();
if (module_bytes.size() >= num_bytes_decoded &&
module_bytes.take_front(num_bytes_decoded) == decoded_bytes) {
matches.AppendString(module_uuid.GetAsString());
}
}
}