From 53fba65d220499ebc380755aca2da41a5eb33f02 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Alvarez?= Date: Wed, 12 Feb 2020 16:36:29 +0100 Subject: [PATCH] [ARCMT][NFC] Reduce #include dependencies Replace some #includes in ARCMigrate source files with more specific includes and forward declarations. This reduces the number of files that need to be rebuilt when a header changes (and saves like 1 second of build time). For example, several files no longer need to be rebuilt when the list of static analyzer checkers(!) changes. Differential Revision: https://reviews.llvm.org/D74385 --- clang/lib/ARCMigrate/ARCMT.cpp | 1 + clang/lib/ARCMigrate/Internals.h | 4 +++- clang/lib/ARCMigrate/Transforms.cpp | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/clang/lib/ARCMigrate/ARCMT.cpp b/clang/lib/ARCMigrate/ARCMT.cpp index 54c32c27b9b4..e18def8a0b19 100644 --- a/clang/lib/ARCMigrate/ARCMT.cpp +++ b/clang/lib/ARCMigrate/ARCMT.cpp @@ -7,6 +7,7 @@ //===----------------------------------------------------------------------===// #include "Internals.h" +#include "clang/ARCMigrate/ARCMT.h" #include "clang/AST/ASTConsumer.h" #include "clang/Basic/DiagnosticCategories.h" #include "clang/Frontend/ASTUnit.h" diff --git a/clang/lib/ARCMigrate/Internals.h b/clang/lib/ARCMigrate/Internals.h index 47fc09317500..ed0136e4867a 100644 --- a/clang/lib/ARCMigrate/Internals.h +++ b/clang/lib/ARCMigrate/Internals.h @@ -9,13 +9,15 @@ #ifndef LLVM_CLANG_LIB_ARCMIGRATE_INTERNALS_H #define LLVM_CLANG_LIB_ARCMIGRATE_INTERNALS_H -#include "clang/ARCMigrate/ARCMT.h" +#include "clang/Basic/LangOptions.h" #include "clang/Basic/Diagnostic.h" +#include "clang/Frontend/MigratorOptions.h" #include "llvm/ADT/ArrayRef.h" #include "llvm/ADT/Optional.h" #include namespace clang { + class ASTContext; class Sema; class Stmt; diff --git a/clang/lib/ARCMigrate/Transforms.cpp b/clang/lib/ARCMigrate/Transforms.cpp index 59b80a917e56..e274a540e408 100644 --- a/clang/lib/ARCMigrate/Transforms.cpp +++ b/clang/lib/ARCMigrate/Transforms.cpp @@ -8,6 +8,7 @@ #include "Transforms.h" #include "Internals.h" +#include "clang/ARCMigrate/ARCMT.h" #include "clang/AST/ASTContext.h" #include "clang/AST/RecursiveASTVisitor.h" #include "clang/Analysis/DomainSpecific/CocoaConventions.h"