diff --git a/lld/ELF/InputFiles.cpp b/lld/ELF/InputFiles.cpp index 364b38836129..2905f992f3bd 100644 --- a/lld/ELF/InputFiles.cpp +++ b/lld/ELF/InputFiles.cpp @@ -143,7 +143,7 @@ static bool shouldMerge(const typename ELFFile::Elf_Shdr &Sec) { if (Flags & SHF_WRITE) error("Writable SHF_MERGE sections are not supported"); uintX_t EntSize = Sec.sh_entsize; - if (Sec.sh_size % EntSize) + if (!EntSize || Sec.sh_size % EntSize) error("SHF_MERGE section size must be a multiple of sh_entsize"); // Don't try to merge if the aligment is larger than the sh_entsize. diff --git a/lld/test/elf2/Inputs/invalid-shentsize-zero.elf b/lld/test/elf2/Inputs/invalid-shentsize-zero.elf new file mode 100644 index 000000000000..5fa7df245619 Binary files /dev/null and b/lld/test/elf2/Inputs/invalid-shentsize-zero.elf differ diff --git a/lld/test/elf2/invalid-elf.test b/lld/test/elf2/invalid-elf.test index 1b5b608e7075..98c2de39df75 100644 --- a/lld/test/elf2/invalid-elf.test +++ b/lld/test/elf2/invalid-elf.test @@ -23,4 +23,8 @@ # RUN: not ld.lld2 %p/Inputs/invalid-shstrndx.so -o %t2 2>&1 | \ # RUN: FileCheck --check-prefix=INVALID-SECTION-INDEX %s +# RUN: not ld.lld2 %p/Inputs/invalid-shentsize-zero.elf -o %t2 2>&1 | \ +# RUN: FileCheck --check-prefix=INVALID-SHENTSIZE-ZERO %s +# INVALID-SHENTSIZE-ZERO: SHF_MERGE section size must be a multiple of sh_entsize + .long foo