[lldb][NFC] update API tests which skip/expect-fail arm

The architectures provided to skipIf / expectedFail are regular
expressions (v. _match_decorator_property() in decorators.py
so on Darwin systems "arm64" would match the skips for "arm" (32-bit
Linux).  Update these to "arm$" to prevent this, and also update
three tests (TestBuiltinFormats.py, TestCrossDSOTailCalls.py,
TestCrossObjectTailCalls.py) that were skipped for arm64 via this
behavior, and need to be skipped or they will fail.

This was moviated by the new TestDynamicValue.py test which has
an expected-fail for arm, but the test was passing on arm64 Darwin
resulting in failure for the CIs.
This commit is contained in:
Jason Molenda
2025-05-27 18:37:26 -07:00
parent e2f118df1d
commit 6d6feaf7e3
64 changed files with 105 additions and 103 deletions

View File

@@ -45,7 +45,7 @@ class GlobalModuleCacheTestCase(TestBase):
# On Arm and AArch64 Linux, this test attempts to pop a thread plan when
# we only have the base plan remaining. Skip it until we can figure out
# the bug this is exposing (https://github.com/llvm/llvm-project/issues/76057).
@skipIf(oslist=["linux"], archs=["arm", "aarch64"])
@skipIf(oslist=["linux"], archs=["arm$", "aarch64"])
def test_OneTargetOneDebugger(self):
self.do_test(True, True)
@@ -53,13 +53,13 @@ class GlobalModuleCacheTestCase(TestBase):
# This test tests for the desired behavior as an expected fail.
@skipIfWindows
@expectedFailureAll
@skipIf(oslist=["linux"], archs=["arm", "aarch64"])
@skipIf(oslist=["linux"], archs=["arm$", "aarch64"])
def test_TwoTargetsOneDebugger(self):
self.do_test(False, True)
@skipIfWindows
@expectedFailureAll
@skipIf(oslist=["linux"], archs=["arm", "aarch64"])
@skipIf(oslist=["linux"], archs=["arm$", "aarch64"])
def test_OneTargetTwoDebuggers(self):
self.do_test(True, False)

View File

@@ -19,7 +19,7 @@ class AddressMasksTestCase(TestBase):
self.runCmd("settings set target.process.virtual-addressable-bits 0")
self.runCmd("settings set target.process.highmem-virtual-addressable-bits 0")
@skipIf(archs=["arm"]) # 32-bit arm ABI hardcodes Code mask, is 32-bit
@skipIf(archs=["arm$"]) # 32-bit arm ABI hardcodes Code mask, is 32-bit
def test_address_masks(self):
self.build()
(target, process, t, bp) = lldbutil.run_to_source_breakpoint(
@@ -80,7 +80,7 @@ class AddressMasksTestCase(TestBase):
# AArch64 can have different address masks for high and low memory, when different
# page tables are set up.
@skipIf(archs=no_match(["arm64", "arm64e", "aarch64"]))
@skipIf(archs=["arm"]) # 32-bit arm ABI hardcodes Code mask, is 32-bit
@skipIf(archs=["arm$"]) # 32-bit arm ABI hardcodes Code mask, is 32-bit
def test_address_masks_target_supports_highmem_tests(self):
self.build()
(target, process, t, bp) = lldbutil.run_to_source_breakpoint(
@@ -113,7 +113,7 @@ class AddressMasksTestCase(TestBase):
# On most targets where we have a single mask for all address range, confirm
# that the high memory masks are ignored.
@skipIf(archs=["arm64", "arm64e", "aarch64"])
@skipIf(archs=["arm"]) # 32-bit arm ABI hardcodes Code mask, is 32-bit
@skipIf(archs=["arm$"]) # 32-bit arm ABI hardcodes Code mask, is 32-bit
def test_address_masks_target_no_highmem(self):
self.build()
(target, process, t, bp) = lldbutil.run_to_source_breakpoint(

View File

@@ -160,7 +160,7 @@ class TargetAPITestCase(TestBase):
@skipIfWindows # stdio manipulation unsupported on Windows
@skipIfRemote # stdio manipulation unsupported on remote iOS devices<rdar://problem/54581135>
@skipIf(oslist=["linux"], archs=["arm", "aarch64"])
@skipIf(oslist=["linux"], archs=["arm$", "aarch64"])
@no_debug_info_test
def test_launch_simple(self):
d = {"EXE": "b.out"}

View File

@@ -29,7 +29,7 @@ class ThreadAPITestCase(TestBase):
self.run_to_address(self.exe_name)
@skipIfAsan # The output looks different under ASAN.
@expectedFailureAll(oslist=["linux"], archs=["arm"], bugnumber="llvm.org/pr45892")
@expectedFailureAll(oslist=["linux"], archs=["arm$"], bugnumber="llvm.org/pr45892")
@expectedFailureAll(oslist=["windows"])
def test_step_out_of_malloc_into_function_b(self):
"""Test Python SBThread.StepOut() API to step out of a malloc call where the call site is at function b()."""

View File

@@ -11,7 +11,7 @@ from lldbsuite.test import lldbutil
# --keep-symbol causes error on Windows: llvm-strip.exe: error: option is not supported for COFF
@skipIfWindows
# Unnamed symbols don't get into the .eh_frame section on ARM, so LLDB can't find them.
@skipIf(archs=["arm"])
@skipIf(archs=["arm$"])
class TestUnnamedSymbolLookup(TestBase):
def test_unnamed_symbol_lookup(self):
"""Test looking up unnamed symbol synthetic name"""