intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-18 16:50:51 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use std::make_shared in LLDB (NFC)

Browse Source 
Unlike std::make_unique, which is only available since C++14,
std::make_shared is available since C++11. Not only is std::make_shared
a lot more readable compared to ::reset(new), it also performs a single
heap allocation for the object and control block.

Differential revision: https://reviews.llvm.org/D57990

llvm-svn: 353764
This commit is contained in:
Jonas Devlieghere
2019-02-11 23:13:08 +00:00
parent 6cbc92915a
commit 796ac80b86
98 changed files with 645 additions and 443 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
lldb/source/Target/Process.cpp
View File

@@ -7,6 +7,7 @@
//===----------------------------------------------------------------------===//
#include <atomic>
#include <memory>
#include <mutex>
#include "llvm/Support/ScopedPrinter.h"
@@ -163,15 +164,15 @@ ProcessProperties::ProcessProperties(lldb_private::Process *process)
{
if (process == nullptr) {
// Global process properties, set them up one time
m_collection_sp.reset(
new ProcessOptionValueProperties(ConstString("process")));
m_collection_sp =
std::make_shared<ProcessOptionValueProperties>(ConstString("process"));
m_collection_sp->Initialize(g_properties);
m_collection_sp->AppendProperty(
ConstString("thread"), ConstString("Settings specific to threads."),
true, Thread::GetGlobalProperties()->GetValueProperties());
} else {
m_collection_sp.reset(
new ProcessOptionValueProperties(Process::GetGlobalProperties().get()));
m_collection_sp = std::make_shared<ProcessOptionValueProperties>(
Process::GetGlobalProperties().get());
m_collection_sp->SetValueChangedCallback(
ePropertyPythonOSPluginPath,
ProcessProperties::OptionValueChangedCallback, this);
@@ -4670,7 +4671,8 @@ void Process::SetSTDIOFileDescriptor(int fd) {
// Now read thread is set up, set up input reader.
if (!m_process_input_reader)
m_process_input_reader.reset(new IOHandlerProcessSTDIO(this, fd));
m_process_input_reader =
std::make_shared<IOHandlerProcessSTDIO>(this, fd);
}
}
}
@@ -5944,7 +5946,8 @@ ThreadCollectionSP Process::GetHistoryThreads(lldb::addr_t addr) {
return threads;
}
threads.reset(new ThreadCollection(memory_history->GetHistoryThreads(addr)));
threads = std::make_shared<ThreadCollection>(
memory_history->GetHistoryThreads(addr));
return threads;
}