intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-16 21:55:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Bolt] Improve coding style for runtime lib related code

Browse Source 
Summary:
Reading through the LLVM coding standard again, realized a few places where I didn't follow the standard when coding. Addressing them:
1. prefer static functions over functions in unnamed namespace.
2. #include as little as possible in headers
3. Have vtable anchors.

(cherry picked from FBD22353046)
This commit is contained in:
Xun Li
2020-07-02 14:28:13 -07:00
committed by Maksim Panchenko
parent e233dec467
commit 84eae1a413
5 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
bolt/runtime/hugify.cpp
View File

@@ -24,14 +24,13 @@ extern void (*__bolt_hugify_init_ptr)();
extern uint64_t __hot_start;
extern uint64_t __hot_end;
namespace {
#ifdef MADV_HUGEPAGE
/// Starting from character at \p buf, find the longest consecutive sequence
/// of digits (0-9) and convert it to uint32_t. The converted value
/// is put into \p ret. \p end marks the end of the buffer to avoid buffer
/// overflow. The function \returns whether a valid uint32_t value is found.
/// \p buf will be updated to the next character right after the digits.
bool scanUInt32(const char *&buf, const char *end, uint32_t &ret) {
static bool scanUInt32(const char *&buf, const char *end, uint32_t &ret) {
uint64_t result = 0;
const char *oldBuf = buf;
while (buf < end && ((*buf) >= '0' && (*buf) <= '9')) {
@@ -47,7 +46,7 @@ bool scanUInt32(const char *&buf, const char *end, uint32_t &ret) {
/// Check whether the kernel supports THP by checking the kernel version.
/// Only fb kernel 5.2 and latter supports it.
bool has_pagecache_thp_support() {
static bool has_pagecache_thp_support() {
struct utsname u;
int ret = __uname(&u);
if (ret) {
@@ -92,7 +91,7 @@ bool has_pagecache_thp_support() {
return nums[1] > 2 || nums[4] >= 5;
}
void hugify_for_old_kernel(uint8_t *from, uint8_t *to) {
static void hugify_for_old_kernel(uint8_t *from, uint8_t *to) {
size_t size = to - from;
uint8_t *mem = reinterpret_cast<uint8_t *>(
@@ -164,7 +163,6 @@ extern "C" void __bolt_hugify_self_impl() {
}
#endif
}
} // anonymous namespace
/// This is hooking ELF's entry, it needs to save all machine state.
extern "C" __attribute((naked)) void __bolt_hugify_self() {