mirror of
https://github.com/intel/llvm.git
synced 2026-02-05 22:17:23 +08:00
[NFC] Remove ASCII lines from comments
A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
This commit is contained in:
@@ -259,12 +259,10 @@ Block *StackFrame::GetFrameBlock() {
|
||||
return nullptr;
|
||||
}
|
||||
|
||||
//----------------------------------------------------------------------
|
||||
// Get the symbol context if we already haven't done so by resolving the
|
||||
// PC address as much as possible. This way when we pass around a
|
||||
// StackFrame object, everyone will have as much information as possible and no
|
||||
// one will ever have to look things up manually.
|
||||
//----------------------------------------------------------------------
|
||||
const SymbolContext &
|
||||
StackFrame::GetSymbolContext(SymbolContextItem resolve_scope) {
|
||||
std::lock_guard<std::recursive_mutex> guard(m_mutex);
|
||||
@@ -1453,7 +1451,6 @@ ValueObjectSP GetValueForDereferincingOffset(StackFrame &frame,
|
||||
return GetValueForOffset(frame, pointee, offset);
|
||||
}
|
||||
|
||||
//------------------------------------------------------------------
|
||||
/// Attempt to reconstruct the ValueObject for the address contained in a
|
||||
/// given register plus an offset.
|
||||
///
|
||||
@@ -1479,7 +1476,6 @@ ValueObjectSP GetValueForDereferincingOffset(StackFrame &frame,
|
||||
/// A string describing the base for the ExpressionPath. This could be a
|
||||
/// variable, a register value, an argument, or a function return value.
|
||||
/// The ValueObject if found. If valid, it has a valid ExpressionPath.
|
||||
//------------------------------------------------------------------
|
||||
lldb::ValueObjectSP DoGuessValueAt(StackFrame &frame, ConstString reg,
|
||||
int64_t offset, Disassembler &disassembler,
|
||||
VariableList &variables, const Address &pc) {
|
||||
|
||||
Reference in New Issue
Block a user