From 8c26d440da7383a0de26dd86386c71f077160e1a Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Thu, 6 Oct 2011 22:53:35 +0000 Subject: [PATCH] Use strpbrk(3) instead of open coding it. llvm-svn: 141328 --- clang/lib/Driver/Compilation.cpp | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/clang/lib/Driver/Compilation.cpp b/clang/lib/Driver/Compilation.cpp index baaba19ed72b..d02da9588a63 100644 --- a/clang/lib/Driver/Compilation.cpp +++ b/clang/lib/Driver/Compilation.cpp @@ -70,13 +70,6 @@ const DerivedArgList &Compilation::getArgsForToolChain(const ToolChain *TC, return *Entry; } -static bool needsQuote(const char *s) { - for (const char *c = s; *c; ++c) - if (*c == ' ' || *c == '"' || *c == '\\' || *c == '$') - return true; - return false; -} - void Compilation::PrintJob(raw_ostream &OS, const Job &J, const char *Terminator, bool Quote) const { if (const Command *C = dyn_cast(&J)) { @@ -84,7 +77,7 @@ void Compilation::PrintJob(raw_ostream &OS, const Job &J, for (ArgStringList::const_iterator it = C->getArguments().begin(), ie = C->getArguments().end(); it != ie; ++it) { OS << ' '; - if (!Quote && !needsQuote(*it)) { + if (!Quote && !std::strpbrk(*it, " \"\\$")) { OS << *it; continue; }