mirror of
https://github.com/intel/llvm.git
synced 2026-01-17 06:40:01 +08:00
[runtimes] Use LLVM libunwind from libc++abi by default (#77687)
I recently came across LIBCXXABI_USE_LLVM_UNWINDER and was surprised to notice it was disabled by default. Since we build libunwind by default and ship it in the LLVM toolchain, it would seem to make sense that libc++ and libc++abi rely on libunwind for unwinding instead of using the system-provided unwinding library (if any). Most importantly, using the system unwinder implies that libc++abi is ABI compatible with that system unwinder, which is not necessarily the case. Hence, it makes a lot more sense to instead default to using the known-to-be-compatible LLVM unwinder, and let vendors manually select a different unwinder if desired. As a follow-up change, we should probably apply the same default to compiler-rt. Differential Revision: https://reviews.llvm.org/D150897 Fixes #77662 rdar://120801778
This commit is contained in:
1
.github/workflows/libcxx-build-and-test.yaml
vendored
1
.github/workflows/libcxx-build-and-test.yaml
vendored
@@ -163,7 +163,6 @@ jobs:
|
||||
'generic-no-rtti',
|
||||
'generic-optimized-speed',
|
||||
'generic-static',
|
||||
'generic-with_llvm_unwinder',
|
||||
# TODO Find a better place for the benchmark and bootstrapping builds to live. They're either very expensive
|
||||
# or don't provide much value since the benchmark run results are too noise on the bots.
|
||||
'benchmarks',
|
||||
|
||||
Reference in New Issue
Block a user