From a2acc93140e45aa0f9948c4721d2cfe4197e9828 Mon Sep 17 00:00:00 2001 From: Rui Ueyama Date: Fri, 5 Aug 2016 01:25:45 +0000 Subject: [PATCH] Simplify. NFC. llvm-svn: 277794 --- lld/ELF/LinkerScript.cpp | 27 ++++++++------------------- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/lld/ELF/LinkerScript.cpp b/lld/ELF/LinkerScript.cpp index 661f693537d2..0d60e6511f71 100644 --- a/lld/ELF/LinkerScript.cpp +++ b/lld/ELF/LinkerScript.cpp @@ -567,12 +567,8 @@ void ScriptParser::readAsNeeded() { expect("("); bool Orig = Config->AsNeeded; Config->AsNeeded = true; - while (!Error) { - StringRef Tok = next(); - if (Tok == ")") - break; - addFile(Tok); - } + while (!Error && !skip(")")) + addFile(next()); Config->AsNeeded = Orig; } @@ -587,25 +583,18 @@ void ScriptParser::readEntry() { void ScriptParser::readExtern() { expect("("); - while (!Error) { - StringRef Tok = next(); - if (Tok == ")") - return; - Config->Undefined.push_back(Tok); - } + while (!Error && !skip(")")) + Config->Undefined.push_back(next()); } void ScriptParser::readGroup() { expect("("); - while (!Error) { + while (!Error && !skip(")")) { StringRef Tok = next(); - if (Tok == ")") - return; - if (Tok == "AS_NEEDED") { + if (Tok == "AS_NEEDED") readAsNeeded(); - continue; - } - addFile(Tok); + else + addFile(Tok); } }