Make llvm::StringRef to std::string conversions explicit.

This is how it should've been and brings it more in line with
std::string_view. There should be no functional change here.

This is mostly mechanical from a custom clang-tidy check, with a lot of
manual fixups. It uncovers a lot of minor inefficiencies.

This doesn't actually modify StringRef yet, I'll do that in a follow-up.
This commit is contained in:
Benjamin Kramer
2020-01-28 20:23:46 +01:00
parent 5eaf44f99f
commit adcd026838
895 changed files with 3319 additions and 3014 deletions

View File

@@ -88,7 +88,7 @@ OutputSection *LinkerScript::createOutputSection(StringRef name,
if (!secRef)
secRef = sec;
}
sec->location = location;
sec->location = std::string(location);
return sec;
}
@@ -324,7 +324,7 @@ static std::string getFilename(InputFile *file) {
if (!file)
return "";
if (file->archiveName.empty())
return file->getName();
return std::string(file->getName());
return (file->archiveName + "(" + file->getName() + ")").str();
}