From b18783e441a2b33bc2ce88c6bd41709f083ac2ea Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Mon, 17 Oct 2016 18:51:27 +0000 Subject: [PATCH] Update for llvm change. llvm-svn: 284409 --- lld/ELF/InputFiles.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/lld/ELF/InputFiles.cpp b/lld/ELF/InputFiles.cpp index a5f9b909f112..9c88d5f3fd90 100644 --- a/lld/ELF/InputFiles.cpp +++ b/lld/ELF/InputFiles.cpp @@ -693,7 +693,7 @@ static uint8_t mapVisibility(GlobalValue::VisibilityTypes GvVisibility) { } template -static Symbol *createBitcodeSymbol(const DenseSet &KeptComdats, +static Symbol *createBitcodeSymbol(const DenseSet &KeptComdats, const lto::InputFile::Symbol &ObjSym, StringSaver &Saver, BitcodeFile *F) { StringRef NameRef = Saver.save(ObjSym.getName()); @@ -704,10 +704,10 @@ static Symbol *createBitcodeSymbol(const DenseSet &KeptComdats, uint8_t Visibility = mapVisibility(ObjSym.getVisibility()); bool CanOmitFromDynSym = ObjSym.canBeOmittedFromSymbolTable(); - if (const Comdat *C = check(ObjSym.getComdat())) - if (!KeptComdats.count(C)) - return Symtab::X->addUndefined(NameRef, Binding, Visibility, Type, - CanOmitFromDynSym, F); + StringRef C = check(ObjSym.getComdat()); + if (!C.empty() && !KeptComdats.count(C)) + return Symtab::X->addUndefined(NameRef, Binding, Visibility, Type, + CanOmitFromDynSym, F); if (Flags & BasicSymbolRef::SF_Undefined) return Symtab::X->addUndefined(NameRef, Binding, Visibility, Type, @@ -736,11 +736,11 @@ void BitcodeFile::parse(DenseSet &ComdatGroups) { Obj = check(lto::InputFile::create(MemoryBufferRef( MB.getBuffer(), Saver.save(ArchiveName + MB.getBufferIdentifier() + utostr(OffsetInArchive))))); - DenseSet KeptComdats; + DenseSet KeptComdats; for (const auto &P : Obj->getComdatSymbolTable()) { StringRef N = Saver.save(P.first()); if (ComdatGroups.insert(N).second) - KeptComdats.insert(&P.second); + KeptComdats.insert(N); } for (const lto::InputFile::Symbol &ObjSym : Obj->symbols())