From bccd34f32342e0f299d528ffbb70c825eee983d5 Mon Sep 17 00:00:00 2001 From: Sam Elliott Date: Tue, 8 Jul 2025 21:40:29 -0700 Subject: [PATCH] [SelectionDAG] Correctly Mark Required Analyses (#147649) llvm/llvm-project#147560 changed when the legacy SelectionDAG pass needs TargetTransformInfoWrapperPass to always require it (rather than only when assertions are enabled). `SelectionDAGISelLegacy::getAnalysisUsage` was not updated in that PR, which was causing crashes on assertions-disabled builds, which are hard to track down. This makes the required update, which should avoid crashes being seen on some buildbots and by some users. --- llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp index 6260ad2f24de..26071ed70c9d 100644 --- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp @@ -396,9 +396,7 @@ void SelectionDAGISelLegacy::getAnalysisUsage(AnalysisUsage &AU) const { AU.addRequired(); AU.addPreserved(); AU.addRequired(); -#ifndef NDEBUG AU.addRequired(); -#endif AU.addRequired(); if (UseMBPI && OptLevel != CodeGenOptLevel::None) AU.addRequired();