From bd4885f129a7a511c033410bce76d46c9c74a3b3 Mon Sep 17 00:00:00 2001 From: Enrico Granata Date: Thu, 10 Apr 2014 18:17:30 +0000 Subject: [PATCH] The "unexpected value" message only matters to me, but is bound to make the experience more confusing for people when some uninitialized memory looks like an NSNumber and then can't be formatted properly, and that error comes out in the UI Just drop the error message entirely - nobody but me cares llvm-svn: 205978 --- lldb/source/DataFormatters/Cocoa.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lldb/source/DataFormatters/Cocoa.cpp b/lldb/source/DataFormatters/Cocoa.cpp index 555954db0bb7..8e92de4ddaa4 100644 --- a/lldb/source/DataFormatters/Cocoa.cpp +++ b/lldb/source/DataFormatters/Cocoa.cpp @@ -342,8 +342,7 @@ lldb_private::formatters::NSNumberSummaryProvider (ValueObject& valobj, Stream& stream.Printf("(long)%" PRId64,value); break; default: - stream.Printf("unexpected value:(info=%" PRIu64 ", value=%" PRIu64,i_bits,value); - break; + return false; } return true; } @@ -402,8 +401,7 @@ lldb_private::formatters::NSNumberSummaryProvider (ValueObject& valobj, Stream& break; } default: - stream.Printf("unexpected value: dt=%d",data_type); - break; + return false; } return true; }