Don't allow direct access to StreamString's internal buffer.

This is a large API change that removes the two functions from
StreamString that return a std::string& and a const std::string&,
and instead provide one function which returns a StringRef.

Direct access to the underlying buffer violates the concept of
a "stream" which is intended to provide forward only access,
and makes porting to llvm::raw_ostream more difficult in the
future.

Differential Revision: https://reviews.llvm.org/D26698

llvm-svn: 287152
This commit is contained in:
Zachary Turner
2016-11-16 21:15:24 +00:00
parent 725dc14bb2
commit c156427ded
134 changed files with 448 additions and 453 deletions

View File

@@ -192,7 +192,7 @@ void ThreadPlanCallFunction::ReportRegisterState(const char *message) {
strm.EOL();
}
}
log->PutCString(strm.GetData());
log->PutString(strm.GetString());
}
}
@@ -257,7 +257,7 @@ bool ThreadPlanCallFunction::ValidatePlan(Stream *error) {
if (!m_valid) {
if (error) {
if (m_constructor_errors.GetSize() > 0)
error->PutCString(m_constructor_errors.GetData());
error->PutCString(m_constructor_errors.GetString());
else
error->PutCString("Unknown error");
}