intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-19 09:31:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove the #define USE_CACHE since the formatters cache has been operational for a while now and has not caused issues that warrant disabling it

Browse Source 
Also, print the cache hits statistics if the log is in debugging mode vs. LLDB being a debug build - this should make it easier to gather useful metrics on cache success rate for real users

llvm-svn: 184900
This commit is contained in:
Enrico Granata
2013-06-26 01:03:38 +00:00
parent 15571f1571
commit c2a96407c5
1 changed files with 7 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
lldb/source/DataFormatters/FormatManager.cpp
View File

@@ -334,13 +334,11 @@ GetTypeForCache (ValueObject& valobj,
return ConstString();
}
#define USE_CACHE 1
lldb::TypeSummaryImplSP
FormatManager::GetSummaryFormat (ValueObject& valobj,
lldb::DynamicValueType use_dynamic)
{
TypeSummaryImplSP retval;
#if USE_CACHE
Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_TYPES));
ConstString valobj_type(GetTypeForCache(valobj, use_dynamic));
if (valobj_type)
@@ -352,39 +350,32 @@ FormatManager::GetSummaryFormat (ValueObject& valobj,
if (log)
{
log->Printf("[FormatManager::GetSummaryFormat] Cache search success. Returning.");
#ifdef LLDB_CONFIGURATION_DEBUG
log->Printf("[FormatManager::GetSummaryFormat] Cache hits: %llu - Cache Misses: %llu", m_format_cache.GetCacheHits(), m_format_cache.GetCacheMisses());
#endif
if (log->GetDebug())
log->Printf("[FormatManager::GetSummaryFormat] Cache hits: %llu - Cache Misses: %llu", m_format_cache.GetCacheHits(), m_format_cache.GetCacheMisses());
}
return retval;
}
if (log)
log->Printf("[FormatManager::GetSummaryFormat] Cache search failed. Going normal route");
}
#endif
retval = m_categories_map.GetSummaryFormat(valobj, use_dynamic);
#if USE_CACHE
if (valobj_type)
{
if (log)
log->Printf("[FormatManager::GetSummaryFormat] Caching %p for type %s",retval.get(),valobj_type.AsCString("<invalid>"));
m_format_cache.SetSummary(valobj_type,retval);
}
#ifdef LLDB_CONFIGURATION_DEBUG
if (log)
if (log && log->GetDebug())
log->Printf("[FormatManager::GetSummaryFormat] Cache hits: %llu - Cache Misses: %llu", m_format_cache.GetCacheHits(), m_format_cache.GetCacheMisses());
#endif
#endif
return retval;
}
#ifndef LLDB_DISABLE_PYTHON
lldb::SyntheticChildrenSP
FormatManager::GetSyntheticChildren (ValueObject& valobj,
lldb::DynamicValueType use_dynamic)
lldb::DynamicValueType use_dynamic)
{
SyntheticChildrenSP retval;
#if USE_CACHE
Log *log(lldb_private::GetLogIfAllCategoriesSet (LIBLLDB_LOG_TYPES));
ConstString valobj_type(GetTypeForCache(valobj, use_dynamic));
if (valobj_type)
@@ -396,33 +387,26 @@ FormatManager::GetSyntheticChildren (ValueObject& valobj,
if (log)
{
log->Printf("[FormatManager::GetSyntheticChildren] Cache search success. Returning.");
#ifdef LLDB_CONFIGURATION_DEBUG
log->Printf("[FormatManager::GetSyntheticChildren] Cache hits: %llu - Cache Misses: %llu", m_format_cache.GetCacheHits(), m_format_cache.GetCacheMisses());
#endif
if (log->GetDebug())
log->Printf("[FormatManager::GetSyntheticChildren] Cache hits: %llu - Cache Misses: %llu", m_format_cache.GetCacheHits(), m_format_cache.GetCacheMisses());
}
return retval;
}
if (log)
log->Printf("[FormatManager::GetSyntheticChildren] Cache search failed. Going normal route");
}
#endif
retval = m_categories_map.GetSyntheticChildren(valobj, use_dynamic);
#if USE_CACHE
if (valobj_type)
{
if (log)
log->Printf("[FormatManager::GetSyntheticChildren] Caching %p for type %s",retval.get(),valobj_type.AsCString("<invalid>"));
m_format_cache.SetSynthetic(valobj_type,retval);
}
#ifdef LLDB_CONFIGURATION_DEBUG
if (log)
if (log && log->GetDebug())
log->Printf("[FormatManager::GetSyntheticChildren] Cache hits: %llu - Cache Misses: %llu", m_format_cache.GetCacheHits(), m_format_cache.GetCacheMisses());
#endif
#endif
return retval;
}
#endif
#undef USE_CACHE
FormatManager::FormatManager() :
m_format_cache(),