diff --git a/lld/ELF/InputFiles.cpp b/lld/ELF/InputFiles.cpp index 34236ac06458..fcc38f675d0e 100644 --- a/lld/ELF/InputFiles.cpp +++ b/lld/ELF/InputFiles.cpp @@ -426,9 +426,6 @@ template void SharedFile::parseRest() { uint32_t NumSymbols = std::distance(Syms.begin(), Syms.end()); SymbolBodies.reserve(NumSymbols); for (const Elf_Sym &Sym : Syms) { - // FIXME: We should probably just err if we get a local symbol in here. - if (Sym.getBinding() == STB_LOCAL) - continue; StringRef Name = check(Sym.getName(this->StringTable)); if (Sym.isUndefined()) Undefs.push_back(Name); diff --git a/lld/test/ELF/Inputs/mips-gp-disp.so b/lld/test/ELF/Inputs/mips-gp-disp.so index 9cbb43720606..150de18fcca1 100644 Binary files a/lld/test/ELF/Inputs/mips-gp-disp.so and b/lld/test/ELF/Inputs/mips-gp-disp.so differ diff --git a/lld/test/ELF/mips-gp-disp.s b/lld/test/ELF/mips-gp-disp.s index adc84c1eed7c..2110d7c04fd8 100644 --- a/lld/test/ELF/mips-gp-disp.s +++ b/lld/test/ELF/mips-gp-disp.s @@ -17,7 +17,7 @@ # INT-SO-NEXT: Binding: Local # EXT-SO: Name: _gp_disp -# EXT-SO-NEXT: Value: 0x20010 +# EXT-SO-NEXT: Value: 0x20000 # DIS: Disassembly of section .text: # DIS-NEXT: __start: