Revert "Revert "Host: generalise GetXcodeSDKPath""

This reverts commit c46d9af26c.

Rename the variable to avoid `-Wchanges-meaning` warning.  Although, it
might be better to squelch the warning as it is of low value IMO.
This commit is contained in:
Saleem Abdulrasool
2023-05-29 09:35:19 -07:00
parent 728a7de88a
commit cd21c0d30c
7 changed files with 42 additions and 12 deletions

View File

@@ -1607,8 +1607,8 @@ std::optional<std::string> Module::RemapSourceFile(llvm::StringRef path) const {
void Module::RegisterXcodeSDK(llvm::StringRef sdk_name,
llvm::StringRef sysroot) {
XcodeSDK sdk(sdk_name.str());
auto sdk_path_or_err = HostInfo::GetXcodeSDKPath(sdk);
auto sdk_path_or_err =
HostInfo::GetSDKRoot(HostInfo::SDKOptions{sdk_name.str()});
if (!sdk_path_or_err) {
Debugger::ReportError("Error while searching for Xcode SDK: " +