Refactor many file functions to use FileSpec over strings.

Summary:
This should solve the issue of sending denormalized paths over gdb-remote
if we stick to GetPath(false) in GDBRemoteCommunicationClient, and let the
server handle any denormalization.

Reviewers: ovyalov, zturner, vharron, clayborg

Reviewed By: clayborg

Subscribers: tberghammer, emaste, lldb-commits

Differential Revision: http://reviews.llvm.org/D9728

llvm-svn: 238604

lldb/source/Utility/ModuleCache.cpp

@@ -49,8 +49,7 @@ MakeDirectory (const FileSpec &dir_path)
         return Error ();
     }
 
-    return FileSystem::MakeDirectory (dir_path.GetPath ().c_str (),
-                                      eFilePermissionsDirectoryDefault);
+    return FileSystem::MakeDirectory(dir_path, eFilePermissionsDirectoryDefault);
 }
 
 FileSpec
@@ -72,7 +71,7 @@ CreateHostSysRootModuleLink (const FileSpec &root_dir_spec, const char *hostname
     if (error.Fail ())
         return error;
 
-    return FileSystem::Hardlink (sysroot_module_path_spec.GetPath ().c_str (), local_module_spec.GetPath ().c_str ());
+    return FileSystem::Hardlink(sysroot_module_path_spec, local_module_spec);
 }
 
 }  // namespace