intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-17 06:40:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

Replace 'ap' with 'up' suffix in variable names. (NFC)

Browse Source 
The `ap` suffix is a remnant of lldb's former use of auto pointers,
before they got deprecated. Although all their uses were replaced by
unique pointers, some variables still carried the suffix.

In r353795 I removed another auto_ptr remnant, namely redundant calls to
::get for unique_pointers. Jim justly noted that this is a good
opportunity to clean up the variable names as well.

I went over all the changes to ensure my find-and-replace didn't have
any undesired side-effects. I hope I didn't miss any, but if you end up
at this commit doing a git blame on a weirdly named variable, please
know that the change was unintentional.

llvm-svn: 353912
This commit is contained in:
Jonas Devlieghere
2019-02-13 06:25:41 +00:00
parent 5cf777e413
commit d5b440369d
190 changed files with 1963 additions and 1959 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
lldb/source/API/SBMemoryRegionInfo.cpp
View File

@@ -17,16 +17,16 @@ using namespace lldb;
using namespace lldb_private;
SBMemoryRegionInfo::SBMemoryRegionInfo()
: m_opaque_ap(new MemoryRegionInfo()) {}
: m_opaque_up(new MemoryRegionInfo()) {}
SBMemoryRegionInfo::SBMemoryRegionInfo(const MemoryRegionInfo *lldb_object_ptr)
: m_opaque_ap(new MemoryRegionInfo()) {
: m_opaque_up(new MemoryRegionInfo()) {
if (lldb_object_ptr)
ref() = *lldb_object_ptr;
}
SBMemoryRegionInfo::SBMemoryRegionInfo(const SBMemoryRegionInfo &rhs)
: m_opaque_ap(new MemoryRegionInfo()) {
: m_opaque_up(new MemoryRegionInfo()) {
ref() = rhs.ref();
}
@@ -40,7 +40,7 @@ operator=(const SBMemoryRegionInfo &rhs) {
SBMemoryRegionInfo::~SBMemoryRegionInfo() {}
void SBMemoryRegionInfo::Clear() { m_opaque_ap->Clear(); }
void SBMemoryRegionInfo::Clear() { m_opaque_up->Clear(); }
bool SBMemoryRegionInfo::operator==(const SBMemoryRegionInfo &rhs) const {
return ref() == rhs.ref();
@@ -50,47 +50,47 @@ bool SBMemoryRegionInfo::operator!=(const SBMemoryRegionInfo &rhs) const {
return ref() != rhs.ref();
}
MemoryRegionInfo &SBMemoryRegionInfo::ref() { return *m_opaque_ap; }
MemoryRegionInfo &SBMemoryRegionInfo::ref() { return *m_opaque_up; }
const MemoryRegionInfo &SBMemoryRegionInfo::ref() const { return *m_opaque_ap; }
const MemoryRegionInfo &SBMemoryRegionInfo::ref() const { return *m_opaque_up; }
lldb::addr_t SBMemoryRegionInfo::GetRegionBase() {
return m_opaque_ap->GetRange().GetRangeBase();
return m_opaque_up->GetRange().GetRangeBase();
}
lldb::addr_t SBMemoryRegionInfo::GetRegionEnd() {
return m_opaque_ap->GetRange().GetRangeEnd();
return m_opaque_up->GetRange().GetRangeEnd();
}
bool SBMemoryRegionInfo::IsReadable() {
return m_opaque_ap->GetReadable() == MemoryRegionInfo::eYes;
return m_opaque_up->GetReadable() == MemoryRegionInfo::eYes;
}
bool SBMemoryRegionInfo::IsWritable() {
return m_opaque_ap->GetWritable() == MemoryRegionInfo::eYes;
return m_opaque_up->GetWritable() == MemoryRegionInfo::eYes;
}
bool SBMemoryRegionInfo::IsExecutable() {
return m_opaque_ap->GetExecutable() == MemoryRegionInfo::eYes;
return m_opaque_up->GetExecutable() == MemoryRegionInfo::eYes;
}
bool SBMemoryRegionInfo::IsMapped() {
return m_opaque_ap->GetMapped() == MemoryRegionInfo::eYes;
return m_opaque_up->GetMapped() == MemoryRegionInfo::eYes;
}
const char *SBMemoryRegionInfo::GetName() {
return m_opaque_ap->GetName().AsCString();
return m_opaque_up->GetName().AsCString();
}
bool SBMemoryRegionInfo::GetDescription(SBStream &description) {
Stream &strm = description.ref();
const addr_t load_addr = m_opaque_ap->GetRange().base;
const addr_t load_addr = m_opaque_up->GetRange().base;
strm.Printf("[0x%16.16" PRIx64 "-0x%16.16" PRIx64 " ", load_addr,
load_addr + m_opaque_ap->GetRange().size);
strm.Printf(m_opaque_ap->GetReadable() ? "R" : "-");
strm.Printf(m_opaque_ap->GetWritable() ? "W" : "-");
strm.Printf(m_opaque_ap->GetExecutable() ? "X" : "-");
load_addr + m_opaque_up->GetRange().size);
strm.Printf(m_opaque_up->GetReadable() ? "R" : "-");
strm.Printf(m_opaque_up->GetWritable() ? "W" : "-");
strm.Printf(m_opaque_up->GetExecutable() ? "X" : "-");
strm.Printf("]");
return true;