intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-16 05:32:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused and undocumented data_offset parameter (NFC)

Browse Source 
Value::GetValueAsData() takes an undocumented parameter called
data_offset that is always 0.

Differential Revision: https://reviews.llvm.org/D65910

llvm-svn: 368330
This commit is contained in:
Adrian Prantl
2019-08-08 19:22:32 +00:00
parent 87e2c9147e
commit d9cbd2acfa
11 changed files with 19 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
lldb/source/Core/Value.cpp
View File

@@ -314,7 +314,7 @@ bool Value::GetData(DataExtractor &data) {
}
Status Value::GetValueAsData(ExecutionContext *exe_ctx, DataExtractor &data,
uint32_t data_offset, Module *module) {
Module *module) {
data.Clear();
Status error;
@@ -520,13 +520,12 @@ Status Value::GetValueAsData(ExecutionContext *exe_ctx, DataExtractor &data,
// Make sure we have enough room within "data", and if we don't make
// something large enough that does
if (!data.ValidOffsetForDataOfSize(data_offset, byte_size)) {
auto data_sp =
std::make_shared<DataBufferHeap>(data_offset + byte_size, '\0');
if (!data.ValidOffsetForDataOfSize(0, byte_size)) {
auto data_sp = std::make_shared<DataBufferHeap>(byte_size, '\0');
data.SetData(data_sp);
}
uint8_t *dst = const_cast<uint8_t *>(data.PeekData(data_offset, byte_size));
uint8_t *dst = const_cast<uint8_t *>(data.PeekData(0, byte_size));
if (dst != nullptr) {
if (address_type == eAddressTypeHost) {
// The address is an address in this process, so just copy it.
@@ -597,7 +596,7 @@ Scalar &Value::ResolveValue(ExecutionContext *exe_ctx) {
{
DataExtractor data;
lldb::addr_t addr = m_value.ULongLong(LLDB_INVALID_ADDRESS);
Status error(GetValueAsData(exe_ctx, data, 0, nullptr));
Status error(GetValueAsData(exe_ctx, data, nullptr));
if (error.Success()) {
Scalar scalar;
if (compiler_type.GetValueAsScalar(data, 0, data.GetByteSize(),