From dfb1e2a1a148c3d269e2d03e572747425b2dbb53 Mon Sep 17 00:00:00 2001 From: Rui Ueyama Date: Tue, 2 May 2017 02:58:04 +0000 Subject: [PATCH] Update commetns. llvm-svn: 301896 --- lld/ELF/InputFiles.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lld/ELF/InputFiles.cpp b/lld/ELF/InputFiles.cpp index 9f14adda4096..12867bbd071c 100644 --- a/lld/ELF/InputFiles.cpp +++ b/lld/ELF/InputFiles.cpp @@ -410,9 +410,11 @@ elf::ObjectFile::createInputSection(const Elf_Shdr &Sec, // Mergeable sections with relocations are tricky because relocations // need to be taken into account when comparing section contents for - // merging. The MergeInputSection class currently doesn't care about - // relocations, and it's unlikely to support it in future because such - // sections are rare. We simply handle such sections as non-mergeable. + // merging. It doesn't worth supporting such mergeable sections because + // they are rare and it'd complicates the internal design (we usually + // have to determine if two sections are mergeable early in the link + // process much before applying relocations). We simply handle mergeable + // sections with relocations as non-mergeable. if (auto *MS = dyn_cast(Target)) { Target = toRegularSection(MS); this->Sections[Sec.sh_info] = Target;