mirror of
https://github.com/intel/llvm.git
synced 2026-01-18 16:50:51 +08:00
Add setting to require hardware breakpoints.
When debugging read-only memory we cannot use software breakpoint. We already have support for hardware breakpoints and users can specify them with `-H`. However, there's no option to force LLDB to use hardware breakpoints internally, for example while stepping. This patch adds a setting target.require-hardware-breakpoint that forces LLDB to always use hardware breakpoints. Because hardware breakpoints are a limited resource and can fail to resolve, this patch also extends error handling in thread plans, where breakpoints are used for stepping. Differential revision: https://reviews.llvm.org/D54221 llvm-svn: 346920
This commit is contained in:
@@ -1920,7 +1920,7 @@ Process::CreateBreakpointSite(const BreakpointLocationSP &owner,
|
||||
owner->SetBreakpointSite(bp_site_sp);
|
||||
return m_breakpoint_site_list.Add(bp_site_sp);
|
||||
} else {
|
||||
if (show_error) {
|
||||
if (show_error || use_hardware) {
|
||||
// Report error for setting breakpoint...
|
||||
GetTarget().GetDebugger().GetErrorFile()->Printf(
|
||||
"warning: failed to set breakpoint site at 0x%" PRIx64
|
||||
|
||||
Reference in New Issue
Block a user