intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-19 09:31:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

<rdar://problem/10103468>

Browse Source 
I started work on being able to add symbol files after a debug session
had started with a new "target symfile add" command and quickly ran into
problems with stale Address objects in breakpoint locations that had 
lldb_private::Section pointers into modules that had been removed or 
replaced. This also let to grabbing stale modules from those sections. 
So I needed to thread harded the Address, Section and related objects.

To do this I modified the ModuleChild class to now require a ModuleSP
on initialization so that a weak reference can created. I also changed
all places that were handing out "Section *" to have them hand out SectionSP.
All ObjectFile, SymbolFile and SymbolVendors were inheriting from ModuleChild
so all of the find plug-in, static creation function and constructors now
require ModuleSP references instead of Module *. 

Address objects now have weak references to their sections which can
safely go stale when a module gets destructed. 

This checkin doesn't complete the "target symfile add" command, but it
does get us a lot clioser to being able to do such things without a high
risk of crashing or memory corruption.

llvm-svn: 151336
This commit is contained in:
Greg Clayton
2012-02-24 01:59:29 +00:00
parent da97054114
commit e72dfb321c
90 changed files with 1357 additions and 1027 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lldb/source/API/SBAddress.cpp
View File

@@ -32,7 +32,7 @@ namespace lldb_private
}
AddressImpl (const Address &addr) :
m_module_sp (addr.GetModuleSP()),
m_module_sp (addr.GetModule()),
m_address (addr)
{
}
@@ -105,7 +105,7 @@ SBAddress::SBAddress (const SBAddress &rhs) :
SBAddress::SBAddress (lldb::SBSection section, lldb::addr_t offset) :
m_opaque_ap(new AddressImpl (Address(section.GetSection(), offset)))
m_opaque_ap(new AddressImpl (Address(section.GetSP(), offset)))
{
}
@@ -151,7 +151,7 @@ void
SBAddress::SetAddress (lldb::SBSection section, lldb::addr_t offset)
{
Address &addr = ref();
addr.SetSection (section.GetSection());
addr.SetSection (section.GetSP());
addr.SetOffset (offset);
}
@@ -241,7 +241,7 @@ SBAddress::GetSection ()
{
lldb::SBSection sb_section;
if (m_opaque_ap.get())
sb_section.SetSection(m_opaque_ap->GetAddress().GetSection());
sb_section.SetSP (m_opaque_ap->GetAddress().GetSection());
return sb_section;
}