mirror of
https://github.com/intel/llvm.git
synced 2026-01-19 17:45:07 +08:00
<rdar://problem/10103468>
I started work on being able to add symbol files after a debug session had started with a new "target symfile add" command and quickly ran into problems with stale Address objects in breakpoint locations that had lldb_private::Section pointers into modules that had been removed or replaced. This also let to grabbing stale modules from those sections. So I needed to thread harded the Address, Section and related objects. To do this I modified the ModuleChild class to now require a ModuleSP on initialization so that a weak reference can created. I also changed all places that were handing out "Section *" to have them hand out SectionSP. All ObjectFile, SymbolFile and SymbolVendors were inheriting from ModuleChild so all of the find plug-in, static creation function and constructors now require ModuleSP references instead of Module *. Address objects now have weak references to their sections which can safely go stale when a module gets destructed. This checkin doesn't complete the "target symfile add" command, but it does get us a lot clioser to being able to do such things without a high risk of crashing or memory corruption. llvm-svn: 151336
This commit is contained in:
@@ -1366,8 +1366,7 @@ DataExtractor::Dump (Stream *s,
|
||||
lldb_private::Address so_addr;
|
||||
if (!target_sp->GetSectionLoadList().ResolveLoadAddress(addr, so_addr))
|
||||
{
|
||||
so_addr.SetOffset(addr);
|
||||
so_addr.SetSection(NULL);
|
||||
so_addr.SetRawAddress(addr);
|
||||
}
|
||||
|
||||
size_t bytes_consumed = disassembler_sp->DecodeInstructions (so_addr, *this, start_offset, item_count, false);
|
||||
|
||||
Reference in New Issue
Block a user