intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-20 01:58:44 +08:00
Code Issues Packages Projects Releases Wiki Activity

some editing of data visualization error messages to make them more meaningful

Browse Source 
debugging printfs() for data visualization turned into a meaningful log:
 - introduced a new log category `types' in channel `lldb'

llvm-svn: 135773
This commit is contained in:
Enrico Granata
2011-07-22 17:03:19 +00:00
parent 4535b9194a
commit e992a0899e
6 changed files with 152 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
lldb/source/Core/ValueObject.cpp
View File

@@ -885,6 +885,9 @@ ValueObject::GetValueAsCString ()
return m_value_str.c_str();
}
// this call should only return pointers to data that needs no special memory management
// (either because they are hardcoded strings, or because they are backed by some other
// object); returning any new()-ed or malloc()-ed data here, will lead to leaks!
const char *
ValueObject::GetPrintableRepresentation(ValueObjectRepresentationStyle val_obj_display,
lldb::Format custom_format)
@@ -921,10 +924,18 @@ ValueObject::GetPrintableRepresentation(ValueObjectRepresentationStyle val_obj_d
if (val_obj_display == eDisplayValue)
return_value = GetSummaryAsCString();
else if (val_obj_display == eDisplaySummary)
return_value = GetValueAsCString();
{
if (ClangASTContext::IsAggregateType (GetClangType()) == true)
{
// this thing has no value
return_value = "<no summary defined for this datatype>";
}
else
return_value = GetValueAsCString();
}
}
return (return_value ? return_value : "<error>");
return (return_value ? return_value : "<no printable representation>");
}
@@ -980,7 +991,7 @@ ValueObject::DumpPrintableRepresentation(Stream& s,
ValueObjectSP child = GetChildAtIndex(low,true);
if (!child.get())
{
s << "<error>";
s << "<invalid child>";
continue;
}
child->DumpPrintableRepresentation(s, ValueObject::eDisplayValue, custom_format);
@@ -1018,7 +1029,7 @@ ValueObject::DumpPrintableRepresentation(Stream& s,
ValueObjectSP child = GetChildAtIndex(low,true);
if (!child.get())
{
s << "<error>";
s << "<invalid child>";
continue;
}
child->DumpPrintableRepresentation(s, ValueObject::eDisplayValue, format);