From ea9fc18163568dde4561c1d02261eb21f5aca0a7 Mon Sep 17 00:00:00 2001 From: Johnny Chen Date: Mon, 20 Sep 2010 16:36:43 +0000 Subject: [PATCH] Fixed lldb 'settings set term-widt 70' command not working. rdar://problem/8449849 llvm-svn: 114328 --- lldb/source/Core/Debugger.cpp | 2 +- lldb/test/settings/TestSettings.py | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/lldb/source/Core/Debugger.cpp b/lldb/source/Core/Debugger.cpp index 767b528aa42d..eb46c238538b 100644 --- a/lldb/source/Core/Debugger.cpp +++ b/lldb/source/Core/Debugger.cpp @@ -1311,7 +1311,7 @@ DebuggerInstanceSettings::ValidTermWidthValue (const char *value, Error err) char *end = NULL; const uint32_t width = ::strtoul (value, &end, 0); - if (end && end == '\0') + if (end && end[0] == '\0') { if (width >= 10 || width <= 1024) valid = true; diff --git a/lldb/test/settings/TestSettings.py b/lldb/test/settings/TestSettings.py index 733b0af34e5c..04e4ad0d2881 100644 --- a/lldb/test/settings/TestSettings.py +++ b/lldb/test/settings/TestSettings.py @@ -30,9 +30,6 @@ class SettingsCommandTestCase(TestBase): self.expect("settings show", substrs = ["prompt (string) = 'lldb2'"]) - @unittest2.expectedFailure - # rdar://problem/8449849 - # settings test case failure (probably after r114252) def test_set_term_width(self): """Test that 'set term-width' actually changes the term-width."""