From fe98cce6a91c7240a541b213d43d1132c684fd9c Mon Sep 17 00:00:00 2001 From: Alex Langford Date: Thu, 9 Nov 2023 13:34:59 -0800 Subject: [PATCH] [lldb] Change Breakpoint::AddName return value (#71236) The return value is completely unused. Let's just return nothing. --- lldb/include/lldb/Breakpoint/Breakpoint.h | 5 ++--- lldb/source/Breakpoint/Breakpoint.cpp | 3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/lldb/include/lldb/Breakpoint/Breakpoint.h b/lldb/include/lldb/Breakpoint/Breakpoint.h index f2380157f111..3a8b29aee544 100644 --- a/lldb/include/lldb/Breakpoint/Breakpoint.h +++ b/lldb/include/lldb/Breakpoint/Breakpoint.h @@ -523,9 +523,8 @@ public: lldb::SearchFilterSP GetSearchFilter() { return m_filter_sp; } -private: // The target needs to manage adding & removing names. It will do the - // checking for name validity as well. - bool AddName(llvm::StringRef new_name); +private: + void AddName(llvm::StringRef new_name); void RemoveName(const char *name_to_remove) { if (name_to_remove) diff --git a/lldb/source/Breakpoint/Breakpoint.cpp b/lldb/source/Breakpoint/Breakpoint.cpp index ff4f195ea309..a94498a23a0f 100644 --- a/lldb/source/Breakpoint/Breakpoint.cpp +++ b/lldb/source/Breakpoint/Breakpoint.cpp @@ -841,9 +841,8 @@ bool Breakpoint::HasResolvedLocations() const { size_t Breakpoint::GetNumLocations() const { return m_locations.GetSize(); } -bool Breakpoint::AddName(llvm::StringRef new_name) { +void Breakpoint::AddName(llvm::StringRef new_name) { m_name_list.insert(new_name.str()); - return true; } void Breakpoint::GetDescription(Stream *s, lldb::DescriptionLevel level,