mirror of
https://github.com/intel/llvm.git
synced 2026-01-24 08:30:34 +08:00
579e70c9b0
We want to do a better job presenting errors that occur when evaluating expressions. Key to this effort is getting away from a model where all errors are spat out onto a stream where the client has to take or leave all of them. To this end, this patch adds a new class, DiagnosticManager, which contains errors produced by the compiler or by LLDB as an expression is created. The DiagnosticManager can dump itself to a log as well as to a string. Clients will (in the future) be able to filter out the errors they're interested in by ID or present subsets of these errors to the user. This patch is not intended to change the *users* of errors - only to thread DiagnosticManagers to all the places where streams are used. I also attempt to standardize our use of errors a bit, removing trailing newlines and making clients omit 'error:', 'warning:' etc. and instead pass the Severity flag. The patch is testsuite-neutral, with modifications to one part of the MI tests because it relied on "error: error:" being erroneously printed. This patch fixes the MI variable handling and the testcase. <rdar://problem/22864976> llvm-svn: 263859
88 lines
2.0 KiB
C++
88 lines
2.0 KiB
C++
//===-- DiagnosticManager.cpp -----------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lldb/Expression/DiagnosticManager.h"
|
|
#include "lldb/Core/Log.h"
|
|
#include "lldb/Core/StreamString.h"
|
|
|
|
using namespace lldb_private;
|
|
|
|
void
|
|
DiagnosticManager::Dump(Log *log)
|
|
{
|
|
if (!log)
|
|
return;
|
|
|
|
std::string str = GetString();
|
|
|
|
// GetString() puts a separator after each diagnostic.
|
|
// We want to remove the last '\n' because log->PutCString will add one for us.
|
|
|
|
if (str.size() && str.back() == '\n')
|
|
{
|
|
str.pop_back();
|
|
}
|
|
|
|
log->PutCString(str.c_str());
|
|
}
|
|
|
|
static const char *
|
|
StringForSeverity(DiagnosticSeverity severity)
|
|
{
|
|
switch (severity)
|
|
{
|
|
// this should be exhaustive
|
|
case lldb_private::eDiagnosticSeverityError:
|
|
return "error: ";
|
|
case lldb_private::eDiagnosticSeverityWarning:
|
|
return "warning: ";
|
|
case lldb_private::eDiagnosticSeverityRemark:
|
|
return "";
|
|
}
|
|
}
|
|
|
|
std::string
|
|
DiagnosticManager::GetString(char separator)
|
|
{
|
|
std::string ret;
|
|
|
|
for (const Diagnostic &diagnostic : Diagnostics())
|
|
{
|
|
ret.append(StringForSeverity(diagnostic.severity));
|
|
ret.append(diagnostic.message);
|
|
ret.push_back(separator);
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
size_t
|
|
DiagnosticManager::Printf(DiagnosticSeverity severity, const char *format, ...)
|
|
{
|
|
StreamString ss;
|
|
|
|
va_list args;
|
|
va_start(args, format);
|
|
size_t result = ss.PrintfVarArg(format, args);
|
|
va_end(args);
|
|
|
|
AddDiagnostic(ss.GetData(), severity, eDiagnosticOriginLLDB);
|
|
|
|
return result;
|
|
}
|
|
|
|
size_t
|
|
DiagnosticManager::PutCString(DiagnosticSeverity severity, const char *cstr)
|
|
{
|
|
if (!cstr)
|
|
return 0;
|
|
AddDiagnostic(cstr, severity, eDiagnosticOriginLLDB);
|
|
return strlen(cstr);
|
|
}
|