Files
llvm/lldb/source/Target/StructuredDataPlugin.cpp
Adrian Prantl 0e4c482124 Pass ConstString by value (NFC)
My apologies for the large patch. With the exception of ConstString.h
itself it was entirely produced by sed.

ConstString has exactly one const char * data member, so passing a
ConstString by reference is not any more efficient than copying it by
value. In both cases a single pointer is passed. But passing it by
value makes it harder to accidentally return the address of a local
object.

(This fixes rdar://problem/48640859 for the Apple folks)

Differential Revision: https://reviews.llvm.org/D59030

llvm-svn: 355553
2019-03-06 21:22:25 +00:00

68 lines
2.3 KiB
C++

//===-- StructuredDataPlugin.cpp --------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "lldb/Target/StructuredDataPlugin.h"
#include "lldb/Core/Debugger.h"
#include "lldb/Interpreter/CommandInterpreter.h"
#include "lldb/Interpreter/CommandObjectMultiword.h"
using namespace lldb;
using namespace lldb_private;
namespace {
class CommandStructuredData : public CommandObjectMultiword {
public:
CommandStructuredData(CommandInterpreter &interpreter)
: CommandObjectMultiword(interpreter, "structured-data",
"Parent for per-plugin structured data commands",
"plugin structured-data <plugin>") {}
~CommandStructuredData() {}
};
}
StructuredDataPlugin::StructuredDataPlugin(const ProcessWP &process_wp)
: PluginInterface(), m_process_wp(process_wp) {}
StructuredDataPlugin::~StructuredDataPlugin() {}
bool StructuredDataPlugin::GetEnabled(ConstString type_name) const {
// By default, plugins are always enabled. Plugin authors should override
// this if there is an enabled/disabled state for their plugin.
return true;
}
ProcessSP StructuredDataPlugin::GetProcess() const {
return m_process_wp.lock();
}
void StructuredDataPlugin::InitializeBasePluginForDebugger(Debugger &debugger) {
// Create our mutliword command anchor if it doesn't already exist.
auto &interpreter = debugger.GetCommandInterpreter();
if (!interpreter.GetCommandObject("plugin structured-data")) {
// Find the parent command.
auto parent_command =
debugger.GetCommandInterpreter().GetCommandObject("plugin");
if (!parent_command)
return;
// Create the structured-data ommand object.
auto command_name = "structured-data";
auto command_sp = CommandObjectSP(new CommandStructuredData(interpreter));
// Hook it up under the top-level plugin command.
parent_command->LoadSubCommand(command_name, command_sp);
}
}
void StructuredDataPlugin::ModulesDidLoad(Process &process,
ModuleList &module_list) {
// Default implementation does nothing.
}