mirror of
https://github.com/intel/llvm.git
synced 2026-01-15 12:25:46 +08:00
554f68d385
Why? Debugger::FormatPrompt() would run through the format prompt every time and parse it and emit it piece by piece. It also did formatting differently depending on which key/value pair it was parsing.
The new code improves on this with the following features:
1 - Allow format strings to be parsed into a FormatEntity::Entry which can contain multiple child FormatEntity::Entry objects. This FormatEntity::Entry is a parsed version of what was previously always done in Debugger::FormatPrompt() so it is more efficient to emit formatted strings using the new parsed FormatEntity::Entry.
2 - Allows errors in format strings to be shown immediately when setting the settings (frame-format, thread-format, disassembly-format
3 - Allows auto completion by implementing a new OptionValueFormatEntity and switching frame-format, thread-format, and disassembly-format settings over to using it.
4 - The FormatEntity::Entry for each of the frame-format, thread-format, disassembly-format settings only replaces the old one if the format parses correctly
5 - Combines all consecutive string values together for efficient output. This means all "${ansi.*}" keys and all desensitized characters like "\n" "\t" "\0721" "\x23" will get combined with their previous strings
6 - ${*.script:} (like "${var.script:mymodule.my_var_function}") have all been switched over to use ${script.*:} "${script.var:mymodule.my_var_function}") to make the format easier to parse as I don't believe anyone was using these format string power user features.
7 - All key values pairs are defined in simple C arrays of entries so it is much easier to add new entries.
These changes pave the way for subsequent modifications where we can modify formats to do more (like control the width of value strings can do more and add more functionality more easily like string formatting to control the width, printf formats and more).
llvm-svn: 228207
148 lines
3.5 KiB
C++
148 lines
3.5 KiB
C++
//===-- SBInstructionList.cpp -----------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lldb/API/SBInstructionList.h"
|
|
#include "lldb/API/SBInstruction.h"
|
|
#include "lldb/API/SBStream.h"
|
|
#include "lldb/Core/Disassembler.h"
|
|
#include "lldb/Core/Module.h"
|
|
#include "lldb/Core/Stream.h"
|
|
#include "lldb/Symbol/SymbolContext.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
|
|
SBInstructionList::SBInstructionList () :
|
|
m_opaque_sp()
|
|
{
|
|
}
|
|
|
|
SBInstructionList::SBInstructionList(const SBInstructionList &rhs) :
|
|
m_opaque_sp (rhs.m_opaque_sp)
|
|
{
|
|
}
|
|
|
|
const SBInstructionList &
|
|
SBInstructionList::operator = (const SBInstructionList &rhs)
|
|
{
|
|
if (this != &rhs)
|
|
m_opaque_sp = rhs.m_opaque_sp;
|
|
return *this;
|
|
}
|
|
|
|
|
|
SBInstructionList::~SBInstructionList ()
|
|
{
|
|
}
|
|
|
|
bool
|
|
SBInstructionList::IsValid () const
|
|
{
|
|
return m_opaque_sp.get() != NULL;
|
|
}
|
|
|
|
size_t
|
|
SBInstructionList::GetSize ()
|
|
{
|
|
if (m_opaque_sp)
|
|
return m_opaque_sp->GetInstructionList().GetSize();
|
|
return 0;
|
|
}
|
|
|
|
SBInstruction
|
|
SBInstructionList::GetInstructionAtIndex (uint32_t idx)
|
|
{
|
|
SBInstruction inst;
|
|
if (m_opaque_sp && idx < m_opaque_sp->GetInstructionList().GetSize())
|
|
inst.SetOpaque (m_opaque_sp->GetInstructionList().GetInstructionAtIndex (idx));
|
|
return inst;
|
|
}
|
|
|
|
void
|
|
SBInstructionList::Clear ()
|
|
{
|
|
m_opaque_sp.reset();
|
|
}
|
|
|
|
void
|
|
SBInstructionList::AppendInstruction (SBInstruction insn)
|
|
{
|
|
}
|
|
|
|
void
|
|
SBInstructionList::SetDisassembler (const lldb::DisassemblerSP &opaque_sp)
|
|
{
|
|
m_opaque_sp = opaque_sp;
|
|
}
|
|
|
|
void
|
|
SBInstructionList::Print (FILE *out)
|
|
{
|
|
if (out == NULL)
|
|
return;
|
|
}
|
|
|
|
|
|
bool
|
|
SBInstructionList::GetDescription (lldb::SBStream &description)
|
|
{
|
|
if (m_opaque_sp)
|
|
{
|
|
size_t num_instructions = GetSize ();
|
|
if (num_instructions)
|
|
{
|
|
// Call the ref() to make sure a stream is created if one deesn't
|
|
// exist already inside description...
|
|
Stream &sref = description.ref();
|
|
const uint32_t max_opcode_byte_size = m_opaque_sp->GetInstructionList().GetMaxOpcocdeByteSize();
|
|
FormatEntity::Entry format;
|
|
FormatEntity::Parse("${addr}: ", format);
|
|
SymbolContext sc;
|
|
SymbolContext prev_sc;
|
|
for (size_t i=0; i<num_instructions; ++i)
|
|
{
|
|
Instruction *inst = m_opaque_sp->GetInstructionList().GetInstructionAtIndex (i).get();
|
|
if (inst == NULL)
|
|
break;
|
|
|
|
const Address &addr = inst->GetAddress();
|
|
prev_sc = sc;
|
|
ModuleSP module_sp (addr.GetModule());
|
|
if (module_sp)
|
|
{
|
|
module_sp->ResolveSymbolContextForAddress(addr, eSymbolContextEverything, sc);
|
|
}
|
|
|
|
inst->Dump (&sref, max_opcode_byte_size, true, false, NULL, &sc, &prev_sc, &format);
|
|
sref.EOL();
|
|
}
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
|
|
bool
|
|
SBInstructionList::DumpEmulationForAllInstructions (const char *triple)
|
|
{
|
|
if (m_opaque_sp)
|
|
{
|
|
size_t len = GetSize();
|
|
for (size_t i = 0; i < len; ++i)
|
|
{
|
|
if (!GetInstructionAtIndex((uint32_t) i).DumpEmulation (triple))
|
|
return false;
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|