mirror of
https://github.com/intel/llvm.git
synced 2026-01-15 20:54:40 +08:00
8b3af63b89
A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
90 lines
2.8 KiB
C++
90 lines
2.8 KiB
C++
//===-- FileLineResolver.cpp ------------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lldb/Core/FileLineResolver.h"
|
|
|
|
#include "lldb/Core/FileSpecList.h"
|
|
#include "lldb/Symbol/CompileUnit.h"
|
|
#include "lldb/Symbol/LineTable.h"
|
|
#include "lldb/Utility/ConstString.h"
|
|
#include "lldb/Utility/Stream.h"
|
|
|
|
#include <string>
|
|
|
|
namespace lldb_private {
|
|
class Address;
|
|
}
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
// FileLineResolver:
|
|
FileLineResolver::FileLineResolver(const FileSpec &file_spec, uint32_t line_no,
|
|
bool check_inlines)
|
|
: Searcher(), m_file_spec(file_spec), m_line_number(line_no),
|
|
m_inlines(check_inlines) {}
|
|
|
|
FileLineResolver::~FileLineResolver() {}
|
|
|
|
Searcher::CallbackReturn
|
|
FileLineResolver::SearchCallback(SearchFilter &filter, SymbolContext &context,
|
|
Address *addr, bool containing) {
|
|
CompileUnit *cu = context.comp_unit;
|
|
|
|
if (m_inlines ||
|
|
m_file_spec.Compare(*cu, m_file_spec, (bool)m_file_spec.GetDirectory())) {
|
|
uint32_t start_file_idx = 0;
|
|
uint32_t file_idx =
|
|
cu->GetSupportFiles().FindFileIndex(start_file_idx, m_file_spec, false);
|
|
if (file_idx != UINT32_MAX) {
|
|
LineTable *line_table = cu->GetLineTable();
|
|
if (line_table) {
|
|
if (m_line_number == 0) {
|
|
// Match all lines in a file...
|
|
const bool append = true;
|
|
while (file_idx != UINT32_MAX) {
|
|
line_table->FineLineEntriesForFileIndex(file_idx, append,
|
|
m_sc_list);
|
|
// Get the next file index in case we have multiple file entries
|
|
// for the same file
|
|
file_idx = cu->GetSupportFiles().FindFileIndex(file_idx + 1,
|
|
m_file_spec, false);
|
|
}
|
|
} else {
|
|
// Match a specific line in a file...
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return Searcher::eCallbackReturnContinue;
|
|
}
|
|
|
|
lldb::SearchDepth FileLineResolver::GetDepth() {
|
|
return lldb::eSearchDepthCompUnit;
|
|
}
|
|
|
|
void FileLineResolver::GetDescription(Stream *s) {
|
|
s->Printf("File and line resolver for file: \"%s\" line: %u",
|
|
m_file_spec.GetPath().c_str(), m_line_number);
|
|
}
|
|
|
|
void FileLineResolver::Clear() {
|
|
m_file_spec.Clear();
|
|
m_line_number = UINT32_MAX;
|
|
m_sc_list.Clear();
|
|
m_inlines = true;
|
|
}
|
|
|
|
void FileLineResolver::Reset(const FileSpec &file_spec, uint32_t line,
|
|
bool check_inlines) {
|
|
m_file_spec = file_spec;
|
|
m_line_number = line;
|
|
m_sc_list.Clear();
|
|
m_inlines = check_inlines;
|
|
}
|