mirror of
https://github.com/intel/llvm.git
synced 2026-01-15 12:25:46 +08:00
5fae71c51c
Summary: This converts LLDB's logging to use llvm streams instead of lldb_private::Stream and friends. The changes are mostly straight-forward and amount to s/lldb_private::Stream/llvm::raw_ostream. The part worth calling out is the rewrite of the StreamCallback class. Previously this class contained a per-thread buffer of data written. I assume this had something to do with it trying to make sure each log line is delivered as a single event, instead of multiple (possibly interleaved) events. However, this is no longer relevant as the Log class already writes things to a temporary buffer and then delivers the message as a single "write", so I have just removed the code in question. Reviewers: zturner, clayborg Subscribers: emaste, lldb-commits, mgorny Differential Revision: https://reviews.llvm.org/D29615 llvm-svn: 294736
65 lines
2.2 KiB
C++
65 lines
2.2 KiB
C++
//===-- LLDBServerUtilities.cpp ---------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "LLDBServerUtilities.h"
|
|
|
|
#include "lldb/Core/Log.h"
|
|
#include "lldb/Core/StreamFile.h"
|
|
#include "lldb/Interpreter/Args.h"
|
|
#include "lldb/Utility/StreamString.h"
|
|
|
|
#include "llvm/ADT/SmallVector.h"
|
|
#include "llvm/ADT/StringRef.h"
|
|
#include "llvm/Support/FileSystem.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private::lldb_server;
|
|
using namespace llvm;
|
|
|
|
static std::shared_ptr<raw_ostream> GetLogStream(StringRef log_file) {
|
|
if (!log_file.empty()) {
|
|
std::error_code EC;
|
|
std::shared_ptr<raw_ostream> stream_sp = std::make_shared<raw_fd_ostream>(
|
|
log_file, EC, sys::fs::F_Text | sys::fs::F_Append);
|
|
if (!EC)
|
|
return stream_sp;
|
|
errs() << llvm::formatv(
|
|
"Failed to open log file `{0}`: {1}\nWill log to stderr instead.\n",
|
|
log_file, EC.message());
|
|
}
|
|
// No need to delete the stderr stream.
|
|
return std::shared_ptr<raw_ostream>(&errs(), [](raw_ostream *) {});
|
|
}
|
|
|
|
bool LLDBServerUtilities::SetupLogging(const std::string &log_file,
|
|
const StringRef &log_channels,
|
|
uint32_t log_options) {
|
|
|
|
auto log_stream_sp = GetLogStream(log_file);
|
|
|
|
SmallVector<StringRef, 32> channel_array;
|
|
log_channels.split(channel_array, ":", /*MaxSplit*/ -1, /*KeepEmpty*/ false);
|
|
for (auto channel_with_categories : channel_array) {
|
|
StreamString error_stream;
|
|
Args channel_then_categories(channel_with_categories);
|
|
std::string channel(channel_then_categories.GetArgumentAtIndex(0));
|
|
channel_then_categories.Shift(); // Shift off the channel
|
|
|
|
bool success = Log::EnableLogChannel(
|
|
log_stream_sp, log_options, channel.c_str(),
|
|
channel_then_categories.GetConstArgumentVector(), error_stream);
|
|
if (!success) {
|
|
fprintf(stderr, "Unable to open log file '%s' for channel \"%s\"\n",
|
|
log_file.c_str(), channel_with_categories.str().c_str());
|
|
return false;
|
|
}
|
|
}
|
|
return true;
|
|
}
|