Greg Clayton 860582f78e The IOHandlerProcessSTDIO is the _only_ IOHandler that gets pushed and popped from functions that are run due to something that is NOT input from the user. All other IOHandler objects result from input from the user. An issue rose up where if a command caused the process to resume and stop and process state changed, where state changed Event objects were broadcast, it would cause the IOHandlerProcessSTDIO to have its IOHandlerProcessSTDIO::Cancel() function called. This used to always write a byte to the control pipe (IOHandlerProcessSTDIO::m_pipe) even if the IOHandlerProcessSTDIO::Run() was never called. What would happen is: ...

(lldb) command_that_steps_process_thousands_of_times

As the "command_that_steps_process_thousands_of_times" could be a python command that resumed the process thousands of times and in doing so the IOHandlerProcessSTDIO would get pushed when the process resumed, and popped when it stoppped, causing the call to IOHandlerProcessSTDIO::Cancel(). Since the IOHandler thread is currently in IOHandlerEditline::Run() for the command interpreter handling the "command_that_steps_process_thousands_of_times" command, IOHandlerProcessSTDIO::Run() would never get called, even though the IOHandlerProcessSTDIO is on the top of the stack. This caused the command pipe to keep getting 1 bytes written each time the IOHandlerProcessSTDIO::Cancel() was called and eventually we will deadlock since the write buffer is full.

The fix here is to make sure we are in IOHandlerProcessSTDIO::Run() before we write anything to the command pipe, and just call SetIsDone(true) if we are not.

<rdar://problem/22361364>

llvm-svn: 262040

2016-02-26 17:36:44 +00:00

..

ABI.cpp

Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes.

2016-02-18 00:10:17 +00:00

CMakeLists.txt

…

CPPLanguageRuntime.cpp

…

ExecutionContext.cpp

Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes.

2016-02-18 00:10:17 +00:00

FileAction.cpp

…

InstrumentationRuntime.cpp

Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes.

2016-02-18 00:10:17 +00:00

InstrumentationRuntimeStopInfo.cpp

…

JITLoader.cpp

Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes.

2016-02-18 00:10:17 +00:00

JITLoaderList.cpp

…

Language.cpp

Objective-C++ is a kind of C++.

2016-02-12 19:47:57 +00:00

LanguageRuntime.cpp

Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes.

2016-02-18 00:10:17 +00:00

Memory.cpp

…

MemoryHistory.cpp

Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes.

2016-02-18 00:10:17 +00:00

ObjCLanguageRuntime.cpp

Now that SymbolFileDWARF supports having types in completely separate .pcm file with "-fmodules -gmodules", each SymbolFileDWARF can reference module DWARF info by looking in other DWARF files. Then if you have 1000 .o files that each reference one or more .pcm files in their debug info, a simple Module::FindTypes(...) call can end up searching the same .pcm file over and over and over. Now all internal FindTypes methods in classes (ModuleList, Module, SymbolFile) now take an extra argument:

2016-02-10 21:28:13 +00:00

OperatingSystem.cpp

Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes.

2016-02-18 00:10:17 +00:00

PathMappingList.cpp

Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes.

2016-02-18 00:10:17 +00:00

Platform.cpp

Add mips32 software breakpoints into platform::GetSoftwareBreakpointTrapOpcode().

2016-02-26 15:11:01 +00:00

Process.cpp

The IOHandlerProcessSTDIO is the _only_ IOHandler that gets pushed and popped from functions that are run due to something that is NOT input from the user. All other IOHandler objects result from input from the user. An issue rose up where if a command caused the process to resume and stop and process state changed, where state changed Event objects were broadcast, it would cause the IOHandlerProcessSTDIO to have its IOHandlerProcessSTDIO::Cancel() function called. This used to always write a byte to the control pipe (IOHandlerProcessSTDIO::m_pipe) even if the IOHandlerProcessSTDIO::Run() was never called. What would happen is:

2016-02-26 17:36:44 +00:00

ProcessInfo.cpp

Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Target; other minor fixes.

2016-02-18 18:52:47 +00:00

ProcessLaunchInfo.cpp

Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes.

2016-02-18 00:10:17 +00:00

Queue.cpp

Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Target; other minor fixes.

2016-02-18 18:52:47 +00:00

QueueItem.cpp

…

QueueList.cpp

…

RegisterContext.cpp

Fix Clang-tidy modernize-use-nullptr warnings; other minor fixes.

2016-02-18 00:10:17 +00:00

SectionLoadHistory.cpp

…

SectionLoadList.cpp

Fixed a couple of places where we were getting the module from a

2016-01-29 20:21:33 +00:00

StackFrame.cpp

Add support for DW_OP_push_object_address in dwarf expressions

2016-02-26 14:21:10 +00:00

StackFrameList.cpp

Fix all of the unannotated switch cases to annotate the fall through or do the right thing and break.

2016-02-26 01:20:20 +00:00

StackID.cpp

Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Target; other minor fixes.

2016-02-18 18:52:47 +00:00

StopInfo.cpp

Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Target; other minor fixes.

2016-02-18 18:52:47 +00:00

SystemRuntime.cpp

Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Target; other minor fixes.

2016-02-18 18:52:47 +00:00

Target.cpp

This patch stops lldb from loading a .lldbinit file from the current

2016-02-19 00:05:17 +00:00

TargetList.cpp

Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in some files in source/Target/.

2015-12-15 01:33:19 +00:00

Thread.cpp

Remove a stray ;.

2016-02-03 19:49:03 +00:00

ThreadCollection.cpp

…

ThreadList.cpp

Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in some files in source/Target/.

2015-12-15 01:33:19 +00:00

ThreadPlan.cpp

Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in some files in source/Target/.

2015-12-15 01:33:19 +00:00

ThreadPlanBase.cpp

…

ThreadPlanCallFunction.cpp

Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in some files in source/Target/.

2015-12-15 01:33:19 +00:00

ThreadPlanCallFunctionUsingABI.cpp

Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in some files in source/Target/.

2015-12-15 01:33:19 +00:00

ThreadPlanCallUserExpression.cpp

…

ThreadPlanPython.cpp

…

ThreadPlanRunToAddress.cpp

Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in some files in source/Target/.

2015-12-15 01:33:19 +00:00

ThreadPlanShouldStopHere.cpp

Re-apply r257117 (reverted in r257138 temporarily),

2016-01-08 21:40:11 +00:00

ThreadPlanStepInRange.cpp

Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in some files in source/Target/.

2015-12-15 01:33:19 +00:00

ThreadPlanStepInstruction.cpp

The SetStopInfo from a Mach Exception was setting the stop

2016-02-03 19:45:31 +00:00

ThreadPlanStepOut.cpp

Re-apply r257117 (reverted in r257138 temporarily),

2016-01-08 21:40:11 +00:00

ThreadPlanStepOverBreakpoint.cpp

…

ThreadPlanStepOverRange.cpp

Re-apply r257117 (reverted in r257138 temporarily),

2016-01-08 21:40:11 +00:00

ThreadPlanStepRange.cpp

Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in some files in source/Target/.

2015-12-15 01:33:19 +00:00

ThreadPlanStepThrough.cpp

Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in some files in source/Target/.

2015-12-15 01:33:19 +00:00

ThreadPlanStepUntil.cpp

Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in some files in source/Target/.

2015-12-15 01:33:19 +00:00

ThreadPlanTracer.cpp

Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in some files in source/Target/.

2015-12-15 01:33:19 +00:00

ThreadSpec.cpp

Fix Clang-tidy modernize-use-nullptr and readability-simplify-boolean-expr warnings in some files in source/Target/.

2015-12-15 01:33:19 +00:00

UnixSignals.cpp

Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Target; other minor fixes.

2016-02-18 18:52:47 +00:00

UnwindAssembly.cpp

Fix Clang-tidy modernize-use-nullptr warnings in some files in source/Target; other minor fixes.

2016-02-18 18:52:47 +00:00