mirror of
https://github.com/intel/llvm.git
synced 2026-01-24 08:30:34 +08:00
99b7b41edf
Currently when LLDB has enough data in the debug information to import the `std` module, it will just try to import it. However when debugging libraries where the sources aren't available anymore, importing the module will generate a confusing diagnostic that the module couldn't be built. For the fallback mode (where we retry failed expressions with the loaded module), this will cause the second expression to fail with a module built error instead of the actual parsing issue in the user expression. This patch adds checks that ensures that we at least have any source files in the found include paths before we try to import the module. This prevents the module from being loaded in the situation described above which means we don't emit the bogus 'can't import module' diagnostic and also don't waste any time retrying the expression in the fallback mode. For the unit tests I did some refactoring as they now require a VFS with the files in it and not just the paths. The Python test just builds a binary with a fake C++ module, then deletes the module before debugging. Fixes rdar://73264458 Reviewed By: JDevlieghere Differential Revision: https://reviews.llvm.org/D95096
82 lines
3.0 KiB
C++
82 lines
3.0 KiB
C++
//===-- CppModuleConfiguration.h --------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLDB_SOURCE_PLUGINS_EXPRESSIONPARSER_CLANG_CPPMODULECONFIGURATION_H
|
|
#define LLDB_SOURCE_PLUGINS_EXPRESSIONPARSER_CLANG_CPPMODULECONFIGURATION_H
|
|
|
|
#include <lldb/Core/FileSpecList.h>
|
|
#include <llvm/Support/Regex.h>
|
|
|
|
namespace lldb_private {
|
|
|
|
/// A Clang configuration when importing C++ modules.
|
|
///
|
|
/// Includes a list of include paths that should be used when importing
|
|
/// and a list of modules that can be imported. Currently only used when
|
|
/// importing the 'std' module and its dependencies.
|
|
class CppModuleConfiguration {
|
|
/// Utility class for a path that can only be set once.
|
|
class SetOncePath {
|
|
std::string m_path;
|
|
bool m_valid = false;
|
|
/// True iff this path hasn't been set yet.
|
|
bool m_first = true;
|
|
|
|
public:
|
|
/// Try setting the path. Returns true if the path was set and false if
|
|
/// the path was already set.
|
|
LLVM_NODISCARD bool TrySet(llvm::StringRef path);
|
|
/// Return the path if there is one.
|
|
llvm::StringRef Get() const {
|
|
assert(m_valid && "Called Get() on an invalid SetOncePath?");
|
|
return m_path;
|
|
}
|
|
/// Returns true iff this path was set exactly once so far.
|
|
bool Valid() const { return m_valid; }
|
|
};
|
|
|
|
/// If valid, the include path used for the std module.
|
|
SetOncePath m_std_inc;
|
|
/// If valid, the include path to the C library (e.g. /usr/include).
|
|
SetOncePath m_c_inc;
|
|
/// The Clang resource include path for this configuration.
|
|
std::string m_resource_inc;
|
|
|
|
std::vector<std::string> m_include_dirs;
|
|
std::vector<std::string> m_imported_modules;
|
|
|
|
/// Analyze a given source file to build the current configuration.
|
|
/// Returns false iff there was a fatal error that makes analyzing any
|
|
/// further files pointless as the configuration is now invalid.
|
|
bool analyzeFile(const FileSpec &f);
|
|
|
|
public:
|
|
/// Creates a configuration by analyzing the given list of used source files.
|
|
explicit CppModuleConfiguration(const FileSpecList &support_files);
|
|
/// Creates an empty and invalid configuration.
|
|
CppModuleConfiguration() {}
|
|
|
|
/// Returns true iff this is a valid configuration that can be used to
|
|
/// load and compile modules.
|
|
bool hasValidConfig();
|
|
|
|
/// Returns a list of include directories that should be used when using this
|
|
/// configuration (e.g. {"/usr/include", "/usr/include/c++/v1"}).
|
|
llvm::ArrayRef<std::string> GetIncludeDirs() const { return m_include_dirs; }
|
|
|
|
/// Returns a list of (top level) modules that should be imported when using
|
|
/// this configuration (e.g. {"std"}).
|
|
llvm::ArrayRef<std::string> GetImportedModules() const {
|
|
return m_imported_modules;
|
|
}
|
|
};
|
|
|
|
} // namespace lldb_private
|
|
|
|
#endif
|