Files
llvm/lldb/source/Utility/UserIDResolver.cpp
Pavel Labath aa51e6a683 Refactor user/group name resolving code
Summary:
This creates an abstract base class called "UserIDResolver", which can
be implemented to provide user/group ID resolution capabilities for
various objects. Posix host implement a PosixUserIDResolver, which does
that using posix apis (getpwuid and friends).  PlatformGDBRemote
forwards queries over the gdb-remote link, etc. ProcessInstanceInfo
class is refactored to make use of this interface instead of taking a
platform pointer as an argument. The base resolver class already
implements caching and thread-safety, so implementations don't have to
worry about that.

The main motivating factor for this was to remove external dependencies
from the ProcessInstanceInfo class (so it can be put next to
ProcessLaunchInfo and friends), but it has other benefits too:
- ability to test the user name caching code
- ability to test ProcessInstanceInfo dumping code
- consistent interface for user/group resolution between Platform and
  Host classes.

Reviewers: zturner, clayborg, jingham

Subscribers: mgorny, lldb-commits

Differential Revision: https://reviews.llvm.org/D58167

llvm-svn: 355323
2019-03-04 18:48:00 +00:00

45 lines
1.3 KiB
C++

//===-- UserIDResolver.cpp --------------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "lldb/Utility/UserIDResolver.h"
#include "llvm/Support/ManagedStatic.h"
using namespace lldb_private;
UserIDResolver::~UserIDResolver() = default;
llvm::Optional<llvm::StringRef> UserIDResolver::Get(
id_t id, Map &cache,
llvm::Optional<std::string> (UserIDResolver::*do_get)(id_t)) {
std::lock_guard<std::mutex> guard(m_mutex);
auto iter_bool = cache.try_emplace(id, llvm::None);
if (iter_bool.second)
iter_bool.first->second = (this->*do_get)(id);
if (iter_bool.first->second)
return llvm::StringRef(*iter_bool.first->second);
return llvm::None;
}
namespace {
class NoopResolver : public UserIDResolver {
protected:
llvm::Optional<std::string> DoGetUserName(id_t uid) override {
return llvm::None;
}
llvm::Optional<std::string> DoGetGroupName(id_t gid) override {
return llvm::None;
}
};
} // namespace
static llvm::ManagedStatic<NoopResolver> g_noop_resolver;
UserIDResolver &UserIDResolver::GetNoopResolver() { return *g_noop_resolver; }