mirror of
https://github.com/intel/llvm.git
synced 2026-01-26 03:56:16 +08:00
7a0f7dbf2d
Reapply of a22d1c2225. Using this PR for
pre-merge CI.
Instead of relying on any pass manager to schedule Polly's passes, add
Polly's own pipeline manager which is seen as a monolithic pass in
LLVM's pass manager. Polly's former passes are now phases of the new
PhaseManager component.
Relying on LLVM's pass manager (the legacy as well as the New Pass
Manager) to manage Polly's phases never was a good fit that the
PhaseManager resolves:
* Polly passes were modifying analysis results, in particular RegionInfo
and ScopInfo. This means that there was not just one unique and
"definite" analysis result, the actual result depended on which analyses
ran prior, and the pass manager was not allowed to throw away cached
analyses or prior SCoP optimizations would have been forgotten. The LLVM
pass manger's persistance of analysis results is not contractual but
designed for caching.
* Polly depends on a particular execution order of passes and regions
(e.g. regression tests, invalidation of consecutive SCoPs). LLVM's pass
manager does not guarantee any excecution order.
* Polly does not completely preserve DominatorTree, RegionInfo,
LoopInfo, or ScalarEvolution, but only as-needed for Polly's own uses.
Because the ScopDetection object stores references to those analyses, it
still had to lie to the pass manager that they would be preserved, or
the pass manager would have released and recomputed the invalidated
analysis objects that ScopDetection/ScopInfo was still referencing. To
ensure that no non-Polly pass would see these not-completely-preserved
analyses, all analyses still had to be thrown away after the
ScopPassManager, respectively with a BarrierNoopPass in case of the LPM.
* The NPM's PassInstrumentation wraps the IR unit into an `llvm::Any`
object, but implementations such as PrintIRInstrumentation call
llvm_unreachable on encountering an unknown IR unit, such as SCoPs, with
no extension points to add support. Hence LLVM crashes when dumping IR
between SCoP passes (such as `-print-before-changed` with Polly being
active).
The new PhaseManager uses some command line options that previously
belonged to Polly's legacy passes, such as `-polly-print-detect` (so the
option will continue to work). Hence the LPM support is incompatible
with the new approach and support for it is removed.
57 lines
2.1 KiB
LLVM
57 lines
2.1 KiB
LLVM
; RUN: opt %loadNPMPolly '-passes=polly<no-default-opts>' -polly-print-detect -polly-invariant-load-hoisting=true -disable-output < %s 2>&1 | FileCheck %s
|
|
;
|
|
; This crashed at some point as the pointer returned by the call
|
|
; to @__errno_location is invariant and defined in the SCoP but not
|
|
; loaded. Therefore it is not hoisted and consequently not available
|
|
; at the beginning of the SCoP where we would need it if we would try
|
|
; to hoist %tmp. We don't try to hoist %tmp anymore but this test still
|
|
; checks that this passes to code generation and produces valid code.
|
|
;
|
|
; This SCoP is currently rejected because %call9 is not considered a valid
|
|
; base pointer.
|
|
;
|
|
; CHECK-NOT: Valid Region for Scop
|
|
;
|
|
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
|
|
|
|
; Function Attrs: nounwind uwtable
|
|
define void @fileblobSetFilename() {
|
|
entry:
|
|
br i1 undef, label %if.end, label %cleanup
|
|
|
|
if.end: ; preds = %entry
|
|
br i1 undef, label %land.lhs.true, label %if.end.18
|
|
|
|
land.lhs.true: ; preds = %if.end
|
|
%call9 = tail call ptr @__errno_location()
|
|
%tmp = load i32, ptr %call9, align 4, !tbaa !1
|
|
br i1 false, label %if.then.12, label %if.end.18
|
|
|
|
if.then.12: ; preds = %land.lhs.true
|
|
br label %if.end.18
|
|
|
|
if.end.18: ; preds = %if.then.12, %land.lhs.true, %if.end
|
|
%fd.0 = phi i32 [ undef, %if.then.12 ], [ undef, %land.lhs.true ], [ undef, %if.end ]
|
|
br i1 undef, label %if.then.21, label %if.end.27
|
|
|
|
if.then.21: ; preds = %if.end.18
|
|
unreachable
|
|
|
|
if.end.27: ; preds = %if.end.18
|
|
br label %cleanup
|
|
|
|
cleanup: ; preds = %if.end.27, %entry
|
|
ret void
|
|
}
|
|
|
|
; Function Attrs: nounwind readnone
|
|
declare ptr @__errno_location()
|
|
|
|
!llvm.ident = !{!0}
|
|
|
|
!0 = !{!"clang version 3.8.0 (trunk 250010) (llvm/trunk 250018)"}
|
|
!1 = !{!2, !2, i64 0}
|
|
!2 = !{!"int", !3, i64 0}
|
|
!3 = !{!"omnipotent char", !4, i64 0}
|
|
!4 = !{!"Simple C/C++ TBAA"}
|