mirror of
https://github.com/intel/llvm.git
synced 2026-01-26 21:53:12 +08:00
5eec2b0bd3
using new/delete and OwningPtrs. After memory profiling Clang, I witnessed periodic leaks of these objects; digging deeper into the code, it was clear that our management of these objects was a mess. The ownership rules were murky at best, and not always followed. Worse, there are plenty of error paths where we could screw up. This patch introduces AttributeList::Factory, which is a factory class that creates AttributeList objects and then blows them away all at once. While conceptually simple, most of the changes in this patch just have to do with migrating over to the new interface. Most of the changes have resulted in some nice simplifications. This new strategy currently holds on to all AttributeList objects during the lifetime of the Parser object. This is easily tunable. If we desire to have more bound the lifetime of AttributeList objects more precisely, we can have the AttributeList::Factory object (in Parser) push/pop its underlying allocator as we enter/leave key methods in the Parser. This means that we get simple memory management while still having the ability to finely control memory use if necessary. Note that because AttributeList objects are now BumpPtrAllocated, we may reduce malloc() traffic in many large files with attributes. This fixes the leak reported in: <rdar://problem/8650003> llvm-svn: 118675
128 lines
4.9 KiB
C++
128 lines
4.9 KiB
C++
//===--- AttributeList.cpp --------------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file defines the AttributeList class implementation
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "clang/Sema/AttributeList.h"
|
|
#include "clang/Basic/IdentifierTable.h"
|
|
#include "llvm/ADT/StringSwitch.h"
|
|
using namespace clang;
|
|
|
|
AttributeList::AttributeList(llvm::BumpPtrAllocator &Alloc,
|
|
IdentifierInfo *aName, SourceLocation aLoc,
|
|
IdentifierInfo *sName, SourceLocation sLoc,
|
|
IdentifierInfo *pName, SourceLocation pLoc,
|
|
Expr **ExprList, unsigned numArgs,
|
|
AttributeList *n, bool declspec, bool cxx0x)
|
|
: AttrName(aName), AttrLoc(aLoc), ScopeName(sName),
|
|
ScopeLoc(sLoc),
|
|
ParmName(pName), ParmLoc(pLoc), NumArgs(numArgs), Next(n),
|
|
DeclspecAttribute(declspec), CXX0XAttribute(cxx0x), Invalid(false) {
|
|
|
|
if (numArgs == 0)
|
|
Args = 0;
|
|
else {
|
|
// Allocate the Args array using the BumpPtrAllocator.
|
|
Args = Alloc.Allocate<Expr*>(numArgs);
|
|
memcpy(Args, ExprList, numArgs*sizeof(Args[0]));
|
|
}
|
|
}
|
|
|
|
AttributeList::Kind AttributeList::getKind(const IdentifierInfo *Name) {
|
|
llvm::StringRef AttrName = Name->getName();
|
|
|
|
// Normalize the attribute name, __foo__ becomes foo.
|
|
if (AttrName.startswith("__") && AttrName.endswith("__"))
|
|
AttrName = AttrName.substr(2, AttrName.size() - 4);
|
|
|
|
return llvm::StringSwitch<AttributeList::Kind>(AttrName)
|
|
.Case("weak", AT_weak)
|
|
.Case("weakref", AT_weakref)
|
|
.Case("pure", AT_pure)
|
|
.Case("mode", AT_mode)
|
|
.Case("used", AT_used)
|
|
.Case("alias", AT_alias)
|
|
.Case("align", AT_aligned)
|
|
.Case("final", AT_final)
|
|
.Case("cdecl", AT_cdecl)
|
|
.Case("const", AT_const)
|
|
.Case("__const", AT_const) // some GCC headers do contain this spelling
|
|
.Case("blocks", AT_blocks)
|
|
.Case("format", AT_format)
|
|
.Case("hiding", AT_hiding)
|
|
.Case("malloc", AT_malloc)
|
|
.Case("packed", AT_packed)
|
|
.Case("unused", AT_unused)
|
|
.Case("aligned", AT_aligned)
|
|
.Case("cleanup", AT_cleanup)
|
|
.Case("naked", AT_naked)
|
|
.Case("nodebug", AT_nodebug)
|
|
.Case("nonnull", AT_nonnull)
|
|
.Case("nothrow", AT_nothrow)
|
|
.Case("objc_gc", AT_objc_gc)
|
|
.Case("regparm", AT_regparm)
|
|
.Case("section", AT_section)
|
|
.Case("stdcall", AT_stdcall)
|
|
.Case("annotate", AT_annotate)
|
|
.Case("fastcall", AT_fastcall)
|
|
.Case("ibaction", AT_IBAction)
|
|
.Case("iboutlet", AT_IBOutlet)
|
|
.Case("iboutletcollection", AT_IBOutletCollection)
|
|
.Case("noreturn", AT_noreturn)
|
|
.Case("noinline", AT_noinline)
|
|
.Case("override", AT_override)
|
|
.Case("sentinel", AT_sentinel)
|
|
.Case("NSObject", AT_nsobject)
|
|
.Case("dllimport", AT_dllimport)
|
|
.Case("dllexport", AT_dllexport)
|
|
.Case("may_alias", IgnoredAttribute) // FIXME: TBAA
|
|
.Case("base_check", AT_base_check)
|
|
.Case("deprecated", AT_deprecated)
|
|
.Case("visibility", AT_visibility)
|
|
.Case("destructor", AT_destructor)
|
|
.Case("format_arg", AT_format_arg)
|
|
.Case("gnu_inline", AT_gnu_inline)
|
|
.Case("weak_import", AT_weak_import)
|
|
.Case("vecreturn", AT_vecreturn)
|
|
.Case("vector_size", AT_vector_size)
|
|
.Case("constructor", AT_constructor)
|
|
.Case("unavailable", AT_unavailable)
|
|
.Case("overloadable", AT_overloadable)
|
|
.Case("address_space", AT_address_space)
|
|
.Case("always_inline", AT_always_inline)
|
|
.Case("returns_twice", IgnoredAttribute)
|
|
.Case("vec_type_hint", IgnoredAttribute)
|
|
.Case("objc_exception", AT_objc_exception)
|
|
.Case("ext_vector_type", AT_ext_vector_type)
|
|
.Case("transparent_union", AT_transparent_union)
|
|
.Case("analyzer_noreturn", AT_analyzer_noreturn)
|
|
.Case("warn_unused_result", AT_warn_unused_result)
|
|
.Case("carries_dependency", AT_carries_dependency)
|
|
.Case("ns_returns_not_retained", AT_ns_returns_not_retained)
|
|
.Case("ns_returns_retained", AT_ns_returns_retained)
|
|
.Case("cf_returns_not_retained", AT_cf_returns_not_retained)
|
|
.Case("cf_returns_retained", AT_cf_returns_retained)
|
|
.Case("ownership_returns", AT_ownership_returns)
|
|
.Case("ownership_holds", AT_ownership_holds)
|
|
.Case("ownership_takes", AT_ownership_takes)
|
|
.Case("reqd_work_group_size", AT_reqd_wg_size)
|
|
.Case("init_priority", AT_init_priority)
|
|
.Case("no_instrument_function", AT_no_instrument_function)
|
|
.Case("thiscall", AT_thiscall)
|
|
.Case("pascal", AT_pascal)
|
|
.Case("__cdecl", AT_cdecl)
|
|
.Case("__stdcall", AT_stdcall)
|
|
.Case("__fastcall", AT_fastcall)
|
|
.Case("__thiscall", AT_thiscall)
|
|
.Case("__pascal", AT_pascal)
|
|
.Default(UnknownAttribute);
|
|
}
|