mirror of
https://github.com/intel/llvm.git
synced 2026-01-30 05:55:35 +08:00
8b3af63b89
A lot of comments in LLDB are surrounded by an ASCII line to delimit the begging and end of the comment. Its use is not really consistent across the code base, sometimes the lines are longer, sometimes they are shorter and sometimes they are omitted. Furthermore, it looks kind of weird with the 80 column limit, where the comment actually extends past the line, but not by much. Furthermore, when /// is used for Doxygen comments, it looks particularly odd. And when // is used, it incorrectly gives the impression that it's actually a Doxygen comment. I assume these lines were added to improve distinguishing between comments and code. However, given that todays editors and IDEs do a great job at highlighting comments, I think it's worth to drop this for the sake of consistency. The alternative is fixing all the inconsistencies, which would create a lot more churn. Differential revision: https://reviews.llvm.org/D60508 llvm-svn: 358135
132 lines
3.8 KiB
C++
132 lines
3.8 KiB
C++
//===-- CFCMutableArray.cpp -------------------------------------*- C++ -*-===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "CFCMutableArray.h"
|
|
#include "CFCString.h"
|
|
|
|
// CFCString constructor
|
|
CFCMutableArray::CFCMutableArray(CFMutableArrayRef s)
|
|
: CFCReleaser<CFMutableArrayRef>(s) {}
|
|
|
|
// CFCMutableArray copy constructor
|
|
CFCMutableArray::CFCMutableArray(const CFCMutableArray &rhs)
|
|
: CFCReleaser<CFMutableArrayRef>(rhs) // NOTE: this won't make a copy of the
|
|
// array, just add a new reference to
|
|
// it
|
|
{}
|
|
|
|
// CFCMutableArray copy constructor
|
|
CFCMutableArray &CFCMutableArray::operator=(const CFCMutableArray &rhs) {
|
|
if (this != &rhs)
|
|
*this = rhs; // NOTE: this operator won't make a copy of the array, just add
|
|
// a new reference to it
|
|
return *this;
|
|
}
|
|
|
|
// Destructor
|
|
CFCMutableArray::~CFCMutableArray() {}
|
|
|
|
CFIndex CFCMutableArray::GetCount() const {
|
|
CFMutableArrayRef array = get();
|
|
if (array)
|
|
return ::CFArrayGetCount(array);
|
|
return 0;
|
|
}
|
|
|
|
CFIndex CFCMutableArray::GetCountOfValue(CFRange range,
|
|
const void *value) const {
|
|
CFMutableArrayRef array = get();
|
|
if (array)
|
|
return ::CFArrayGetCountOfValue(array, range, value);
|
|
return 0;
|
|
}
|
|
|
|
CFIndex CFCMutableArray::GetCountOfValue(const void *value) const {
|
|
CFMutableArrayRef array = get();
|
|
if (array)
|
|
return ::CFArrayGetCountOfValue(array, CFRangeMake(0, GetCount()), value);
|
|
return 0;
|
|
}
|
|
|
|
const void *CFCMutableArray::GetValueAtIndex(CFIndex idx) const {
|
|
CFMutableArrayRef array = get();
|
|
if (array) {
|
|
const CFIndex num_array_items = ::CFArrayGetCount(array);
|
|
if (0 <= idx && idx < num_array_items) {
|
|
return ::CFArrayGetValueAtIndex(array, idx);
|
|
}
|
|
}
|
|
return NULL;
|
|
}
|
|
|
|
bool CFCMutableArray::SetValueAtIndex(CFIndex idx, const void *value) {
|
|
CFMutableArrayRef array = get();
|
|
if (array != NULL) {
|
|
const CFIndex num_array_items = ::CFArrayGetCount(array);
|
|
if (0 <= idx && idx < num_array_items) {
|
|
::CFArraySetValueAtIndex(array, idx, value);
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
bool CFCMutableArray::AppendValue(const void *value, bool can_create) {
|
|
CFMutableArrayRef array = get();
|
|
if (array == NULL) {
|
|
if (!can_create)
|
|
return false;
|
|
array =
|
|
::CFArrayCreateMutable(kCFAllocatorDefault, 0, &kCFTypeArrayCallBacks);
|
|
reset(array);
|
|
}
|
|
if (array != NULL) {
|
|
::CFArrayAppendValue(array, value);
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
bool CFCMutableArray::AppendCStringAsCFString(const char *s,
|
|
CFStringEncoding encoding,
|
|
bool can_create) {
|
|
CFMutableArrayRef array = get();
|
|
if (array == NULL) {
|
|
if (!can_create)
|
|
return false;
|
|
array =
|
|
::CFArrayCreateMutable(kCFAllocatorDefault, 0, &kCFTypeArrayCallBacks);
|
|
reset(array);
|
|
}
|
|
if (array != NULL) {
|
|
CFCString cf_str(s, encoding);
|
|
::CFArrayAppendValue(array, cf_str.get());
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|
|
|
|
bool CFCMutableArray::AppendFileSystemRepresentationAsCFString(
|
|
const char *s, bool can_create) {
|
|
CFMutableArrayRef array = get();
|
|
if (array == NULL) {
|
|
if (!can_create)
|
|
return false;
|
|
array =
|
|
::CFArrayCreateMutable(kCFAllocatorDefault, 0, &kCFTypeArrayCallBacks);
|
|
reset(array);
|
|
}
|
|
if (array != NULL) {
|
|
CFCString cf_path;
|
|
cf_path.SetFileSystemRepresentation(s);
|
|
::CFArrayAppendValue(array, cf_path.get());
|
|
return true;
|
|
}
|
|
return false;
|
|
}
|