Files
llvm/lldb/source/Host/macosx/cfcpp/CFCMutableArray.h
Jonas Devlieghere 8b3af63b89 [NFC] Remove ASCII lines from comments
A lot of comments in LLDB are surrounded by an ASCII line to delimit the
begging and end of the comment.

Its use is not really consistent across the code base, sometimes the
lines are longer, sometimes they are shorter and sometimes they are
omitted. Furthermore, it looks kind of weird with the 80 column limit,
where the comment actually extends past the line, but not by much.
Furthermore, when /// is used for Doxygen comments, it looks
particularly odd. And when // is used, it incorrectly gives the
impression that it's actually a Doxygen comment.

I assume these lines were added to improve distinguishing between
comments and code. However, given that todays editors and IDEs do a
great job at highlighting comments, I think it's worth to drop this for
the sake of consistency. The alternative is fixing all the
inconsistencies, which would create a lot more churn.

Differential revision: https://reviews.llvm.org/D60508

llvm-svn: 358135
2019-04-10 20:48:55 +00:00

44 lines
2.0 KiB
C++

//===-- CFCMutableArray.h ---------------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#ifndef CoreFoundationCPP_CFMutableArray_h_
#define CoreFoundationCPP_CFMutableArray_h_
#include "CFCReleaser.h"
class CFCMutableArray : public CFCReleaser<CFMutableArrayRef> {
public:
// Constructors and Destructors
CFCMutableArray(CFMutableArrayRef array = NULL);
CFCMutableArray(const CFCMutableArray &rhs); // This will copy the array
// contents into a new array
CFCMutableArray &operator=(const CFCMutableArray &rhs); // This will re-use
// the same array and
// just bump the ref
// count
virtual ~CFCMutableArray();
CFIndex GetCount() const;
CFIndex GetCountOfValue(const void *value) const;
CFIndex GetCountOfValue(CFRange range, const void *value) const;
const void *GetValueAtIndex(CFIndex idx) const;
bool SetValueAtIndex(CFIndex idx, const void *value);
bool AppendValue(const void *value,
bool can_create = true); // Appends value and optionally
// creates a CFCMutableArray if this
// class doesn't contain one
bool
AppendCStringAsCFString(const char *cstr,
CFStringEncoding encoding = kCFStringEncodingUTF8,
bool can_create = true);
bool AppendFileSystemRepresentationAsCFString(const char *s,
bool can_create = true);
};
#endif // #ifndef CoreFoundationCPP_CFMutableArray_h_