Files
llvm/lldb/source/Host/macosx/cfcpp/CFCMutableSet.cpp
Jonas Devlieghere 8b3af63b89 [NFC] Remove ASCII lines from comments
A lot of comments in LLDB are surrounded by an ASCII line to delimit the
begging and end of the comment.

Its use is not really consistent across the code base, sometimes the
lines are longer, sometimes they are shorter and sometimes they are
omitted. Furthermore, it looks kind of weird with the 80 column limit,
where the comment actually extends past the line, but not by much.
Furthermore, when /// is used for Doxygen comments, it looks
particularly odd. And when // is used, it incorrectly gives the
impression that it's actually a Doxygen comment.

I assume these lines were added to improve distinguishing between
comments and code. However, given that todays editors and IDEs do a
great job at highlighting comments, I think it's worth to drop this for
the sake of consistency. The alternative is fixing all the
inconsistencies, which would create a lot more churn.

Differential revision: https://reviews.llvm.org/D60508

llvm-svn: 358135
2019-04-10 20:48:55 +00:00

77 lines
1.9 KiB
C++

//===-- CFCMutableSet.cpp ---------------------------------------*- C++ -*-===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "CFCMutableSet.h"
// CFCString constructor
CFCMutableSet::CFCMutableSet(CFMutableSetRef s)
: CFCReleaser<CFMutableSetRef>(s) {}
// CFCMutableSet copy constructor
CFCMutableSet::CFCMutableSet(const CFCMutableSet &rhs)
: CFCReleaser<CFMutableSetRef>(rhs) {}
// CFCMutableSet copy constructor
const CFCMutableSet &CFCMutableSet::operator=(const CFCMutableSet &rhs) {
if (this != &rhs)
*this = rhs;
return *this;
}
// Destructor
CFCMutableSet::~CFCMutableSet() {}
CFIndex CFCMutableSet::GetCount() const {
CFMutableSetRef set = get();
if (set)
return ::CFSetGetCount(set);
return 0;
}
CFIndex CFCMutableSet::GetCountOfValue(const void *value) const {
CFMutableSetRef set = get();
if (set)
return ::CFSetGetCountOfValue(set, value);
return 0;
}
const void *CFCMutableSet::GetValue(const void *value) const {
CFMutableSetRef set = get();
if (set)
return ::CFSetGetValue(set, value);
return NULL;
}
const void *CFCMutableSet::AddValue(const void *value, bool can_create) {
CFMutableSetRef set = get();
if (set == NULL) {
if (!can_create)
return NULL;
set = ::CFSetCreateMutable(kCFAllocatorDefault, 0, &kCFTypeSetCallBacks);
reset(set);
}
if (set != NULL) {
::CFSetAddValue(set, value);
return value;
}
return NULL;
}
void CFCMutableSet::RemoveValue(const void *value) {
CFMutableSetRef set = get();
if (set)
::CFSetRemoveValue(set, value);
}
void CFCMutableSet::RemoveAllValues() {
CFMutableSetRef set = get();
if (set)
::CFSetRemoveAllValues(set);
}